From: Lukasz Majewski <lukma@denx.de>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: at91: ksz9477_evb: Add tx-internal-delay-ps property for port5
Date: Thu, 24 Aug 2023 11:17:02 +0200 [thread overview]
Message-ID: <20230824111702.1a034801@wsk> (raw)
In-Reply-To: <20230727080656.3828397-1-lukma@denx.de>
[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]
Dear Community,
> Without this change the KSZ9477 Evaluation board's Linux (v6.5-rc1)
> shows following device warning:
>
> 'ksz-switch spi1.0: Port 5 interpreting RGMII delay settings based on
> "phy-mode" property, please update device tree to specify
> "rx-internal-delay-ps" and "tx-internal-delay-ps"'
>
> This is not critical, as KSZ driver by itself assigns default value of
> tx delay to 2000 ps (as 'rgmii-txid' is set as PHY mode).
>
> However, to avoid extra warnings in logs - the missing
> 'tx-internal-delay-ps' has been specified with the default value of
> 2000 ps.
>
Gentle ping on this patch.
Claudiu, could you pick it as well?
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
> arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
> b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts index
> 99cd6d15998b..b66570080894 100644 ---
> a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts +++
> b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts @@ -152,6
> +152,7 @@ label = "cpu";
> ethernet = <&macb0>;
> phy-mode = "rgmii-txid";
> + tx-internal-delay-ps = <2000>;
>
> fixed-link {
> speed = <1000>;
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-08-24 9:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 8:06 [PATCH] ARM: dts: at91: ksz9477_evb: Add tx-internal-delay-ps property for port5 Lukasz Majewski
2023-08-02 4:50 ` claudiu beznea
2023-08-24 9:17 ` Lukasz Majewski [this message]
2023-08-24 10:00 ` claudiu beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230824111702.1a034801@wsk \
--to=lukma@denx.de \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).