From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1B22C27C40 for ; Thu, 24 Aug 2023 21:30:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243357AbjHXV3a (ORCPT ); Thu, 24 Aug 2023 17:29:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243708AbjHXV3L (ORCPT ); Thu, 24 Aug 2023 17:29:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18D211BCC; Thu, 24 Aug 2023 14:29:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9AFCE63F71; Thu, 24 Aug 2023 21:29:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA961C433C7; Thu, 24 Aug 2023 21:29:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692912546; bh=Nfn1uNPGA9g+LWHP/3mUozCS5vINoOG8VlgUTdOkQIA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XOFbYKVl8IN8F+7YJy7gCUSHtpo5yJrbqew1xj1kBL93Atjr7q7zoOvOU9vSJMUXL SBoxuPtt0rIm4RsqefITQ9FWbLWIJQZ78g4v99V5pniwIEV6NOFqnq6DkKpAPfxh03 J26BuAFBh8WqWGizsJzPG4BaIcUTC12DykdzvB8HhO5QjaVCPyvVZyZn6KpBAZvkqC zUVsIB6UFj7oY203HDDhNjsnbsx6qNfXq5Lky6qcF8SDSCrFJ0oXl/cH+aZDlmfgfk T9gSBhxJjNhd26mFw0a5gN0ph/bHv1qj9O4A+KGDHuKqirH2M5Gsmrgy61OOCyiXax OMo/n/FBYJdug== Received: (nullmailer pid 1456158 invoked by uid 1000); Thu, 24 Aug 2023 21:29:03 -0000 Date: Thu, 24 Aug 2023 16:29:03 -0500 From: Rob Herring To: Neil Armstrong Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Herbert Xu , "David S. Miller" , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?B?77+8T20=?= Prakash Singh Subject: Re: [PATCH v2 1/7] Revert "dt-bindings: crypto: qcom,prng: Add SM8450" Message-ID: <20230824212903.GA1453763-robh@kernel.org> References: <20230824-topic-sm8550-rng-v2-0-dfcafbb16a3e@linaro.org> <20230824-topic-sm8550-rng-v2-1-dfcafbb16a3e@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230824-topic-sm8550-rng-v2-1-dfcafbb16a3e@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Aug 24, 2023 at 01:33:20PM +0200, Neil Armstrong wrote: > This reverts commit b9296bb41275 ("dt-bindings: crypto: qcom,prng: Add SM8450"), > since the RNG HW on the SM8450 SoC is in fact a True Random Number Generator, > a more appropriate compatible should be instead as reported at [1]. > > [1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/ > > Suggested-by: Om Prakash Singh > Suggested-by: Konrad Dybcio Is it just me or looks like an unrenderable character in these. > Signed-off-by: Neil Armstrong > --- > .../devicetree/bindings/crypto/qcom,prng.yaml | 24 +++++----------------- > 1 file changed, 5 insertions(+), 19 deletions(-) > > diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml > index 36b0ebd9a44b..bb42f4588b40 100644 > --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml > +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml > @@ -11,13 +11,9 @@ maintainers: > > properties: > compatible: > - oneOf: > - - enum: > - - qcom,prng # 8916 etc. > - - qcom,prng-ee # 8996 and later using EE > - - items: > - - const: qcom,sm8450-prng-ee > - - const: qcom,prng-ee > + enum: > + - qcom,prng # 8916 etc. > + - qcom,prng-ee # 8996 and later using EE > > reg: > maxItems: 1 > @@ -32,18 +28,8 @@ properties: > required: > - compatible > - reg > - > -allOf: > - - if: > - not: > - properties: > - compatible: > - contains: > - const: qcom,sm8450-prng-ee > - then: > - required: > - - clocks > - - clock-names > + - clocks > + - clock-names > > additionalProperties: false > > > -- > 2.34.1 >