From: Rob Herring <robh@kernel.org>
To: Frank Rowand <frowand.list@gmail.com>, Lizhi Hou <lizhi.hou@amd.com>
Cc: kernel test robot <lkp@intel.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] of: unittest: Fix of_unittest_pci_node() kconfig dependencies
Date: Thu, 24 Aug 2023 17:17:34 -0500 [thread overview]
Message-ID: <20230824221743.1581707-1-robh@kernel.org> (raw)
of_unittest_pci_node test depends on both CONFIG_PCI_DYNAMIC_OF_NODES
and CONFIG_OF_OVERLAY. Move the test into the existing
CONFIG_OF_OVERLAY ifdef and rework the CONFIG_PCI_DYNAMIC_OF_NODES
dependency to use IS_ENABLED() instead. This reduces the combinations to
build.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308241954.oRNfVqmB-lkp@intel.com/
Fixes: 26409dd04589 ("of: unittest: Add pci_dt_testdrv pci driver")
Cc: Lizhi Hou <lizhi.hou@amd.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/of/unittest.c | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 9c0f352cb241..ad2b7879cc67 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -3799,14 +3799,6 @@ static __init void of_unittest_overlay_high_level(void)
mutex_unlock(&of_mutex);
}
-#else
-
-static inline __init void of_unittest_overlay_high_level(void) {}
-
-#endif
-
-#ifdef CONFIG_PCI_DYNAMIC_OF_NODES
-
static int of_unittest_pci_dev_num;
static int of_unittest_pci_child_num;
@@ -3954,6 +3946,9 @@ static void __init of_unittest_pci_node(void)
struct pci_dev *pdev = NULL;
int rc;
+ if (!IS_ENABLED(CONFIG_PCI_DYNAMIC_OF_NODES))
+ return;
+
rc = pci_register_driver(&testdrv_driver);
unittest(!rc, "Failed to register pci test driver; rc = %d\n", rc);
if (rc)
@@ -3987,7 +3982,10 @@ static void __init of_unittest_pci_node(void)
pci_dev_put(pdev);
}
#else
-static void __init of_unittest_pci_node(void) { }
+
+static inline __init void of_unittest_overlay_high_level(void) {}
+static inline __init void of_unittest_pci_node(void) { }
+
#endif
static int __init of_unittest(void)
--
2.40.1
next reply other threads:[~2023-08-24 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 22:17 Rob Herring [this message]
2023-08-25 18:55 ` [PATCH] of: unittest: Fix of_unittest_pci_node() kconfig dependencies Randy Dunlap
2023-08-28 14:26 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230824221743.1581707-1-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.hou@amd.com \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).