devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ninad Malwade <nmalwade@nvidia.com>
To: <jdelvare@suse.com>, <linux@roeck-us.net>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
	<linux-hwmon@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-tegra@vger.kernel.org>
Cc: Ninad Malwade <nmalwade@nvidia.com>
Subject: [PATCH V2 2/4] dt-bindings: hwmon: ina3221: Add summation-bypass
Date: Sat, 26 Aug 2023 00:42:47 +0800	[thread overview]
Message-ID: <20230825164249.22860-3-nmalwade@nvidia.com> (raw)
In-Reply-To: <20230825164249.22860-1-nmalwade@nvidia.com>

The INA3221 has a critical alert pin that can be controlled by the
summation control function. This function adds the single
shunt-voltage conversions for the desired channels in order to
compare the combined sum to the programmed limit. The Shunt-Voltage
Sum Limit register contains the programmed value that is compared
to the value in the Shunt-Voltage Sum register in order to
determine if the total summed limit is exceeded. If the
shunt-voltage sum limit value is exceeded, the critical alert pin
pulls low.

For the summation limit to have a meaningful value, it is necessary
to use the same shunt-resistor value on all included channels. Add a
new property, 'summation-bypass', to allow specific channels to be
excluded from the summation control function if the shunt resistor
is different to other channels.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Ninad Malwade <nmalwade@nvidia.com>
---
 .../devicetree/bindings/hwmon/ti,ina3221.yaml  | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml
index 0c6d41423d8c..20c23febf575 100644
--- a/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml
+++ b/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml
@@ -55,6 +55,24 @@ patternProperties:
       shunt-resistor-micro-ohms:
         description: shunt resistor value in micro-Ohm
 
+      summation-bypass:
+        description: |
+          The INA3221 has a critical alert pin that can be controlled by the
+          summation control function. This function adds the single
+          shunt-voltage conversions for the desired channels in order to
+          compare the combined sum to the programmed limit. The Shunt-Voltage
+          Sum Limit register contains the programmed value that is compared
+          to the value in the Shunt-Voltage Sum register in order to
+          determine if the total summed limit is exceeded. If the
+          shunt-voltage sum limit value is exceeded, the critical alert pin
+          pulls low.
+
+          For the summation limit to have a meaningful value, it is necessary
+          to use the same shunt-resistor value on all included channels. If
+          this is not the case for specific channels, then the
+          'summation-bypass' can be populated for a specific channel to
+          exclude from the summation control function.
+
     additionalProperties: false
 
     required:
-- 
2.17.1


  parent reply	other threads:[~2023-08-25 16:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25 16:42 [PATCH V2 0/4] hwmon: ina3221: Add selective summation support Ninad Malwade
2023-08-25 16:42 ` [PATCH V2 1/4] dt-bindings: hwmon: ina3221: Convert to json-schema Ninad Malwade
2023-08-26  8:53   ` Krzysztof Kozlowski
2023-08-29 12:46     ` Jon Hunter
2023-08-29 17:16       ` Krzysztof Kozlowski
2023-09-01 16:34     ` Jon Hunter
2023-09-01 16:44       ` Guenter Roeck
2023-09-05 12:21         ` Jon Hunter
2023-08-25 16:42 ` Ninad Malwade [this message]
2023-08-26  8:56   ` [PATCH V2 2/4] dt-bindings: hwmon: ina3221: Add summation-bypass Krzysztof Kozlowski
2023-08-29 12:48     ` Jon Hunter
2023-08-29 17:19       ` Krzysztof Kozlowski
2023-08-25 16:42 ` [PATCH V2 3/4] hwmon: ina3221: add support for summation channel control Ninad Malwade
2023-08-25 21:08   ` kernel test robot
2023-08-29 13:27   ` Guenter Roeck
2023-08-25 16:42 ` [PATCH V2 4/4] arm64: tegra: Populate ina3221 for Tegra234 boards Ninad Malwade
2023-08-25 17:11 ` [PATCH V2 0/4] hwmon: ina3221: Add selective summation support Guenter Roeck
2023-08-29 12:52   ` Jon Hunter
2023-08-29 13:02     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230825164249.22860-3-nmalwade@nvidia.com \
    --to=nmalwade@nvidia.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=jonathanh@nvidia.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).