* [PATCH] dt-bindings: PCI: qcom: fix SDX65 compatible
@ 2023-08-27 8:53 Krzysztof Kozlowski
2023-08-27 12:10 ` Conor Dooley
2023-08-27 16:52 ` Krzysztof Wilczyński
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-08-27 8:53 UTC (permalink / raw)
To: Manivannan Sadhasivam, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Bjorn Helgaas, Lorenzo Pieralisi, Krzysztof Wilczyński,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Rohit Agarwal,
linux-pci, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski, stable
Commit c0aba9f32801 ("dt-bindings: PCI: qcom: Add SDX65 SoC") adding
SDX65 was not ever tested and is clearly bogus. The qcom,sdx65-pcie-ep
compatible is followed by fallback in DTS and there is no driver
matching by this compatible. Driver matches by its fallback
qcom,sdx55-pcie-ep. This fixes also dtbs_check warnings like:
qcom-sdx65-mtp.dtb: pcie-ep@1c00000: compatible: ['qcom,sdx65-pcie-ep', 'qcom,sdx55-pcie-ep'] is too long
Fixes: c0aba9f32801 ("dt-bindings: PCI: qcom: Add SDX65 SoC")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/pci/qcom,pcie-ep.yaml | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
index 811112255d7d..c94b49498f69 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
@@ -11,10 +11,13 @@ maintainers:
properties:
compatible:
- enum:
- - qcom,sdx55-pcie-ep
- - qcom,sdx65-pcie-ep
- - qcom,sm8450-pcie-ep
+ oneOf:
+ - enum:
+ - qcom,sdx55-pcie-ep
+ - qcom,sm8450-pcie-ep
+ - items:
+ - const: qcom,sdx65-pcie-ep
+ - const: qcom,sdx55-pcie-ep
reg:
items:
@@ -110,7 +113,6 @@ allOf:
contains:
enum:
- qcom,sdx55-pcie-ep
- - qcom,sdx65-pcie-ep
then:
properties:
clocks:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: PCI: qcom: fix SDX65 compatible
2023-08-27 8:53 [PATCH] dt-bindings: PCI: qcom: fix SDX65 compatible Krzysztof Kozlowski
@ 2023-08-27 12:10 ` Conor Dooley
2023-08-27 16:52 ` Krzysztof Wilczyński
1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2023-08-27 12:10 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Manivannan Sadhasivam, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Bjorn Helgaas, Lorenzo Pieralisi, Krzysztof Wilczyński,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Rohit Agarwal,
linux-pci, linux-arm-msm, devicetree, linux-kernel, stable
[-- Attachment #1: Type: text/plain, Size: 1871 bytes --]
On Sun, Aug 27, 2023 at 10:53:51AM +0200, Krzysztof Kozlowski wrote:
> Commit c0aba9f32801 ("dt-bindings: PCI: qcom: Add SDX65 SoC") adding
> SDX65 was not ever tested and is clearly bogus. The qcom,sdx65-pcie-ep
> compatible is followed by fallback in DTS and there is no driver
> matching by this compatible. Driver matches by its fallback
> qcom,sdx55-pcie-ep. This fixes also dtbs_check warnings like:
>
> qcom-sdx65-mtp.dtb: pcie-ep@1c00000: compatible: ['qcom,sdx65-pcie-ep', 'qcom,sdx55-pcie-ep'] is too long
>
> Fixes: c0aba9f32801 ("dt-bindings: PCI: qcom: Add SDX65 SoC")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
> ---
> .../devicetree/bindings/pci/qcom,pcie-ep.yaml | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> index 811112255d7d..c94b49498f69 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> @@ -11,10 +11,13 @@ maintainers:
>
> properties:
> compatible:
> - enum:
> - - qcom,sdx55-pcie-ep
> - - qcom,sdx65-pcie-ep
> - - qcom,sm8450-pcie-ep
> + oneOf:
> + - enum:
> + - qcom,sdx55-pcie-ep
> + - qcom,sm8450-pcie-ep
> + - items:
> + - const: qcom,sdx65-pcie-ep
> + - const: qcom,sdx55-pcie-ep
>
> reg:
> items:
> @@ -110,7 +113,6 @@ allOf:
> contains:
> enum:
> - qcom,sdx55-pcie-ep
> - - qcom,sdx65-pcie-ep
> then:
> properties:
> clocks:
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: PCI: qcom: fix SDX65 compatible
2023-08-27 8:53 [PATCH] dt-bindings: PCI: qcom: fix SDX65 compatible Krzysztof Kozlowski
2023-08-27 12:10 ` Conor Dooley
@ 2023-08-27 16:52 ` Krzysztof Wilczyński
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Wilczyński @ 2023-08-27 16:52 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Manivannan Sadhasivam, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Bjorn Helgaas, Lorenzo Pieralisi, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Rohit Agarwal, linux-pci,
linux-arm-msm, devicetree, linux-kernel, stable
Hello,
> Commit c0aba9f32801 ("dt-bindings: PCI: qcom: Add SDX65 SoC") adding
> SDX65 was not ever tested and is clearly bogus. The qcom,sdx65-pcie-ep
> compatible is followed by fallback in DTS and there is no driver
> matching by this compatible. Driver matches by its fallback
> qcom,sdx55-pcie-ep. This fixes also dtbs_check warnings like:
>
> qcom-sdx65-mtp.dtb: pcie-ep@1c00000: compatible: ['qcom,sdx65-pcie-ep', 'qcom,sdx55-pcie-ep'] is too long
Applied to controller/qcom, thank you!
[1/1] dt-bindings: PCI: qcom: Fix SDX65 compatible
https://git.kernel.org/pci/pci/c/15d63a897f79
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-27 16:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-27 8:53 [PATCH] dt-bindings: PCI: qcom: fix SDX65 compatible Krzysztof Kozlowski
2023-08-27 12:10 ` Conor Dooley
2023-08-27 16:52 ` Krzysztof Wilczyński
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).