From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7536C83F13 for ; Sun, 27 Aug 2023 18:27:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230014AbjH0S1F (ORCPT ); Sun, 27 Aug 2023 14:27:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230178AbjH0S0s (ORCPT ); Sun, 27 Aug 2023 14:26:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9D47123; Sun, 27 Aug 2023 11:26:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 40C5661D77; Sun, 27 Aug 2023 18:26:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FDFDC433C9; Sun, 27 Aug 2023 18:26:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693160805; bh=JuAYU9hIhM7oTRmtD69g4zVEgqOo78rbGFmt5nednD4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=m+7PteK8xvmnBKMpq3vdpSLqOJN3Tu5Bq+g8//WwTxpuSiyS31fjgIAvKpThdwPgV EyS7OC8yRmcaS566jUN4AM0aY781y9CWcU5f2fyBlTvzF/rwnya8xxcBNJpAHS3xt5 rAdnf2yRr1VHeXjSLRn/7vo7HBvDeAT6TwzG2CLFJXW7PXHVkWkyKWg2+hX6fCXD12 hK0icbpyU8dxFUJ3bIUwdfX91iBvr/eTz5giufb2lesXysRvcAZy79eDa8CJITkz54 FbCsYryelQI5rrpHoK2ejsqh0RWKqXAKdHahLjXsp2QCkipYbTpFa2cR7ysSuAevrE kkeCiw1UjgGKQ== Date: Sun, 27 Aug 2023 19:27:01 +0100 From: Jonathan Cameron To: Marcus Folkesson Cc: Kent Gustavsson , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Shevchenko , Cosmin Tanislav , Arnd Bergmann , ChiYuan Huang , Haibo Chen , Ramona Bolboaca , Ibrahim Tilki , ChiaEn Wu , William Breathitt Gray , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 0/6] Add support for the whole MCP39xx family Message-ID: <20230827192701.30bfd1be@jic23-huawei> In-Reply-To: <20230822192259.1125792-1-marcus.folkesson@gmail.com> References: <20230822192259.1125792-1-marcus.folkesson@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 22 Aug 2023 21:22:53 +0200 Marcus Folkesson wrote: > The main goal with this patchset is to add support for all similar > MCP39xx ADC chips. > During all patch iterations we ended up with a few cleanup patches. > > See version notes in each patch. > > Marcus Folkesson (6): > dt-bindings: iio: adc: mcp3911: add support for the whole MCP39xx > family > iio: adc: mcp3911: make use of dev_err_probe() > iio: adc: mcp3911: simplify usage of spi->dev > iio: adc: mcp3911: fix indentation > iio: adc: mcp3911: avoid ambiguity parameters in macros > iio: adc: mcp3911: add support for the whole MCP39xx family > > .../bindings/iio/adc/microchip,mcp3911.yaml | 6 + > drivers/iio/adc/Kconfig | 6 +- > drivers/iio/adc/mcp3911.c | 562 ++++++++++++++---- > 3 files changed, 462 insertions(+), 112 deletions(-) > > > base-commit: b320441c04c9bea76cbee1196ae55c20288fd7a6 Series applied. Thanks to both Marcus (for working through the iterations) and Andy for providing the detailed feedback. Jonathan