From: Conor Dooley <conor@kernel.org>
To: Binbin Zhou <zhoubinbin@loongson.cn>
Cc: Binbin Zhou <zhoubb.aaron@gmail.com>,
Huacai Chen <chenhuacai@loongson.cn>,
Yinbo Zhu <zhuyinbo@loongson.cn>, Arnd Bergmann <arnd@arndb.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
loongson-kernel@lists.loongnix.cn, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org, Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev
Subject: Re: [PATCH 3/5] soc: loongson: loongson_pm2: Add missing compatible for Loongson-2K2000
Date: Mon, 28 Aug 2023 16:32:32 +0100 [thread overview]
Message-ID: <20230828-compactor-contour-3a9f4991360f@spud> (raw)
In-Reply-To: <8468bdbea87003dc05bd10d15b51e6d27f306a20.1693218539.git.zhoubinbin@loongson.cn>
[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]
On Mon, Aug 28, 2023 at 08:38:33PM +0800, Binbin Zhou wrote:
> Add compatible for Loongson-2K2000, which also has the Loongson2
> Power Management Unit system controller.
>
> This is a missing compatible, now we add it.
>
> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> ---
> drivers/soc/loongson/loongson2_pm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/loongson/loongson2_pm.c b/drivers/soc/loongson/loongson2_pm.c
> index 796add6e8b63..6d2b3708e947 100644
> --- a/drivers/soc/loongson/loongson2_pm.c
> +++ b/drivers/soc/loongson/loongson2_pm.c
> @@ -198,6 +198,7 @@ static int loongson2_pm_probe(struct platform_device *pdev)
> static const struct of_device_id loongson2_pm_match[] = {
> { .compatible = "loongson,ls2k0500-pmc", },
> { .compatible = "loongson,ls2k1000-pmc", },
> + { .compatible = "loongson,ls2k2000-pmc", },
You've not added any new codepaths for this soc, so it is compatible
with the existing ones. Why are you not using fallback compatibles for
this?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-08-28 15:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 12:38 [PATCH 0/5] soc: loongson: Fix some issues about loongson_pm2 Binbin Zhou
2023-08-28 12:38 ` [PATCH 1/5] soc: loongson: loongson_pm2: add dependency for INPUT Binbin Zhou
2023-08-28 17:25 ` Krzysztof Kozlowski
2023-08-28 20:50 ` Randy Dunlap
2023-08-28 12:38 ` [PATCH 2/5] dt-bindings: soc: loongson,ls2k-pmc: Add missing compatible for Loongson-2K2000 Binbin Zhou
2023-08-28 15:49 ` Conor Dooley
2023-08-29 3:21 ` Binbin Zhou
2023-08-29 6:29 ` Krzysztof Kozlowski
2023-08-29 6:42 ` Conor Dooley
2023-08-29 6:52 ` Binbin Zhou
2023-08-31 16:39 ` Rob Herring
2023-08-28 12:38 ` [PATCH 3/5] soc: loongson: loongson_pm2: " Binbin Zhou
2023-08-28 15:32 ` Conor Dooley [this message]
2023-08-29 6:28 ` Krzysztof Kozlowski
2023-08-28 12:38 ` [PATCH 4/5] dt-bindings: soc: loongson,ls2k-pmc: Allow syscon-reboot/syscon-poweroff as child Binbin Zhou
2023-08-28 17:17 ` Krzysztof Kozlowski
2023-08-29 2:15 ` Binbin Zhou
2023-08-28 12:39 ` [PATCH 5/5] soc: loongson: loongson_pm2: Populate children syscon nodes Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230828-compactor-contour-3a9f4991360f@spud \
--to=conor@kernel.org \
--cc=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=robh+dt@kernel.org \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).