From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBA79C83F1C for ; Mon, 28 Aug 2023 10:35:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231467AbjH1Kea (ORCPT ); Mon, 28 Aug 2023 06:34:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231516AbjH1KeB (ORCPT ); Mon, 28 Aug 2023 06:34:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4FA9CFA; Mon, 28 Aug 2023 03:33:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B44C263DB4; Mon, 28 Aug 2023 10:33:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7914C433C7; Mon, 28 Aug 2023 10:33:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693218820; bh=tG5mfpmkIPqN8OZym996RruD3Ro6btaiwud1g/6/6xY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Crj7FBehCfST9kZRvUkQQE7rp2MoPZOaZ4eOwrUBNDD13LYwAOAGXuHuylBpRfKlc /qSjoYVemGZvuYizN347tJmllNdNWsxRrdIlWNs33Ey6+b/OaGJjDDqJwSAFBivtIS K1J4O52OoqCCV7WLC0Yv3lUJBhrbsN1j047nmGp+tEA4EqAmJ9OZDyAyqvbBfP9CS7 CLLIubcji5QLIwnnzyhmHtsOfIcCS+yn8Yj/XcO6INyXtIcFJkmPnO0dJtiiujE/An JwRsZs2hQF/x8Mq6vDMuQha9iHkYleJP5ZATf897YEBHhbMDbf6Hday4azCKUrY6KW 6PnQ8SLbgX10A== Date: Mon, 28 Aug 2023 11:33:58 +0100 From: Jonathan Cameron To: Krzysztof Kozlowski Cc: Andreas Kemnade , lars@metafoo.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v2] dt-bindings: iio: adc: Add TI TWL603X GPADC Message-ID: <20230828113358.3cf6f994@jic23-huawei> In-Reply-To: <84388311-c92c-812e-53bd-35daf8821a16@linaro.org> References: <20230820123229.530371-1-andreas@kemnade.info> <84388311-c92c-812e-53bd-35daf8821a16@linaro.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, 20 Aug 2023 22:34:33 +0200 Krzysztof Kozlowski wrote: > On 20/08/2023 14:32, Andreas Kemnade wrote: > > Document TI TWL603X GPADC devicetree bindings. > > A driver is already there, the compatibles are used, but not documented. > > > > Signed-off-by: Andreas Kemnade > > --- > > Please provide changelog after ---. > > > > .../bindings/iio/adc/ti,twl6030-gpadc.yaml | 45 +++++++++++++++++++ > > 1 file changed, 45 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,twl6030-gpadc.yaml > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,twl6030-gpadc.yaml b/Documentation/devicetree/bindings/iio/adc/ti,twl6030-gpadc.yaml > > new file mode 100644 > > index 000000000000..5b075237bcfd > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/adc/ti,twl6030-gpadc.yaml > > @@ -0,0 +1,45 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/adc/ti,twl6030-gpadc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: GPADC subsystem in the TWL6030 power module > > + > > +maintainers: > > + - Andreas Kemnade > > + > > +description: > > + The GPADC subsystem in the TWL603X consists of a 10-bit ADC > > + combined with a 15-input analog multiplexer in the TWL6030 resp. a > > + 19-input analog muliplexer in the TWL6032. > > + > > +properties: > > + compatible: > > + enum: > > + - ti,twl6030-gpadc > > + - ti,twl6032-gpadc > > + > > + interrupts: > > + maxItems: 1 > > + > > + "#io-channel-cells": > > + const: 1 > > + > > +required: > > + - compatible > > + - interrupts > > + - "#io-channel-cells" > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + twl { > > Just skip the twl node. Anyway, the parent device binding should include > complete example. I tidied that up whilst applying. > > > Reviewed-by: Krzysztof Kozlowski Applied to the togreg branch of iio.git and pushed out as testing for 0-day to poke at it. I'll be rebasing once rc1 is out so until then I won't push this out as a branch linux-next will pick up. Thanks, Jonathan > > Best regards, > Krzysztof >