From: Andreas Kemnade <andreas@kemnade.info>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
bcousson@baylibre.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, mturquette@baylibre.com,
robh+dt@kernel.org, tony@atomide.com
Subject: Re: [PATCH 2/3] clk: twl: add clock driver for TWL6032
Date: Mon, 28 Aug 2023 18:24:12 +0200 [thread overview]
Message-ID: <20230828182412.16d4aea6@aktux> (raw)
In-Reply-To: <9edcfc47-ed89-8074-6bde-d747ae73de25@linaro.org>
Hi,
On Thu, 24 Aug 2023 09:04:28 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> >>> +
> >>> +MODULE_DESCRIPTION("Clock driver for TWL Series Devices");
> >>> +MODULE_ALIAS("platform:twl-clk");
> >>
> >> This alias is unnecessary?
> >>
> > The question is whether this driver should have a separate dt
> > node (and if a separate node, then one per clock as the clk-palmas
> > driver) or not. See Rob's review of the binding document.
> > So we have basically #clock-cells = <1>; in the twl parent
> > and a call to mfd_add_device() there in the former case and I guess
> > that alias is needed then.
> >
>
> You should not need the alias in any of these cases. platform alias for
> platform driver means you have incomplete tables and use alias instead
> of tables. Preference is to use tables.
Is there a general consensus that MODULE_ALIAS("platform:.*") should be
exorcised? Of course for this new driver I will avoid it now anyways.
Regards,
Andreas
next prev parent reply other threads:[~2023-08-28 16:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 13:41 [PATCH 0/3] ARM: omap: omap4-embt2ws: 32K clock for WLAN Andreas Kemnade
2023-08-19 13:41 ` [PATCH 1/3] dt-bindings: clock: add TWL6032 32K clocks Andreas Kemnade
2023-08-21 20:57 ` Rob Herring
2023-08-23 15:38 ` Andreas Kemnade
2023-08-24 7:09 ` Krzysztof Kozlowski
2023-08-19 13:41 ` [PATCH 2/3] clk: twl: add clock driver for TWL6032 Andreas Kemnade
2023-08-22 22:34 ` Stephen Boyd
2023-08-23 14:51 ` Andreas Kemnade
2023-08-24 7:04 ` Krzysztof Kozlowski
2023-08-28 16:24 ` Andreas Kemnade [this message]
2023-08-28 17:04 ` Krzysztof Kozlowski
2023-08-19 13:41 ` [PATCH 3/3] ARM: dts: omap4-embt2ws: enable 32K clock on WLAN Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230828182412.16d4aea6@aktux \
--to=andreas@kemnade.info \
--cc=bcousson@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).