From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Om Prakash Singh <quic_omprsing@quicinc.com>
Subject: Re: [PATCH v3 4/6] dt-bindings: crypto: qcom,prng: document SM8550
Date: Tue, 29 Aug 2023 11:22:33 -0500 [thread overview]
Message-ID: <20230829162233.GA2283052-robh@kernel.org> (raw)
In-Reply-To: <c741c4be-50b4-0bd8-79eb-37895342f5af@linaro.org>
On Tue, Aug 29, 2023 at 08:38:48AM +0200, Krzysztof Kozlowski wrote:
> On 28/08/2023 23:36, Rob Herring wrote:
> > On Mon, Aug 28, 2023 at 10:04:39AM +0200, Neil Armstrong wrote:
> >> Document SM8550 compatible for the True Random Number Generator.
> >>
> >> Reviewed-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> >
> > Where's Krzysztof's tag?
> >
>
> The patch evolved and Neil mentioned in cover letter changelog that he
> did not collect Reviews because of that. Seems ok for me.
I did go look there and just saw 'Added review tags'. Not too helpful.
That's why changelogs for a patch belong in the patch.
Rob
next prev parent reply other threads:[~2023-08-29 16:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 8:04 [PATCH v3 0/6] arm64: qcom: sm8550: enable RNG Neil Armstrong
2023-08-28 8:04 ` [PATCH v3 1/6] Revert "arm64: dts: qcom: sm8450: Add PRNG" Neil Armstrong
2023-08-28 8:04 ` [PATCH v3 2/6] dt-bindings: crypto: qcom,prng: document that RNG on SM8450 is a TRNG Neil Armstrong
2023-08-29 6:37 ` Krzysztof Kozlowski
2023-08-28 8:04 ` [PATCH v3 3/6] crypto: qcom-rng - Add support for trng Neil Armstrong
2023-08-28 8:04 ` [PATCH v3 4/6] dt-bindings: crypto: qcom,prng: document SM8550 Neil Armstrong
2023-08-28 21:36 ` Rob Herring
2023-08-29 6:38 ` Krzysztof Kozlowski
2023-08-29 16:22 ` Rob Herring [this message]
2023-08-28 8:04 ` [PATCH v3 5/6] arm64: dts: qcom: sm8550: add TRNG node Neil Armstrong
2023-08-28 8:04 ` [PATCH v3 6/6] arm64: dts: qcom: sm8450: " Neil Armstrong
2023-09-20 17:14 ` (subset) [PATCH v3 0/6] arm64: qcom: sm8550: enable RNG Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230829162233.GA2283052-robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_omprsing@quicinc.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).