From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D80F9C83F23 for ; Wed, 30 Aug 2023 18:31:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236434AbjH3Sbs (ORCPT ); Wed, 30 Aug 2023 14:31:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242454AbjH3Ifc (ORCPT ); Wed, 30 Aug 2023 04:35:32 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D23F1AE; Wed, 30 Aug 2023 01:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1693384528; x=1724920528; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=1rr15Edf/mJdMl4aJdngCeF31+Nb5/f0kCNlVbqGRGc=; b=rVXoFatN+nhu2iJqnRLaeWPV1cdY4pd3cpuiBepSIiEf+WiXpDi7ouzN ztv1MilIMdiPV/qkq0FPxUFAmb5/vAtRHvulLCzDv4oMnnzLYuv9v6QmB OH/dIh/tgLNWycgy7uzxt7ZV1GiQ38euBzN4cIwyTdANaMq1DPkOr9wTi pyjDGVUJsh6Wq5Ec+HgY1mOPN/YaQjQw/M2wE3EpZe0GvEp3XO921L9LD VZurzOwAlo3EJPVF/IyQsRJLeRVaTS7Pgcwez6NVH7Ud8naJjqAtfrYoc rFjOCbiaMx1VFyWDsNUe5omuqJLdYdFmldvk/0/ehO8dGhYCg9pPcgyif A==; X-IronPort-AV: E=Sophos;i="6.02,213,1688454000"; d="asc'?scan'208";a="169026622" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 30 Aug 2023 01:35:25 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 30 Aug 2023 01:34:51 -0700 Received: from wendy (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 30 Aug 2023 01:34:48 -0700 Date: Wed, 30 Aug 2023 09:34:06 +0100 From: Conor Dooley To: Krzysztof Kozlowski CC: William Qiu , , , , , Emil Renner Berthing , Rob Herring , Jaehoon Chung , Ulf Hansson , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou Subject: Re: [PATCH v1 1/3] dt-bindings: mmc: Drop unused properties Message-ID: <20230830-procedure-frostbite-56c751f7c276@wendy> References: <20230830031846.127957-1-william.qiu@starfivetech.com> <20230830031846.127957-2-william.qiu@starfivetech.com> <20230830-commence-trickery-40eaa193cb15@wendy> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h1favm8wo5hVWnmt" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --h1favm8wo5hVWnmt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 30, 2023 at 09:29:20AM +0200, Krzysztof Kozlowski wrote: > On 30/08/2023 08:50, Conor Dooley wrote: > > On Wed, Aug 30, 2023 at 11:18:44AM +0800, William Qiu wrote: > >> Due to the change of tuning implementation, it's no longer necessary to > >> use the "starfive,sysreg" property in dts, so drop the relevant > >> description in dt-bindings here. > >=20 > > How does changing your software implantation invalidate a description of > > the hardware? > >=20 >=20 > Which is kind of proof that this syscon was just to substitute > incomplete hardware description (e.g. missing clocks and phys). We > should have rejected it. Just like we should reject them in the future. :s I dunno what to do with this... I'm inclined to say not to remove it =66rom the binding or dts at all & only change the software. > There are just few cases where syscon is reasonable. All others is just > laziness. It's not only starfivetech, of course. Several other > contributors do the same. I'm not sure if laziness is fair, lack of understanding is usually more likely. --h1favm8wo5hVWnmt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZO7++gAKCRB4tDGHoIJi 0u4KAP0Vf98t3HptgWUDxzyfGqUIFcjfe/j2Dbq8eR0D637TbAEA0mpYQNoVYT5e 3uimUjgIT7U4Gkf664SMkKGV+ED1Zgs= =cvPO -----END PGP SIGNATURE----- --h1favm8wo5hVWnmt--