devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: <agross@kernel.org>, <andersson@kernel.org>,
	<konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<catalin.marinas@arm.com>, <will@kernel.org>, <vkoul@kernel.org>,
	<kishon@kernel.org>, <arnd@arndb.de>, <geert+renesas@glider.be>,
	<nfraprado@collabora.com>, <rafal@milecki.pl>, <peng.fan@nxp.com>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-phy@lists.infradead.org>
Subject: Re: [PATCH v11 2/4] arm64: dts: qcom: ipq5332: Add USB related nodes
Date: Thu, 31 Aug 2023 14:50:44 +0530	[thread overview]
Message-ID: <20230831092043.GA29822@varda-linux.qualcomm.com> (raw)
In-Reply-To: <CAA8EJpqRfgh5Ss696Vi=jAR-yFmBhCrpveD8txHGHoc8gRsJxQ@mail.gmail.com>

> > +               usb: usb@8af8800 {
> > +                       compatible = "qcom,ipq5332-dwc3", "qcom,dwc3";
> > +                       reg = <0x08af8800 0x400>;
> > +
> > +                       interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
> > +                       interrupt-names = "hs_phy_irq";
> > +
> > +                       clocks = <&gcc GCC_USB0_MASTER_CLK>,
> > +                                <&gcc GCC_SNOC_USB_CLK>,
> > +                                <&gcc GCC_USB0_SLEEP_CLK>,
> > +                                <&gcc GCC_USB0_MOCK_UTMI_CLK>;
> > +                       clock-names = "core",
> > +                                     "iface",
> > +                                     "sleep",
> > +                                     "mock_utmi";
> > +
> > +                       resets = <&gcc GCC_USB_BCR>;
> > +
> > +                       qcom,select-utmi-as-pipe-clk;
> > +
> > +                       #address-cells = <1>;
> > +                       #size-cells = <1>;
> > +                       ranges;
> > +
> > +                       status = "disabled";
> > +
> > +                       usb2_0_dwc: usb@8a00000 {
>
> Since we have just seen a patch series adding USB 3 support to
> ipq5332, we know that the host is not 2.0-only. Thus the `2_0` part of
> the label doesn't make sense.
>
> Could you please change the label to be just usb_dwc (or usb0_dwc)?

Have posted v12 addressing this. Please take a look.

Thanks
Varada

  reply	other threads:[~2023-08-31  9:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-31  5:37 [PATCH v11 0/4] Enable IPQ5332 USB2 Varadarajan Narayanan
2023-08-31  5:37 ` [PATCH v11 1/4] phy: qcom: m31: Fix indentation issues Varadarajan Narayanan
2023-08-31  5:37 ` [PATCH v11 2/4] arm64: dts: qcom: ipq5332: Add USB related nodes Varadarajan Narayanan
2023-08-31  6:07   ` Dmitry Baryshkov
2023-08-31  9:20     ` Varadarajan Narayanan [this message]
2023-08-31  5:37 ` [PATCH v11 3/4] arm64: dts: qcom: ipq5332: Enable USB Varadarajan Narayanan
2023-08-31  6:09   ` Dmitry Baryshkov
2023-08-31  5:37 ` [PATCH v11 4/4] arm64: defconfig: Enable M31 USB phy driver Varadarajan Narayanan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230831092043.GA29822@varda-linux.qualcomm.com \
    --to=quic_varada@quicinc.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=geert+renesas@glider.be \
    --cc=kishon@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=nfraprado@collabora.com \
    --cc=peng.fan@nxp.com \
    --cc=rafal@milecki.pl \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).