[PATCH 0/2] FEMTOPHY REFGEN regulator

[PATCH 0/2] FEMTOPHY REFGEN regulator

[Konrad Dybcio]

The FEMTOPHY gets a reference voltage from the REFGEN regulator.
Make Linux aware of that.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Konrad Dybcio (2):
      dt-bindings: phy: qcom,usb-snps-femto-v2: Add REFGEN regulator
      phy: qcom-snps-femto-v2: Add REFGEN supply

 Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 3 +++
 drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c                     | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
---
base-commit: 56585460cc2ec44fc5d66924f0a116f57080f0dc
change-id: 20230830-topic-refgenphy-8c2a78bc44e7

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@linaro.org>

[PATCH 1/2] dt-bindings: phy: qcom,usb-snps-femto-v2: Add REFGEN regulator

[Konrad Dybcio]

The HSPHY is (or at least can be) one of the users of the reference
voltage generating regulator. Ensure that dependency is described
properly.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
index 0f200e3f97a9..e895b6c4ee49 100644
--- a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
@@ -53,6 +53,9 @@ properties:
     items:
       - description: PHY core reset
 
+  refgen-supply:
+    description: phandle to the REFGEN regulator node
+
   vdda-pll-supply:
     description: phandle to the regulator VDD supply node.
 

-- 
2.42.0

Re: [PATCH 1/2] dt-bindings: phy: qcom,usb-snps-femto-v2: Add REFGEN regulator

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

On Wed, Aug 30, 2023 at 11:13:51PM +0200, Konrad Dybcio wrote:
> The HSPHY is (or at least can be) one of the users of the reference
> voltage generating regulator. Ensure that dependency is described
> properly.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> index 0f200e3f97a9..e895b6c4ee49 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> @@ -53,6 +53,9 @@ properties:
>      items:
>        - description: PHY core reset
>  
> +  refgen-supply:
> +    description: phandle to the REFGEN regulator node
> +
>    vdda-pll-supply:
>      description: phandle to the regulator VDD supply node.

My OCD isn't keen on the inconsistent full stop usage but that's a
nitpick of the context, not of the patch itself.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor,

>  
> 
> -- 
> 2.42.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/2] dt-bindings: phy: qcom,usb-snps-femto-v2: Add REFGEN regulator

[Rob Herring]

On Wed, Aug 30, 2023 at 11:13:51PM +0200, Konrad Dybcio wrote:
> The HSPHY is (or at least can be) one of the users of the reference
> voltage generating regulator. Ensure that dependency is described
> properly.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> index 0f200e3f97a9..e895b6c4ee49 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> @@ -53,6 +53,9 @@ properties:
>      items:
>        - description: PHY core reset
>  
> +  refgen-supply:
> +    description: phandle to the REFGEN regulator node

Supply names are local to the device (sink name), but this seems to be 
named based on the supply source. Maybe hard to do if all internal 
stuff. What is this supplying and what's the source if not REFGEN?


> +
>    vdda-pll-supply:
>      description: phandle to the regulator VDD supply node.
>  
> 
> -- 
> 2.42.0
> 

Re: [PATCH 1/2] dt-bindings: phy: qcom,usb-snps-femto-v2: Add REFGEN regulator

[Konrad Dybcio]

On 31.08.2023 20:25, Rob Herring wrote:
> On Wed, Aug 30, 2023 at 11:13:51PM +0200, Konrad Dybcio wrote:
>> The HSPHY is (or at least can be) one of the users of the reference
>> voltage generating regulator. Ensure that dependency is described
>> properly.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>  Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
>> index 0f200e3f97a9..e895b6c4ee49 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
>> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
>> @@ -53,6 +53,9 @@ properties:
>>      items:
>>        - description: PHY core reset
>>  
>> +  refgen-supply:
>> +    description: phandle to the REFGEN regulator node
> 
> Supply names are local to the device (sink name), but this seems to be 
> named based on the supply source. Maybe hard to do if all internal 
> stuff. What is this supplying and what's the source if not REFGEN?
I don't think I have anything that would answer this question..
Though I would not at all be surprised if Qualcomm also called the
input "refgen"..

Maybe Bjorn or Dmitry would know.

Konrad

[PATCH 2/2] phy: qcom-snps-femto-v2: Add REFGEN supply

[Konrad Dybcio]

The HSPHY is (or at least can be) one of the users of the reference
voltage generating regulator.

Add it to the regulator bulk data.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c b/drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c
index eb0b0f61d98e..2bc9aeef26f9 100644
--- a/drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c
+++ b/drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c
@@ -79,7 +79,7 @@
 #define LS_FS_OUTPUT_IMPEDANCE_MASK		GENMASK(3, 0)
 
 static const char * const qcom_snps_hsphy_vreg_names[] = {
-	"vdda-pll", "vdda33", "vdda18",
+	"vdda-pll", "vdda33", "vdda18", "refgen",
 };
 
 #define SNPS_HS_NUM_VREGS		ARRAY_SIZE(qcom_snps_hsphy_vreg_names)

-- 
2.42.0