From: Conor Dooley <conor.dooley@microchip.com>
To: Binbin Zhou <zhoubb.aaron@gmail.com>
Cc: Conor Dooley <conor@kernel.org>,
Binbin Zhou <zhoubinbin@loongson.cn>,
Huacai Chen <chenhuacai@loongson.cn>,
Yinbo Zhu <zhuyinbo@loongson.cn>, Arnd Bergmann <arnd@arndb.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
<loongson-kernel@lists.loongnix.cn>, <soc@kernel.org>,
<devicetree@vger.kernel.org>, <linux-pm@vger.kernel.org>,
Xuerui Wang <kernel@xen0n.name>, <loongarch@lists.linux.dev>
Subject: Re: [PATCH v2 3/5] soc: loongson: loongson_pm2: Drop useless of_device_id compatible
Date: Fri, 1 Sep 2023 07:32:02 +0100 [thread overview]
Message-ID: <20230901-doubling-multiple-8b72b062e622@wendy> (raw)
In-Reply-To: <CAMpQs4JbUx9N4MmfM6vRsdQBHyUcU9UHGX23UewL5Matt6iXnQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2032 bytes --]
On Fri, Sep 01, 2023 at 11:05:12AM +0800, Binbin Zhou wrote:
> Hi Conor:
>
> Thanks for your reply.
>
> On Thu, Aug 31, 2023 at 11:15 PM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Thu, Aug 31, 2023 at 07:43:13PM +0800, Binbin Zhou wrote:
> > > Now, "loongson,ls2k0500-pmc" is used as fallback compatible, so the
> > > ls2k1000 compatible in the driver can be dropped directly.
> > >
> > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> > > ---
> > > drivers/soc/loongson/loongson2_pm.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/soc/loongson/loongson2_pm.c b/drivers/soc/loongson/loongson2_pm.c
> > > index 796add6e8b63..5ffb77afd9eb 100644
> > > --- a/drivers/soc/loongson/loongson2_pm.c
> > > +++ b/drivers/soc/loongson/loongson2_pm.c
> > > @@ -197,7 +197,6 @@ static int loongson2_pm_probe(struct platform_device *pdev)
> > >
> > > static const struct of_device_id loongson2_pm_match[] = {
> > > { .compatible = "loongson,ls2k0500-pmc", },
> > > - { .compatible = "loongson,ls2k1000-pmc", },
> >
> > What about older devicetrees that do not have the fallback? Aren't you
> > going to remove support for those?
>
> This driver was just merged in during the v6.6 window, and no release
> will use it until now.
Ahh, thanks for the info. Your commits 1-3 should then all have Fixes:
tags pointing to the commits tat introduced the problems, if you intend
getting these applied as fixes before v6.6 gets released.
Thanks,
Conor.
> commit 67694c076bd7 soc: loongson2_pm: add power management support
> commit 6054a676e969 soc: dt-bindings: add loongson-2 pm
>
> Of course, it was our mistake not to make better use of fallback
> compatible when submitting the driver, and we hope to fix this mistake
> soon.
> Also, this driver will only be used by the LoongArch architecture, no
> need to worry about other architectures.
>
> Thanks.
> Binbin
> >
> > > {},
> > > };
> > >
> > > --
> > > 2.39.3
> > >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-09-01 6:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 11:43 [PATCH v2 0/5] soc: loongson: Fix some issues about loongson_pm2 Binbin Zhou
2023-08-31 11:43 ` [PATCH v2 1/5] soc: loongson: loongson_pm2: Add dependency for INPUT Binbin Zhou
2023-08-31 11:43 ` [PATCH v2 2/5] dt-bindings: soc: loongson,ls2k-pmc: Use fallbacks for ls2k-pmc compatible Binbin Zhou
2023-08-31 11:43 ` [PATCH v2 3/5] soc: loongson: loongson_pm2: Drop useless of_device_id compatible Binbin Zhou
[not found] ` <20230831-ambition-refusing-08e63b345573@spud>
2023-09-01 3:05 ` Binbin Zhou
2023-09-01 6:32 ` Conor Dooley [this message]
2023-08-31 11:43 ` [PATCH v2 4/5] dt-bindings: soc: loongson,ls2k-pmc: Allow syscon-reboot/syscon-poweroff as child Binbin Zhou
2023-09-01 9:06 ` Krzysztof Kozlowski
2023-09-01 9:27 ` Binbin Zhou
2023-09-01 11:44 ` Krzysztof Kozlowski
2023-08-31 11:43 ` [PATCH v2 5/5] soc: loongson: loongson_pm2: Populate children syscon nodes Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230901-doubling-multiple-8b72b062e622@wendy \
--to=conor.dooley@microchip.com \
--cc=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).