From: Conor Dooley <conor@kernel.org>
To: William Qiu <william.qiu@starfivetech.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-mmc@vger.kernel.org,
Emil Renner Berthing <kernel@esmil.dk>,
Rob Herring <robh+dt@kernel.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Subject: Re: [PATCH v1 1/3] dt-bindings: mmc: Drop unused properties
Date: Fri, 1 Sep 2023 16:42:47 +0100 [thread overview]
Message-ID: <20230901-remold-sublease-a1ddb1fc6348@spud> (raw)
In-Reply-To: <efab6f52-4d7f-ea3c-0fc3-4e3ad03c14c7@starfivetech.com>
[-- Attachment #1: Type: text/plain, Size: 1605 bytes --]
On Fri, Sep 01, 2023 at 10:33:13AM +0800, William Qiu wrote:
>
>
> On 2023/8/30 16:34, Conor Dooley wrote:
> > On Wed, Aug 30, 2023 at 09:29:20AM +0200, Krzysztof Kozlowski wrote:
> >> On 30/08/2023 08:50, Conor Dooley wrote:
> >> > On Wed, Aug 30, 2023 at 11:18:44AM +0800, William Qiu wrote:
> >> >> Due to the change of tuning implementation, it's no longer necessary to
> >> >> use the "starfive,sysreg" property in dts, so drop the relevant
> >> >> description in dt-bindings here.
> >> >
> >> > How does changing your software implantation invalidate a description of
> >> > the hardware?
> >> >
> >>
> >> Which is kind of proof that this syscon was just to substitute
> >> incomplete hardware description (e.g. missing clocks and phys). We
> >> should have rejected it. Just like we should reject them in the future.
> >
> > :s I dunno what to do with this... I'm inclined to say not to remove it
> > from the binding or dts at all & only change the software.
> >
> >> There are just few cases where syscon is reasonable. All others is just
> >> laziness. It's not only starfivetech, of course. Several other
> >> contributors do the same.
> >
> > I'm not sure if laziness is fair, lack of understanding is usually more
> > likely.
>
> For this, I tend to keep it in binding, but remove it from required. Because
> we only modify the tuning implementation, it doesn't mean that this property
> need to be removed, it's just no longer be the required one.
Please only remove it from required if the current driver doesn't break
if the regmap is removed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-09-01 15:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 3:18 [PATCH v1 0/3] Change tuning implementation William Qiu
2023-08-30 3:18 ` [PATCH v1 1/3] dt-bindings: mmc: Drop unused properties William Qiu
2023-08-30 6:50 ` Conor Dooley
2023-08-30 7:29 ` Krzysztof Kozlowski
2023-08-30 8:34 ` Conor Dooley
2023-09-01 2:33 ` William Qiu
2023-09-01 15:42 ` Conor Dooley [this message]
2023-09-01 17:20 ` Jessica Clarke
2023-09-01 17:43 ` Conor Dooley
2023-09-01 18:39 ` Jessica Clarke
2023-09-08 10:01 ` William Qiu
2023-09-08 13:32 ` Emil Renner Berthing
2023-09-11 16:14 ` Conor Dooley
2023-09-12 2:00 ` William Qiu
2023-08-30 3:18 ` [PATCH v1 2/3] mmc: starfive: Change tuning implementation William Qiu
2023-08-30 10:28 ` Emil Renner Berthing
2023-09-01 2:40 ` William Qiu
2023-08-30 3:18 ` [PATCH v1 3/3] riscv: dts: starfive: Drop unused properties and limit frquency William Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230901-remold-sublease-a1ddb1fc6348@spud \
--to=conor@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=william.qiu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox