* [PATCH v8 0/2] Add Facebook Minerva (AST2600) BMC
@ 2023-09-05 6:22 Peter Yin
2023-09-05 6:22 ` [PATCH v8 1/2] ARM: dts: aspeed: Minerva: " Peter Yin
2023-09-05 6:22 ` [PATCH v8 2/2] dt-bindings: arm: aspeed: add Meta Minerva board Peter Yin
0 siblings, 2 replies; 6+ messages in thread
From: Peter Yin @ 2023-09-05 6:22 UTC (permalink / raw)
To: patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel,
linux-aspeed, linux-kernel
Cc: peter.yin, Peter Yin
Summary:
Correcting the arrangement order in Makefile.
+ aspeed-bmc-facebook-greatlakes.dtb \
+ aspeed-bmc-facebook-minerva.dtb \
+ aspeed-bmc-facebook-minipack.dtb \
Correcting the arrangement order in Document
+ - facebook,greatlakes-bmc
+ - facebook,minerva-bmc
+ - facebook,yosemite4-bmc
Remove redundant blank line.
1.
+ /*P4-P7 line 248-255*/
+ "","","","","","","","";
+};
2.
+
+// SOL Host Console
3.
+
+//BIOS Flash
4.
+&uart2 {
+ status = "okay";
+ pinctrl-0 = <>;
+};
Use stdout-path.
+ chosen {
+ stdout-path = &uart5;
+ };
Fix dts path.
old:arch/arm/boot/dts/
new:arch/arm/boot/dts/aspeed
*** BLURB HERE ***
Peter Yin (2):
ARM: dts: aspeed: Minerva: Add Facebook Minerva (AST2600) BMC
dt-bindings: arm: aspeed: add Meta Minerva board
.../bindings/arm/aspeed/aspeed.yaml | 1 +
arch/arm/boot/dts/aspeed/Makefile | 1 +
.../aspeed/aspeed-bmc-facebook-minerva.dts | 377 ++++++++++++++++++
3 files changed, 379 insertions(+)
create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva.dts
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v8 1/2] ARM: dts: aspeed: Minerva: Add Facebook Minerva (AST2600) BMC 2023-09-05 6:22 [PATCH v8 0/2] Add Facebook Minerva (AST2600) BMC Peter Yin @ 2023-09-05 6:22 ` Peter Yin 2023-09-06 1:57 ` kernel test robot 2023-09-05 6:22 ` [PATCH v8 2/2] dt-bindings: arm: aspeed: add Meta Minerva board Peter Yin 1 sibling, 1 reply; 6+ messages in thread From: Peter Yin @ 2023-09-05 6:22 UTC (permalink / raw) To: patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel Cc: peter.yin, Peter Yin Add linux device tree entry related to Minerva specific devices connected to BMC SoC. Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> --- arch/arm/boot/dts/aspeed/Makefile | 1 + .../aspeed/aspeed-bmc-facebook-minerva.dts | 377 ++++++++++++++++++ 2 files changed, 378 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva.dts diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile index 23cbc7203a8e..b1da302dbcd6 100644 --- a/arch/arm/boot/dts/aspeed/Makefile +++ b/arch/arm/boot/dts/aspeed/Makefile @@ -19,6 +19,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-facebook-fuji.dtb \ aspeed-bmc-facebook-galaxy100.dtb \ aspeed-bmc-facebook-greatlakes.dtb \ + aspeed-bmc-facebook-minerva.dtb \ aspeed-bmc-facebook-minipack.dtb \ aspeed-bmc-facebook-tiogapass.dtb \ aspeed-bmc-facebook-wedge40.dtb \ diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva.dts new file mode 100644 index 000000000000..0bf4e4a7a16c --- /dev/null +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva.dts @@ -0,0 +1,377 @@ +// SPDX-License-Identifier: GPL-2.0+ +// Copyright (c) 2023 Facebook Inc. +/dts-v1/; + +#include "aspeed-g6.dtsi" +#include <dt-bindings/gpio/aspeed-gpio.h> +#include <dt-bindings/i2c/i2c.h> + +/ { + model = "Facebook Minerva"; + compatible = "facebook,minerva-bmc", "aspeed,ast2600"; + + aliases { + serial0 = &uart1; + serial4 = &uart5; + }; + + chosen { + stdout-path = &uart5; + }; + + memory@80000000 { + device_type = "memory"; + reg = <0x80000000 0x80000000>; + }; + + iio-hwmon { + compatible = "iio-hwmon"; + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>, + <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>, + <&adc1 2>; + }; +}; + +// HOST BIOS Debug +&uart1 { + status = "okay"; +}; + +// SOL Host Console +&uart2 { + status = "okay"; + pinctrl-0 = <>; +}; + +// SOL BMC Console +&uart4 { + status = "okay"; + pinctrl-0 = <>; +}; + +// BMC Debug Console +&uart5 { + status = "okay"; +}; + +//MTIA +&uart6 { + status = "okay"; +}; + +&uart_routing { + status = "okay"; +}; + +&vuart1 { + status = "okay"; + virtual; + port=<0x3e8>; + sirq = <7>; + sirq-polarity = <0>; + dma-mode; + dma-channel = <12>; +}; + +&wdt1 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_wdtrst1_default>; + aspeed,reset-type = "soc"; + aspeed,external-signal; + aspeed,ext-push-pull; + aspeed,ext-active-high; + aspeed,ext-pulse-duration = <256>; +}; + +&mac3 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii4_default>; + no-hw-checksum; + use-ncsi; + ncsi-ctrl,start-redo-probe; + ncsi-ctrl,no-channel-monitor; + mlx,multi-host; + ncsi-package = <1>; + ncsi-channel = <1>; + ncsi-rexmit = <1>; + ncsi-timeout = <2>; +}; + +&rtc { + status = "okay"; +}; + +&fmc { + status = "okay"; + + flash@0 { + status = "okay"; + m25p,fast-read; + label = "bmc"; + spi-max-frequency = <50000000>; +#include "openbmc-flash-layout-128.dtsi" + }; + + flash@1 { + status = "okay"; + m25p,fast-read; + label = "alt-bmc"; + spi-max-frequency = <50000000>; + }; +}; + +//BIOS Flash +&spi2 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_spi2_default>; + + flash@0 { + status = "okay"; + m25p,fast-read; + label = "pnor"; + spi-max-frequency = <12000000>; + spi-tx-bus-width = <2>; + spi-rx-bus-width = <2>; + }; +}; + +&kcs2 { + status = "okay"; + aspeed,lpc-io-reg = <0xca8>; +}; + +&kcs3 { + status = "okay"; + aspeed,lpc-io-reg = <0xca2>; +}; + +&lpc_snoop { + status = "okay"; + snoop-ports = <0x80>; +}; + +&peci0 { + status = "okay"; + clock-frequency = <1000000>; +}; + +&i2c0 { + status = "okay"; +}; + +&i2c1 { + status = "okay"; + + tmp75@4B { + compatible = "ti,tmp75"; + reg = <0x4B>; + }; +}; + +&i2c2 { + status = "okay"; +}; + +&i2c3 { + status = "okay"; +}; + +&i2c4 { + status = "okay"; +}; + +&i2c5 { + status = "okay"; +}; + +&i2c6 { + status = "okay"; +}; + +&i2c7 { + status = "okay"; +}; + +&i2c8 { + status = "okay"; +}; + +&i2c9 { + status = "okay"; +}; + +&i2c11 { + status = "okay"; +}; + +&i2c12 { + status = "okay"; +}; + +&i2c13 { + status = "okay"; +}; + +// To Debug card +&i2c14 { + status = "okay"; + multi-master; + + ipmb@10 { + compatible = "ipmb-dev"; + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; + i2c-protocol; + }; +}; + +&i2c15 { + status = "okay"; + + // SCM FRU + eeprom@50 { + compatible = "atmel,24c64"; + reg = <0x50>; + }; + // BSM FRU + eeprom@56 { + compatible = "atmel,24c64"; + reg = <0x56>; + }; +}; + +&adc0 { + ref_voltage = <2500>; + status = "okay"; + pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default + &pinctrl_adc2_default &pinctrl_adc3_default + &pinctrl_adc4_default &pinctrl_adc5_default + &pinctrl_adc6_default &pinctrl_adc7_default>; +}; + +&adc1 { + ref_voltage = <2500>; + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_adc10_default>; +}; + +&jtag1 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_jtagm_default>; +}; + +&ehci1 { + status = "okay"; +}; + +&gpio0 { + pinctrl-names = "default"; + gpio-line-names = + /*A0-A7*/ "","","","","","","","", + /*B0-B7*/ "","","","","","FM_ID_LED_N","","", + /*C0-C7*/ "","","","","","","","", + /*D0-D7*/ "","","SOL_UART_SET","","","","","", + /*E0-E7*/ "","","","","","","","", + /*F0-F7*/ "","","","","","","","", + /*G0-G7*/ "","","","","","","","", + /*H0-H7*/ "","","","","","","","", + /*I0-I7*/ "","","","","","","","", + /*J0-J7*/ "","","","","","","","", + /*K0-K7*/ "","","","","","","","", + /*L0-L7*/ "","","","","","","","", + /*M0-M7*/ "","","","","","","","", + /*N0-N7*/ "LED_POSTCODE_0","LED_POSTCODE_1", + "LED_POSTCODE_2","LED_POSTCODE_3", + "LED_POSTCODE_4","LED_POSTCODE_5", + "LED_POSTCODE_6","LED_POSTCODE_7", + /*O0-O7*/ "","","","","","","","", + /*P0-P7*/ "FP_SYS_PWRBTN_IN_N","BMC_SYS_PWRBTN_OUT_N", + "FP_RST_BTN_IN_N","","","","","", + /*Q0-Q7*/ "","","","","","","","", + /*R0-R7*/ "","","","","","","","", + /*S0-S7*/ "","","","","","","","", + /*T0-T7*/ "","","","","","","","", + /*U0-U7*/ "","","","","","","","", + /*V0-V7*/ "","","","","","","","", + /*W0-W7*/ "","","","","","","","", + /*X0-X7*/ "","","","","","","","", + /*Y0-Y7*/ "","","","","","","","", + /*Z0-Z7*/ "","","","","","","",""; +}; + +&sgpiom0 { + status = "okay"; + max-ngpios = <128>; + ngpios = <128>; + bus-frequency = <2000000>; + gpio-line-names = + /*in - out - in - out */ + /*A0-A3 line 0-7*/ + "","","","","","ENABLE_SENSORS","","", + /*A4-A7 line 8-15*/ + "","","","","","","","", + /*B0-B3 line 16-23*/ + "","","","","","BMC_RST_BTN_OUT_N","","", + /*B4-B7 line 24-31*/ + "","","","","","","","", + /*C0-C3 line 32-39*/ + "","","","","","","","", + /*C4-C7 line 40-47*/ + "","","","","","","","", + /*D0-D3 line 48-55*/ + "","","","","","","","", + /*D4-D7 line 56-63*/ + "","","","","","","","", + /*E0-E3 line 64-71*/ + "","","","","","","","", + /*E4-E7 line 72-79*/ + "","","","","","","","", + /*F0-F3 line 80-87*/ + "","","","","","","","", + /*F4-F7 line 88-95*/ + "","","","","","","","", + /*G0-G3 line 96-103*/ + "","","","","","","","", + /*G4-G7 line 104-111*/ + "","","","","","","","", + /*H0-H3 line 112-119*/ + "","","","","PLD_SYS_POWER_GOOD","","","", + /*H4-H7 line 120-127*/ + "","","","","","","","", + /*I0-I3 line 128-135*/ + "","","","","","","","", + /*I4-I7 line 136-143*/ + "","","","","","","","", + /*J0-J3 line 144-151*/ + "","","PLD_BIOS_POST_CMPLT_N","","","","","", + /*J4-J7 line 152-159*/ + "","","","","","","","", + /*K0-K3 line 160-167*/ + "","","","","","","","", + /*K4-K7 line 168-175*/ + "","","","","","","","", + /*L0-L3 line 176-183*/ + "","","","","","","","", + /*L4-L7 line 184-191*/ + "","","","","","","","", + /*M0-M3 line 192-199*/ + "","","","","","","","", + /*M4-M7 line 200-207*/ + "","","","","","","","", + /*N0-N3 line 208-215*/ + "","","","","","","","", + /*N4-N7 line 216-223*/ + "","","","","","","","", + /*O0-O3 line 224-231*/ + "","","","","","","","", + /*O4-O7 line 232-239*/ + "","","","","","","","", + /*P0-P3 line 240-247*/ + "","","","","","","","", + /*P4-P7 line 248-255*/ + "","","","","","","",""; +}; -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v8 1/2] ARM: dts: aspeed: Minerva: Add Facebook Minerva (AST2600) BMC 2023-09-05 6:22 ` [PATCH v8 1/2] ARM: dts: aspeed: Minerva: " Peter Yin @ 2023-09-06 1:57 ` kernel test robot 0 siblings, 0 replies; 6+ messages in thread From: kernel test robot @ 2023-09-06 1:57 UTC (permalink / raw) To: Peter Yin, patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel Cc: oe-kbuild-all, peter.yin, Peter Yin Hi Peter, kernel test robot noticed the following build errors: [auto build test ERROR on next-20230905] [also build test ERROR on linus/master v6.5] [cannot apply to robh/for-next v6.5 v6.5-rc7 v6.5-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Peter-Yin/ARM-dts-aspeed-Minerva-Add-Facebook-Minerva-AST2600-BMC/20230906-005659 base: next-20230905 patch link: https://lore.kernel.org/r/20230905062223.774871-2-peteryin.openbmc%40gmail.com patch subject: [PATCH v8 1/2] ARM: dts: aspeed: Minerva: Add Facebook Minerva (AST2600) BMC config: arm-defconfig (https://download.01.org/0day-ci/archive/20230906/202309060936.2lEsdiub-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230906/202309060936.2lEsdiub-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202309060936.2lEsdiub-lkp@intel.com/ All errors (new ones prefixed by >>): >> Error: arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva.dts:261.1-7 Label or path jtag1 not found FATAL ERROR: Syntax error parsing input tree -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v8 2/2] dt-bindings: arm: aspeed: add Meta Minerva board 2023-09-05 6:22 [PATCH v8 0/2] Add Facebook Minerva (AST2600) BMC Peter Yin 2023-09-05 6:22 ` [PATCH v8 1/2] ARM: dts: aspeed: Minerva: " Peter Yin @ 2023-09-05 6:22 ` Peter Yin 2023-09-05 18:16 ` Rob Herring 1 sibling, 1 reply; 6+ messages in thread From: Peter Yin @ 2023-09-05 6:22 UTC (permalink / raw) To: patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel Cc: peter.yin, Peter Yin, Krzysztof Kozlowski Document the new compatibles used on Meta Minerva. Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index 68f717670f78..32582ee56264 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml @@ -79,6 +79,7 @@ properties: - facebook,elbert-bmc - facebook,fuji-bmc - facebook,greatlakes-bmc + - facebook,minerva-bmc - facebook,yosemite4-bmc - ibm,everest-bmc - ibm,rainier-bmc -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v8 2/2] dt-bindings: arm: aspeed: add Meta Minerva board 2023-09-05 6:22 ` [PATCH v8 2/2] dt-bindings: arm: aspeed: add Meta Minerva board Peter Yin @ 2023-09-05 18:16 ` Rob Herring 2023-09-06 2:08 ` PeterYin 0 siblings, 1 reply; 6+ messages in thread From: Rob Herring @ 2023-09-05 18:16 UTC (permalink / raw) To: Peter Yin Cc: patrick, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel, peter.yin, Krzysztof Kozlowski On Tue, Sep 05, 2023 at 02:22:22PM +0800, Peter Yin wrote: > Document the new compatibles used on Meta Minerva. > > Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> > You should not have blank lines between tags. > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > index 68f717670f78..32582ee56264 100644 > --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > @@ -79,6 +79,7 @@ properties: > - facebook,elbert-bmc > - facebook,fuji-bmc > - facebook,greatlakes-bmc > + - facebook,minerva-bmc > - facebook,yosemite4-bmc > - ibm,everest-bmc > - ibm,rainier-bmc > -- > 2.25.1 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v8 2/2] dt-bindings: arm: aspeed: add Meta Minerva board 2023-09-05 18:16 ` Rob Herring @ 2023-09-06 2:08 ` PeterYin 0 siblings, 0 replies; 6+ messages in thread From: PeterYin @ 2023-09-06 2:08 UTC (permalink / raw) To: Rob Herring Cc: patrick, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel, peter.yin, Krzysztof Kozlowski On 9/6/23 02:16, Rob Herring wrote: > On Tue, Sep 05, 2023 at 02:22:22PM +0800, Peter Yin wrote: >> Document the new compatibles used on Meta Minerva. >> >> Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> >> > You should not have blank lines between tags. > Thanks your comment, I will fix it in next version. >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> index 68f717670f78..32582ee56264 100644 >> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> @@ -79,6 +79,7 @@ properties: >> - facebook,elbert-bmc >> - facebook,fuji-bmc >> - facebook,greatlakes-bmc >> + - facebook,minerva-bmc >> - facebook,yosemite4-bmc >> - ibm,everest-bmc >> - ibm,rainier-bmc >> -- >> 2.25.1 >> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-09-06 2:10 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-09-05 6:22 [PATCH v8 0/2] Add Facebook Minerva (AST2600) BMC Peter Yin 2023-09-05 6:22 ` [PATCH v8 1/2] ARM: dts: aspeed: Minerva: " Peter Yin 2023-09-06 1:57 ` kernel test robot 2023-09-05 6:22 ` [PATCH v8 2/2] dt-bindings: arm: aspeed: add Meta Minerva board Peter Yin 2023-09-05 18:16 ` Rob Herring 2023-09-06 2:08 ` PeterYin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).