From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Greentime Hu <greentime.hu@sifive.com>,
jarkko.nikula@linux.intel.com,
William Salmon <william.salmon@sifive.com>,
Jude Onyenegecha <jude.onyenegecha@sifive.com>
Subject: Re: [PATCH v9 1/6] pwm: dwc: split pci out of core driver
Date: Thu, 7 Sep 2023 23:15:04 +0200 [thread overview]
Message-ID: <20230907211504.xfummvycltdj6bii@pengutronix.de> (raw)
In-Reply-To: <20230907161242.67190-2-ben.dooks@codethink.co.uk>
[-- Attachment #1: Type: text/plain, Size: 1795 bytes --]
Hello,
On Thu, Sep 07, 2023 at 05:12:37PM +0100, Ben Dooks wrote:
> Moving towards adding non-pci support for the driver, move the pci
> parts out of the core into their own module. This is partly due to
> the module_driver() code only being allowed once in a module and also
> to avoid a number of #ifdef if we build a single file in a system
> without pci support.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Great you continue here even though your commercial interest already
ended!
This series conflicts with my lifetime series[1], but I guess we can
sort that one when at least one of these two series is applied.
[1] https://lore.kernel.org/linux-pwm/20230808171931.944154-1-u.kleine-koenig@pengutronix.de/
> [...]
> diff --git a/drivers/pwm/pwm-dwc.c b/drivers/pwm/pwm-dwc.c
> index 3bbb26c862c3..bd9cadb497d7 100644
> --- a/drivers/pwm/pwm-dwc.c
> +++ b/drivers/pwm/pwm-dwc.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * DesignWare PWM Controller driver
> + * DesignWare PWM Controller driver (PCI part)
> *
> * Copyright (C) 2018-2020 Intel Corporation
> *
> @@ -13,6 +13,8 @@
> * periods are one or more input clock periods long.
> */
>
> +#define DEFAULT_MOUDLE_NAMESPACE dwc_pwm
> +
There is no exported symbol in this driver, so this #define is unused.
> #include <linux/bitops.h>
> #include <linux/export.h>
> #include <linux/kernel.h>
Otherwise looks fine:
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
(with or without dropping DEFAULT_MOUDLE_NAMESPACE from pwm-dwc.c)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-09-07 21:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 16:12 [PATCH v9 0/6] designware pwm driver updates Ben Dooks
2023-09-07 16:12 ` [PATCH v9 1/6] pwm: dwc: split pci out of core driver Ben Dooks
2023-09-07 21:15 ` Uwe Kleine-König [this message]
2023-09-07 16:12 ` [PATCH v9 2/6] pwm: dwc: make timer clock configurable Ben Dooks
2023-09-07 16:12 ` [PATCH v9 3/6] pwm: dwc: add PWM bit unset in get_state call Ben Dooks
2023-09-22 17:35 ` Uwe Kleine-König
2023-09-25 7:02 ` Ben Dooks
2023-09-07 16:12 ` [PATCH v9 4/6] pwm: dwc: use clock rate in hz to avoid rounding issues Ben Dooks
2023-09-07 21:34 ` Uwe Kleine-König
2023-09-11 7:33 ` Ben Dooks
2023-09-11 19:47 ` Uwe Kleine-König
2023-09-07 16:12 ` [PATCH v9 5/6] pwm: dwc: round rate divisions up Ben Dooks
2023-09-07 21:36 ` Uwe Kleine-König
2023-09-07 16:12 ` [PATCH v9 6/6] pwm: dwc: add of/platform support Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230907211504.xfummvycltdj6bii@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=ben.dooks@codethink.co.uk \
--cc=devicetree@vger.kernel.org \
--cc=greentime.hu@sifive.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jude.onyenegecha@sifive.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=william.salmon@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).