From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 291C0EE57E7 for ; Fri, 8 Sep 2023 09:32:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237572AbjIHJcp (ORCPT ); Fri, 8 Sep 2023 05:32:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234150AbjIHJcn (ORCPT ); Fri, 8 Sep 2023 05:32:43 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D9FA311B for ; Fri, 8 Sep 2023 02:32:39 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 70E84D75; Fri, 8 Sep 2023 02:33:17 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0A8733F64C; Fri, 8 Sep 2023 02:32:36 -0700 (PDT) Date: Fri, 8 Sep 2023 10:32:34 +0100 From: Andre Przywara To: Chris Morgan Cc: linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, airlied@gmail.com, conor+dt@kernel.org, daniel@ffwll.ch, heiko@sntech.de, jagan@edgeble.ai, jernej.skrabec@gmail.com, krzysztof.kozlowski+dt@linaro.org, mripard@kernel.org, neil.armstrong@linaro.org, noralf@tronnes.org, robh+dt@kernel.org, sam@ravnborg.org, samuel@sholland.org, uwu@icenowy.me, wens@csie.org, Chris Morgan , Conor Dooley Subject: Re: [PATCH V4 4/8] dt-bindings: usb: Add V3s compatible string for EHCI Message-ID: <20230908103234.6a78275c@donnerap.manchester.arm.com> In-Reply-To: <20230828181941.1609894-5-macroalpha82@gmail.com> References: <20230828181941.1609894-1-macroalpha82@gmail.com> <20230828181941.1609894-5-macroalpha82@gmail.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 28 Aug 2023 13:19:37 -0500 Chris Morgan wrote: > From: Chris Morgan > > The Allwinner V3s uses a generic EHCI and OHCI for USB host > communication and the MUSB controller for OTG mode. Add compatible > strings for the EHCI node. > > Signed-off-by: Chris Morgan > Acked-by: Conor Dooley That looks alright, but you can squash this and the next patch into one - but only in case you need to re-send anyway. Cheers, Andre > --- > Documentation/devicetree/bindings/usb/generic-ehci.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > index b956bb5fada7..f37191f21501 100644 > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > @@ -38,6 +38,7 @@ properties: > - allwinner,sun8i-a83t-ehci > - allwinner,sun8i-h3-ehci > - allwinner,sun8i-r40-ehci > + - allwinner,sun8i-v3s-ehci > - allwinner,sun9i-a80-ehci > - allwinner,sun20i-d1-ehci > - aspeed,ast2400-ehci