* [PATCH] arm64: dts: imx8dxl-ss-adma: Fix i2c compatible entries
@ 2023-09-09 16:44 Fabio Estevam
2023-09-10 9:42 ` Krzysztof Kozlowski
2023-09-25 2:04 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2023-09-09 16:44 UTC (permalink / raw)
To: shawnguo
Cc: linux-imx, devicetree, linux-arm-kernel, robh+dt,
krzysztof.kozlowski+dt, conor+dt, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
Per i2c-imx-lpi2c.yaml, the imx8dxl lpi2c compatible should be:
compatible = "fsl,imx8dxl-lpi2c", "fsl,imx7ulp-lpi2c";
Change it accordingly to fix the following schema warning:
imx8dxl-evk.dtb: i2c@5a800000: compatible: 'oneOf' conditional failed, one must be fixed:
['fsl,imx8dxl-lpi2c', 'fsl,imx8qxp-lpi2c', 'fsl,imx7ulp-lpi2c'] is too long
'fsl,imx8dxl-lpi2c' is not one of ['fsl,imx7ulp-lpi2c']
'fsl,imx7ulp-lpi2c' was expected
from schema $id: http://devicetree.org/schemas/i2c/i2c-imx-lpi2c.yaml#
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi b/arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi
index e2eeddf38aa3..a9095964ac91 100644
--- a/arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi
@@ -16,22 +16,22 @@ &adc0 {
};
&i2c0 {
- compatible = "fsl,imx8dxl-lpi2c", "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
+ compatible = "fsl,imx8dxl-lpi2c", "fsl,imx7ulp-lpi2c";
interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>;
};
&i2c1 {
- compatible = "fsl,imx8dxl-lpi2c", "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
+ compatible = "fsl,imx8dxl-lpi2c", "fsl,imx7ulp-lpi2c";
interrupts = <GIC_SPI 223 IRQ_TYPE_LEVEL_HIGH>;
};
&i2c2 {
- compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
+ compatible = "fsl,imx8dxl-lpi2c", "fsl,imx7ulp-lpi2c";
interrupts = <GIC_SPI 224 IRQ_TYPE_LEVEL_HIGH>;
};
&i2c3 {
- compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
+ compatible = "fsl,imx8dxl-lpi2c", "fsl,imx7ulp-lpi2c";
interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: imx8dxl-ss-adma: Fix i2c compatible entries
2023-09-09 16:44 [PATCH] arm64: dts: imx8dxl-ss-adma: Fix i2c compatible entries Fabio Estevam
@ 2023-09-10 9:42 ` Krzysztof Kozlowski
2023-09-25 2:04 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-10 9:42 UTC (permalink / raw)
To: Fabio Estevam, shawnguo
Cc: linux-imx, devicetree, linux-arm-kernel, robh+dt,
krzysztof.kozlowski+dt, conor+dt, Fabio Estevam
On 09/09/2023 18:44, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Per i2c-imx-lpi2c.yaml, the imx8dxl lpi2c compatible should be:
>
> compatible = "fsl,imx8dxl-lpi2c", "fsl,imx7ulp-lpi2c";
>
> Change it accordingly to fix the following schema warning:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: imx8dxl-ss-adma: Fix i2c compatible entries
2023-09-09 16:44 [PATCH] arm64: dts: imx8dxl-ss-adma: Fix i2c compatible entries Fabio Estevam
2023-09-10 9:42 ` Krzysztof Kozlowski
@ 2023-09-25 2:04 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2023-09-25 2:04 UTC (permalink / raw)
To: Fabio Estevam
Cc: linux-imx, devicetree, linux-arm-kernel, robh+dt,
krzysztof.kozlowski+dt, conor+dt, Fabio Estevam
On Sat, Sep 09, 2023 at 01:44:03PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Per i2c-imx-lpi2c.yaml, the imx8dxl lpi2c compatible should be:
>
> compatible = "fsl,imx8dxl-lpi2c", "fsl,imx7ulp-lpi2c";
>
> Change it accordingly to fix the following schema warning:
>
> imx8dxl-evk.dtb: i2c@5a800000: compatible: 'oneOf' conditional failed, one must be fixed:
> ['fsl,imx8dxl-lpi2c', 'fsl,imx8qxp-lpi2c', 'fsl,imx7ulp-lpi2c'] is too long
> 'fsl,imx8dxl-lpi2c' is not one of ['fsl,imx7ulp-lpi2c']
> 'fsl,imx7ulp-lpi2c' was expected
> from schema $id: http://devicetree.org/schemas/i2c/i2c-imx-lpi2c.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-25 2:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-09 16:44 [PATCH] arm64: dts: imx8dxl-ss-adma: Fix i2c compatible entries Fabio Estevam
2023-09-10 9:42 ` Krzysztof Kozlowski
2023-09-25 2:04 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).