* [PATCH 2/3] arm64: dts: imx8qxp-mek: Fix gpio-sbu-mux compatible
2023-09-09 20:29 [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for CBDTU02043 Fabio Estevam
@ 2023-09-09 20:29 ` Fabio Estevam
2023-09-10 10:52 ` Krzysztof Kozlowski
2023-09-09 20:29 ` [PATCH 3/3] arm64: dts: imx8qxp-mek: Pass gpio-sbu-mux mode-switch Fabio Estevam
2023-09-10 9:32 ` [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for CBDTU02043 Conor Dooley
2 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2023-09-09 20:29 UTC (permalink / raw)
To: shawnguo
Cc: andersson, linux-usb, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-imx, devicetree, linux-arm-kernel, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
Per gpio-sbu-mux.yaml, the compatible entry is incomplete.
The imx8qxp-mek board uses a CBDTU02043, so complete the gpio-sbu-mux
compatible accordingly.
This fixes the following schema warning:
imx8qxp-mek.dtb: gpio-sbu-mux: compatible:0: 'gpio-sbu-mux' is not one of ['onnn,fsusb43l10x', 'pericom,pi3usb102']
from schema $id: http://devicetree.org/schemas/usb/gpio-sbu-mux.yaml#
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
index 7924b0969ad8..a06a6491ef20 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
@@ -31,7 +31,7 @@ reg_usdhc2_vmmc: usdhc2-vmmc {
};
gpio-sbu-mux {
- compatible = "gpio-sbu-mux";
+ compatible = "nxp,cbdtu02043","gpio-sbu-mux";
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_typec_mux>;
select-gpios = <&lsio_gpio5 9 GPIO_ACTIVE_HIGH>;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] arm64: dts: imx8qxp-mek: Fix gpio-sbu-mux compatible
2023-09-09 20:29 ` [PATCH 2/3] arm64: dts: imx8qxp-mek: Fix gpio-sbu-mux compatible Fabio Estevam
@ 2023-09-10 10:52 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-10 10:52 UTC (permalink / raw)
To: Fabio Estevam, shawnguo
Cc: andersson, linux-usb, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-imx, devicetree, linux-arm-kernel, Fabio Estevam
On 09/09/2023 22:29, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Per gpio-sbu-mux.yaml, the compatible entry is incomplete.
>
> The imx8qxp-mek board uses a CBDTU02043, so complete the gpio-sbu-mux
> compatible accordingly.
>
> This fixes the following schema warning:
>
> imx8qxp-mek.dtb: gpio-sbu-mux: compatible:0: 'gpio-sbu-mux' is not one of ['onnn,fsusb43l10x', 'pericom,pi3usb102']
> from schema $id: http://devicetree.org/schemas/usb/gpio-sbu-mux.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> index 7924b0969ad8..a06a6491ef20 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> @@ -31,7 +31,7 @@ reg_usdhc2_vmmc: usdhc2-vmmc {
> };
>
> gpio-sbu-mux {
> - compatible = "gpio-sbu-mux";
> + compatible = "nxp,cbdtu02043","gpio-sbu-mux";
Missing space after ,
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 3/3] arm64: dts: imx8qxp-mek: Pass gpio-sbu-mux mode-switch
2023-09-09 20:29 [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for CBDTU02043 Fabio Estevam
2023-09-09 20:29 ` [PATCH 2/3] arm64: dts: imx8qxp-mek: Fix gpio-sbu-mux compatible Fabio Estevam
@ 2023-09-09 20:29 ` Fabio Estevam
2023-09-10 9:32 ` [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for CBDTU02043 Conor Dooley
2 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2023-09-09 20:29 UTC (permalink / raw)
To: shawnguo
Cc: andersson, linux-usb, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-imx, devicetree, linux-arm-kernel, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
Per gpio-sbu-mux.yaml, the 'mode-switch' property is mandatory.
Pass it to fix the following schema warning:
imx8qxp-mek.dtb: gpio-sbu-mux: 'mode-switch' is a required property
from schema $id: http://devicetree.org/schemas/usb/gpio-sbu-mux.yaml#
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
index a06a6491ef20..f95b58c69c6a 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
@@ -36,6 +36,7 @@ gpio-sbu-mux {
pinctrl-0 = <&pinctrl_typec_mux>;
select-gpios = <&lsio_gpio5 9 GPIO_ACTIVE_HIGH>;
enable-gpios = <&pca9557_a 7 GPIO_ACTIVE_LOW>;
+ mode-switch;
orientation-switch;
port {
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for CBDTU02043
2023-09-09 20:29 [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for CBDTU02043 Fabio Estevam
2023-09-09 20:29 ` [PATCH 2/3] arm64: dts: imx8qxp-mek: Fix gpio-sbu-mux compatible Fabio Estevam
2023-09-09 20:29 ` [PATCH 3/3] arm64: dts: imx8qxp-mek: Pass gpio-sbu-mux mode-switch Fabio Estevam
@ 2023-09-10 9:32 ` Conor Dooley
2 siblings, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2023-09-10 9:32 UTC (permalink / raw)
To: Fabio Estevam
Cc: shawnguo, andersson, linux-usb, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-imx, devicetree, linux-arm-kernel, Fabio Estevam
[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]
On Sat, Sep 09, 2023 at 05:29:55PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Add a compatible entry for the NXP CBDTU02043 GPIO-based mux hardware
> used for connecting, disconnecting and switching orientation of
> the SBU lines in USB Type-C applications.
>
> CBTU02043 datasheet: https://www.nxp.com/docs/en/data-sheet/CBTU02043.pdf
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> index f196beb826d8..b61dcf8b4aad 100644
> --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> @@ -19,6 +19,7 @@ properties:
> compatible:
> items:
> - enum:
> + - nxp,cbdtu02043
> - onnn,fsusb43l10x
> - pericom,pi3usb102
> - const: gpio-sbu-mux
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread