From: Stephan Gerhold <stephan@gerhold.net>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Stephan Gerhold <stephan@gerhold.net>
Subject: [PATCH 8/9] arm64: dts: qcom: msm8916/39: Move mpss_mem size to boards
Date: Mon, 11 Sep 2023 19:41:50 +0200 [thread overview]
Message-ID: <20230911-msm8916-rmem-v1-8-b7089ec3e3a1@gerhold.net> (raw)
In-Reply-To: <20230911-msm8916-rmem-v1-0-b7089ec3e3a1@gerhold.net>
The modem firmware size is typically highly device-specific.
The current size of the mpss_mem region in msm8916.dtsi (0x2b00000)
only works for some APQ8016 devices without full-featured modem,
such as the DragonBoard 410c.
The full modem firmware is typically about twice as large (~45 MiB
-> ~90 MiB) but also varies by a few MiB from device to device. Since
these devices are quite memory-constrained nowadays it's important to
minimize the unnecessary memory reservations.
Make it clear that each board needs to specify the necessary mpss_mem
size by replacing the DB410c-specific size in msm8916.dtsi with a
simple comment. &mpss_mem is disabled by default so it's fine to leave
some properties up to the boards if they want to enable it.
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 1 +
arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +-
arch/arm64/boot/dts/qcom/msm8939.dtsi | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
index ae510c5ec830..3381550a5c9e 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
@@ -263,6 +263,7 @@ &mpss {
&mpss_mem {
status = "okay";
+ reg = <0x0 0x86800000 0x0 0x2b00000>;
};
&pm8916_codec {
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 8457472c9ad8..4d867078388d 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -84,7 +84,7 @@ mpss_mem: mpss@86800000 {
* alignment = <0x0 0x400000>;
* alloc-ranges = <0x0 0x86800000 0x0 0x8000000>;
*/
- reg = <0x0 0x86800000 0x0 0x2b00000>;
+ reg = <0x0 0x86800000 0x0 0>; /* size is device-specific */
no-map;
status = "disabled";
};
diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi
index c50f6d828fed..ba177725f3d7 100644
--- a/arch/arm64/boot/dts/qcom/msm8939.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi
@@ -356,7 +356,7 @@ mpss_mem: mpss@86800000 {
* alignment = <0x0 0x400000>;
* alloc-ranges = <0x0 0x86800000 0x0 0x8000000>;
*/
- reg = <0x0 0x86800000 0x0 0x5500000>;
+ reg = <0x0 0x86800000 0x0 0>; /* size is device-specific */
no-map;
status = "disabled";
};
--
2.42.0
next prev parent reply other threads:[~2023-09-11 20:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 17:41 [PATCH 0/9] arm64: dts: qcom: msm8916/39: Reserve firmware memory dynamically Stephan Gerhold
2023-09-11 17:41 ` [PATCH 1/9] arm64: dts: qcom: msm8916: Disable venus by default Stephan Gerhold
2023-09-12 6:34 ` Bryan O'Donoghue
2023-09-11 17:41 ` [PATCH 2/9] arm64: dts: qcom: msm8916/39: Disable GPU " Stephan Gerhold
2023-09-12 6:35 ` Bryan O'Donoghue
2023-09-12 7:45 ` Konrad Dybcio
2023-09-11 17:41 ` [PATCH 3/9] arm64: dts: qcom: msm8916-ufi: Drop gps_mem for now Stephan Gerhold
2023-09-12 6:36 ` Bryan O'Donoghue
2023-09-12 7:42 ` Stephan Gerhold
2023-09-11 17:41 ` [PATCH 4/9] arm64: dts: qcom: msm8916: Reserve firmware memory dynamically Stephan Gerhold
2023-09-13 9:06 ` Konrad Dybcio
2023-09-13 9:12 ` Bryan O'Donoghue
2023-09-13 10:14 ` Stephan Gerhold
2023-09-13 19:39 ` Konrad Dybcio
2023-09-14 14:09 ` Stephan Gerhold
2023-09-15 13:52 ` Konrad Dybcio
2023-09-15 14:00 ` Stephan Gerhold
2023-09-11 17:41 ` [PATCH 5/9] arm64: dts: qcom: msm8916: Reserve MBA " Stephan Gerhold
2023-09-13 8:59 ` Konrad Dybcio
2023-09-11 17:41 ` [PATCH 6/9] arm64: dts: qcom: msm8939: Reserve firmware " Stephan Gerhold
2023-09-11 17:41 ` [PATCH 7/9] arm64: dts: qcom: msm8916/39: Disable unneeded firmware reservations Stephan Gerhold
2023-09-15 13:51 ` Konrad Dybcio
2023-09-15 14:02 ` Stephan Gerhold
2023-09-11 17:41 ` Stephan Gerhold [this message]
2023-09-15 13:51 ` [PATCH 8/9] arm64: dts: qcom: msm8916/39: Move mpss_mem size to boards Konrad Dybcio
2023-09-15 14:03 ` Stephan Gerhold
2023-09-11 17:41 ` [PATCH 9/9] arm64: dts: qcom: msm8916/39: Fix venus memory size Stephan Gerhold
2023-09-12 7:50 ` Konrad Dybcio
2023-09-20 17:14 ` [PATCH 0/9] arm64: dts: qcom: msm8916/39: Reserve firmware memory dynamically Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911-msm8916-rmem-v1-8-b7089ec3e3a1@gerhold.net \
--to=stephan@gerhold.net \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).