* [PATCH] arm64: dts: ti: k3-j721s2-evm-gesi: Specify base dtb for overlay file
@ 2023-09-11 5:21 Siddharth Vadapalli
2023-09-11 16:56 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Siddharth Vadapalli @ 2023-09-11 5:21 UTC (permalink / raw)
To: nm, vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt
Cc: devicetree, linux-kernel, linux-arm-kernel, r-gunasekaran, srk,
s-vadapalli
Specify the base dtb file k3-j721s2-common-proc-board.dtb on which the
k3-j721s2-evm-gesi-exp-board.dtbo overlay has to be applied. Name the
resulting dtb as k3-j721s2-evm.dtb.
Fixes: cac04e27f093 ("arm64: dts: ti: k3-j721s2: Add overlay to enable main CPSW2G with GESI")
Reported-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
---
Note: This patch is based on linux-next tagged next-20230911.
arch/arm64/boot/dts/ti/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
index e7b8e2e7f083..ef8ca50fbb36 100644
--- a/arch/arm64/boot/dts/ti/Makefile
+++ b/arch/arm64/boot/dts/ti/Makefile
@@ -63,9 +63,9 @@ dtb-$(CONFIG_ARCH_K3) += k3-j721e-evm-gesi-exp-board.dtbo
dtb-$(CONFIG_ARCH_K3) += k3-j721e-sk.dtb
# Boards with J721s2 SoC
+k3-j721s2-evm-dtbs := k3-j721s2-common-proc-board.dtb k3-j721s2-evm-gesi-exp-board.dtbo
dtb-$(CONFIG_ARCH_K3) += k3-am68-sk-base-board.dtb
-dtb-$(CONFIG_ARCH_K3) += k3-j721s2-common-proc-board.dtb
-dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm-gesi-exp-board.dtbo
+dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm.dtb
# Boards with J784s4 SoC
dtb-$(CONFIG_ARCH_K3) += k3-am69-sk.dtb
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-j721s2-evm-gesi: Specify base dtb for overlay file
2023-09-11 5:21 [PATCH] arm64: dts: ti: k3-j721s2-evm-gesi: Specify base dtb for overlay file Siddharth Vadapalli
@ 2023-09-11 16:56 ` Rob Herring
2023-09-12 4:01 ` Siddharth Vadapalli
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2023-09-11 16:56 UTC (permalink / raw)
To: Siddharth Vadapalli
Cc: nm, vigneshr, kristo, krzysztof.kozlowski+dt, conor+dt,
devicetree, linux-kernel, linux-arm-kernel, r-gunasekaran, srk
On Mon, Sep 11, 2023 at 10:51:58AM +0530, Siddharth Vadapalli wrote:
> Specify the base dtb file k3-j721s2-common-proc-board.dtb on which the
> k3-j721s2-evm-gesi-exp-board.dtbo overlay has to be applied. Name the
> resulting dtb as k3-j721s2-evm.dtb.
>
> Fixes: cac04e27f093 ("arm64: dts: ti: k3-j721s2: Add overlay to enable main CPSW2G with GESI")
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> ---
>
> Note: This patch is based on linux-next tagged next-20230911.
>
> arch/arm64/boot/dts/ti/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> index e7b8e2e7f083..ef8ca50fbb36 100644
> --- a/arch/arm64/boot/dts/ti/Makefile
> +++ b/arch/arm64/boot/dts/ti/Makefile
> @@ -63,9 +63,9 @@ dtb-$(CONFIG_ARCH_K3) += k3-j721e-evm-gesi-exp-board.dtbo
> dtb-$(CONFIG_ARCH_K3) += k3-j721e-sk.dtb
>
> # Boards with J721s2 SoC
> +k3-j721s2-evm-dtbs := k3-j721s2-common-proc-board.dtb k3-j721s2-evm-gesi-exp-board.dtbo
Move this next to the "dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm.dtb" line.
> dtb-$(CONFIG_ARCH_K3) += k3-am68-sk-base-board.dtb
> -dtb-$(CONFIG_ARCH_K3) += k3-j721s2-common-proc-board.dtb
> -dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm-gesi-exp-board.dtbo
I think dropping these will cause them to not get installed (by
dtbs_install). Presumably you want them.
> +dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm.dtb
>
> # Boards with J784s4 SoC
> dtb-$(CONFIG_ARCH_K3) += k3-am69-sk.dtb
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-j721s2-evm-gesi: Specify base dtb for overlay file
2023-09-11 16:56 ` Rob Herring
@ 2023-09-12 4:01 ` Siddharth Vadapalli
2023-09-12 4:36 ` Siddharth Vadapalli
0 siblings, 1 reply; 4+ messages in thread
From: Siddharth Vadapalli @ 2023-09-12 4:01 UTC (permalink / raw)
To: Rob Herring
Cc: nm, vigneshr, kristo, krzysztof.kozlowski+dt, conor+dt,
devicetree, linux-kernel, linux-arm-kernel, r-gunasekaran, srk,
s-vadapalli
Rob,
Thank you for reviewing the patch.
On 11/09/23 22:26, Rob Herring wrote:
> On Mon, Sep 11, 2023 at 10:51:58AM +0530, Siddharth Vadapalli wrote:
>> Specify the base dtb file k3-j721s2-common-proc-board.dtb on which the
>> k3-j721s2-evm-gesi-exp-board.dtbo overlay has to be applied. Name the
>> resulting dtb as k3-j721s2-evm.dtb.
>>
>> Fixes: cac04e27f093 ("arm64: dts: ti: k3-j721s2: Add overlay to enable main CPSW2G with GESI")
>> Reported-by: Rob Herring <robh+dt@kernel.org>
>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>> ---
>>
>> Note: This patch is based on linux-next tagged next-20230911.
>>
>> arch/arm64/boot/dts/ti/Makefile | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
>> index e7b8e2e7f083..ef8ca50fbb36 100644
>> --- a/arch/arm64/boot/dts/ti/Makefile
>> +++ b/arch/arm64/boot/dts/ti/Makefile
>> @@ -63,9 +63,9 @@ dtb-$(CONFIG_ARCH_K3) += k3-j721e-evm-gesi-exp-board.dtbo
>> dtb-$(CONFIG_ARCH_K3) += k3-j721e-sk.dtb
>>
>> # Boards with J721s2 SoC
>> +k3-j721s2-evm-dtbs := k3-j721s2-common-proc-board.dtb k3-j721s2-evm-gesi-exp-board.dtbo
>
> Move this next to the "dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm.dtb" line.
Sure, I will place it above the k3-j721s2-evm.dtb line.
>
>> dtb-$(CONFIG_ARCH_K3) += k3-am68-sk-base-board.dtb
>> -dtb-$(CONFIG_ARCH_K3) += k3-j721s2-common-proc-board.dtb
>> -dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm-gesi-exp-board.dtbo
>
> I think dropping these will cause them to not get installed (by
> dtbs_install). Presumably you want them.
I will undo the above deletions in the v2 patch.
>
>> +dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm.dtb
>>
>> # Boards with J784s4 SoC
>> dtb-$(CONFIG_ARCH_K3) += k3-am69-sk.dtb
>> --
>> 2.34.1
>>
--
Regards,
Siddharth.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-j721s2-evm-gesi: Specify base dtb for overlay file
2023-09-12 4:01 ` Siddharth Vadapalli
@ 2023-09-12 4:36 ` Siddharth Vadapalli
0 siblings, 0 replies; 4+ messages in thread
From: Siddharth Vadapalli @ 2023-09-12 4:36 UTC (permalink / raw)
To: Rob Herring
Cc: nm, vigneshr, kristo, krzysztof.kozlowski+dt, conor+dt,
devicetree, linux-kernel, linux-arm-kernel, r-gunasekaran, srk,
s-vadapalli
On 12/09/23 09:31, Siddharth Vadapalli wrote:
> Rob,
>
> Thank you for reviewing the patch.
>
> On 11/09/23 22:26, Rob Herring wrote:
...
>> Move this next to the "dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm.dtb" line.
>
> Sure, I will place it above the k3-j721s2-evm.dtb line.
>
>>
>>> dtb-$(CONFIG_ARCH_K3) += k3-am68-sk-base-board.dtb
>>> -dtb-$(CONFIG_ARCH_K3) += k3-j721s2-common-proc-board.dtb
>>> -dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm-gesi-exp-board.dtbo
>>
>> I think dropping these will cause them to not get installed (by
>> dtbs_install). Presumably you want them.
>
> I will undo the above deletions in the v2 patch.
I have addressed the feedback and have posted the v2 patch at:
https://lore.kernel.org/r/20230912043308.20629-1-s-vadapalli@ti.com/
>
>>
>>> +dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm.dtb
>>>
>>> # Boards with J784s4 SoC
>>> dtb-$(CONFIG_ARCH_K3) += k3-am69-sk.dtb
>>> --
>>> 2.34.1
>>>
>
--
Regards,
Siddharth.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-12 4:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-11 5:21 [PATCH] arm64: dts: ti: k3-j721s2-evm-gesi: Specify base dtb for overlay file Siddharth Vadapalli
2023-09-11 16:56 ` Rob Herring
2023-09-12 4:01 ` Siddharth Vadapalli
2023-09-12 4:36 ` Siddharth Vadapalli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).