Re: [PATCH 2/4] ARM: dts: ti: omap: motorola-mapphone: Fix abe_clkctrl warning on boot

[Sebastian Reichel <sebastian.reichel@collabora.com>]

[-- Attachment #1: Type: text/plain, Size: 1995 bytes --]

Hi,

On Mon, Sep 11, 2023 at 07:08:25AM +0300, Tony Lindgren wrote:
> Commit 0840242e8875 ("ARM: dts: Configure clock parent for pwm vibra")
> attempted to fix the PWM settings but ended up causin an additional clock
> reparenting error:
> 
> clk: failed to reparent abe-clkctrl:0060:24 to sys_clkin_ck: -22
> 
> Only timer9 is in the PER domain and can use the sys_clkin_ck clock source.
> For timer8, the there is no sys_clkin_ck available as it's in the ABE
> domain, instead it should use syc_clk_div_ck. However, for power
> management, we want to use the always on sys_32k_ck instead.
> 
> Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> Cc: Carl Philipp Klemm <philipp@uvos.xyz>
> Cc: Merlijn Wajer <merlijn@wizzup.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Sebastian Reichel <sre@kernel.org>
> Fixes: 0840242e8875 ("ARM: dts: Configure clock parent for pwm vibra")
> Depends-on: 61978617e905 ("ARM: dts: Add minimal support for Droid Bionic xt875")
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

>  arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi b/arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi
> --- a/arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi
> @@ -614,12 +614,12 @@ &rng_target {
>  /* Configure pwm clock source for timers 8 & 9 */
>  &timer8 {
>  	assigned-clocks = <&abe_clkctrl OMAP4_TIMER8_CLKCTRL 24>;
> -	assigned-clock-parents = <&sys_clkin_ck>;
> +	assigned-clock-parents = <&sys_32k_ck>;
>  };
>  
>  &timer9 {
>  	assigned-clocks = <&l4_per_clkctrl OMAP4_TIMER9_CLKCTRL 24>;
> -	assigned-clock-parents = <&sys_clkin_ck>;
> +	assigned-clock-parents = <&sys_32k_ck>;
>  };
>  
>  /*
> -- 
> 2.42.0

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]