From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org,
"Benoît Cousson" <bcousson@baylibre.com>,
devicetree@vger.kernel.org,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Carl Philipp Klemm" <philipp@uvos.xyz>,
"Merlijn Wajer" <merlijn@wizzup.org>,
"Pavel Machek" <pavel@ucw.cz>
Subject: Re: [PATCH 3/4] ARM: dts: ti: omap: Fix noisy serial with overrun-throttle-ms for mapphone
Date: Tue, 12 Sep 2023 17:31:05 +0200 [thread overview]
Message-ID: <20230912153105.sflbdvbwxwy2q7kn@mercury.elektranox.org> (raw)
In-Reply-To: <20230911040828.39386-3-tony@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]
Hi,
On Mon, Sep 11, 2023 at 07:08:26AM +0300, Tony Lindgren wrote:
> On mapphone devices we may get lots of noise on the micro-USB port in debug
> uart mode until the phy-cpcap-usb driver probes. Let's limit the noise by
> using overrun-throttle-ms.
>
> Note that there is also a related separate issue where the charger cable
> connected may cause random sysrq requests until phy-cpcap-usb probes that
> still remains.
>
> Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> Cc: Carl Philipp Klemm <philipp@uvos.xyz>
> Cc: Merlijn Wajer <merlijn@wizzup.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
A bit of a hack, but I guess it improves the status quo, so:
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
> arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi b/arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi
> --- a/arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi
> @@ -640,6 +640,7 @@ &uart1 {
> &uart3 {
> interrupts-extended = <&wakeupgen GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH
> &omap4_pmx_core 0x17c>;
> + overrun-throttle-ms = <500>;
> };
>
> &uart4 {
> --
> 2.42.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-09-12 15:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 4:08 [PATCH 1/4] ARM: dts: ti: omap: Fix bandgap thermal cells addressing for omap3/4 Tony Lindgren
2023-09-11 4:08 ` [PATCH 2/4] ARM: dts: ti: omap: motorola-mapphone: Fix abe_clkctrl warning on boot Tony Lindgren
2023-09-12 15:29 ` Sebastian Reichel
2023-09-11 4:08 ` [PATCH 3/4] ARM: dts: ti: omap: Fix noisy serial with overrun-throttle-ms for mapphone Tony Lindgren
2023-09-12 15:31 ` Sebastian Reichel [this message]
2023-09-11 4:08 ` [PATCH 4/4] ARM: omap2+: Downgrade u-boot version warnings to debug statements Tony Lindgren
2023-09-12 15:27 ` Sebastian Reichel
2023-09-12 15:20 ` [PATCH 1/4] ARM: dts: ti: omap: Fix bandgap thermal cells addressing for omap3/4 Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912153105.sflbdvbwxwy2q7kn@mercury.elektranox.org \
--to=sebastian.reichel@collabora.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=pavel@ucw.cz \
--cc=philipp@uvos.xyz \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).