* [PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks entries
@ 2023-09-12 16:38 Fabio Estevam
2023-09-12 16:38 ` [PATCH v3 2/3] arm64: dts: Remove JPEG clock-names Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Fabio Estevam @ 2023-09-12 16:38 UTC (permalink / raw)
To: shawnguo
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, mirela.rabulea,
devicetree, linux-arm-kernel, alexander.stein, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
The JPEG decoder/encoder present in iMX8QXP and iMX8QM SoCs need
the PER and IPG clocks to be functional, so add the clock entries.
This also fixes the following schema warning:
imx8qm-apalis-eval.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml#
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v2:
- Remove clock-names. (Mirela)
.../devicetree/bindings/media/nxp,imx8-jpeg.yaml | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
index 3d9d1db37040..3383a275c94a 100644
--- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
+++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
@@ -31,6 +31,9 @@ properties:
reg:
maxItems: 1
+ clocks:
+ maxItems: 2
+
interrupts:
description: |
There are 4 slots available in the IP, which the driver may use
@@ -49,6 +52,7 @@ properties:
required:
- compatible
- reg
+ - clocks
- interrupts
- power-domains
@@ -56,12 +60,15 @@ additionalProperties: false
examples:
- |
+ #include <dt-bindings/clock/imx8-lpcg.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/firmware/imx/rsrc.h>
jpegdec: jpegdec@58400000 {
compatible = "nxp,imx8qxp-jpgdec";
reg = <0x58400000 0x00050000 >;
+ clocks = <&img_jpeg_dec_lpcg IMX_LPCG_CLK_0>,
+ <&img_jpeg_dec_lpcg IMX_LPCG_CLK_4>;
interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 311 IRQ_TYPE_LEVEL_HIGH>,
@@ -76,6 +83,8 @@ examples:
jpegenc: jpegenc@58450000 {
compatible = "nxp,imx8qm-jpgenc", "nxp,imx8qxp-jpgenc";
reg = <0x58450000 0x00050000 >;
+ clocks = <&img_jpeg_enc_lpcg IMX_LPCG_CLK_0>,
+ <&img_jpeg__lpcg IMX_LPCG_CLK_4>;
interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>,
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v3 2/3] arm64: dts: Remove JPEG clock-names
2023-09-12 16:38 [PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks entries Fabio Estevam
@ 2023-09-12 16:38 ` Fabio Estevam
2023-09-12 16:46 ` Fabio Estevam
2023-09-12 16:38 ` [PATCH v3 3/3] arm64: imx8qm-ss-img: Fix jpegenc compatible entry Fabio Estevam
2023-09-13 7:04 ` [PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks entries Krzysztof Kozlowski
2 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2023-09-12 16:38 UTC (permalink / raw)
To: shawnguo
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, mirela.rabulea,
devicetree, linux-arm-kernel, alexander.stein, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
Per nxp,imx8-jpeg.yaml, the clock-names entry is not valid.
Remove them.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v2:
- Newly introduced.
arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
index a90654155a88..39577071e1d3 100644
--- a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
@@ -24,7 +24,6 @@ jpegdec: jpegdec@58400000 {
<GIC_SPI 312 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&img_jpeg_dec_lpcg IMX_LPCG_CLK_0>,
<&img_jpeg_dec_lpcg IMX_LPCG_CLK_4>;
- clock-names = "per", "ipg";
assigned-clocks = <&img_jpeg_dec_lpcg IMX_LPCG_CLK_0>,
<&img_jpeg_dec_lpcg IMX_LPCG_CLK_4>;
assigned-clock-rates = <200000000>, <200000000>;
@@ -43,7 +42,6 @@ jpegenc: jpegenc@58450000 {
<GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&img_jpeg_enc_lpcg IMX_LPCG_CLK_0>,
<&img_jpeg_enc_lpcg IMX_LPCG_CLK_4>;
- clock-names = "per", "ipg";
assigned-clocks = <&img_jpeg_enc_lpcg IMX_LPCG_CLK_0>,
<&img_jpeg_enc_lpcg IMX_LPCG_CLK_4>;
assigned-clock-rates = <200000000>, <200000000>;
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3 2/3] arm64: dts: Remove JPEG clock-names
2023-09-12 16:38 ` [PATCH v3 2/3] arm64: dts: Remove JPEG clock-names Fabio Estevam
@ 2023-09-12 16:46 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2023-09-12 16:46 UTC (permalink / raw)
To: shawnguo
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, mirela.rabulea,
devicetree, linux-arm-kernel, alexander.stein, Fabio Estevam
On Tue, Sep 12, 2023 at 1:38 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> From: Fabio Estevam <festevam@denx.de>
>
> Per nxp,imx8-jpeg.yaml, the clock-names entry is not valid.
>
> Remove them.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Sorry, I missed adding imx8-ss-img in the Subject line.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 3/3] arm64: imx8qm-ss-img: Fix jpegenc compatible entry
2023-09-12 16:38 [PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks entries Fabio Estevam
2023-09-12 16:38 ` [PATCH v3 2/3] arm64: dts: Remove JPEG clock-names Fabio Estevam
@ 2023-09-12 16:38 ` Fabio Estevam
2023-09-13 7:04 ` [PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks entries Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2023-09-12 16:38 UTC (permalink / raw)
To: shawnguo
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, mirela.rabulea,
devicetree, linux-arm-kernel, alexander.stein, Fabio Estevam,
Krzysztof Kozlowski
From: Fabio Estevam <festevam@denx.de>
The first compatible entry for the jpegenc should be 'nxp,imx8qm-jpgenc'.
Change it accordingly to fix the following schema warning:
imx8qm-apalis-eval.dtb: jpegenc@58450000: compatible: 'oneOf' conditional failed, one must be fixed:
'nxp,imx8qm-jpgdec' is not one of ['nxp,imx8qxp-jpgdec', 'nxp,imx8qxp-jpgenc']
'nxp,imx8qm-jpgenc' was expected
'nxp,imx8qxp-jpgdec' was expected
Fixes: 5bb279171afc ("arm64: dts: imx8: Add jpeg encoder/decoder nodes")
Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Mirela Rabulea <mirela.rabulea@nxp.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes since v2:
- Collected Reviewed-by tags.
arch/arm64/boot/dts/freescale/imx8qm-ss-img.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-img.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-img.dtsi
index 7764b4146e0a..2bbdacb1313f 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm-ss-img.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-img.dtsi
@@ -8,5 +8,5 @@ &jpegdec {
};
&jpegenc {
- compatible = "nxp,imx8qm-jpgdec", "nxp,imx8qxp-jpgenc";
+ compatible = "nxp,imx8qm-jpgenc", "nxp,imx8qxp-jpgenc";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks entries
2023-09-12 16:38 [PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks entries Fabio Estevam
2023-09-12 16:38 ` [PATCH v3 2/3] arm64: dts: Remove JPEG clock-names Fabio Estevam
2023-09-12 16:38 ` [PATCH v3 3/3] arm64: imx8qm-ss-img: Fix jpegenc compatible entry Fabio Estevam
@ 2023-09-13 7:04 ` Krzysztof Kozlowski
2023-09-13 7:05 ` Krzysztof Kozlowski
2 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-13 7:04 UTC (permalink / raw)
To: Fabio Estevam, shawnguo
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, mirela.rabulea,
devicetree, linux-arm-kernel, alexander.stein, Fabio Estevam
On 12/09/2023 18:38, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The JPEG decoder/encoder present in iMX8QXP and iMX8QM SoCs need
> the PER and IPG clocks to be functional, so add the clock entries.
>
> This also fixes the following schema warning:
>
> imx8qm-apalis-eval.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v2:
> - Remove clock-names. (Mirela)
>
> .../devicetree/bindings/media/nxp,imx8-jpeg.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> index 3d9d1db37040..3383a275c94a 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> @@ -31,6 +31,9 @@ properties:
> reg:
> maxItems: 1
>
> + clocks:
> + maxItems: 2
You need to describe the clocks, so "items" with descriptions instead of
maxItems.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks entries
2023-09-13 7:04 ` [PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks entries Krzysztof Kozlowski
@ 2023-09-13 7:05 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-13 7:05 UTC (permalink / raw)
To: Fabio Estevam, shawnguo
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, mirela.rabulea,
devicetree, linux-arm-kernel, alexander.stein, Fabio Estevam
On 13/09/2023 09:04, Krzysztof Kozlowski wrote:
> On 12/09/2023 18:38, Fabio Estevam wrote:
>> From: Fabio Estevam <festevam@denx.de>
>>
>> The JPEG decoder/encoder present in iMX8QXP and iMX8QM SoCs need
>> the PER and IPG clocks to be functional, so add the clock entries.
>>
>> This also fixes the following schema warning:
>>
>> imx8qm-apalis-eval.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
>> from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml#
>>
>> Signed-off-by: Fabio Estevam <festevam@denx.de>
>> ---
>> Changes since v2:
>> - Remove clock-names. (Mirela)
>>
>> .../devicetree/bindings/media/nxp,imx8-jpeg.yaml | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>> index 3d9d1db37040..3383a275c94a 100644
>> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>> @@ -31,6 +31,9 @@ properties:
>> reg:
>> maxItems: 1
>>
>> + clocks:
>> + maxItems: 2
>
> You need to describe the clocks, so "items" with descriptions instead of
> maxItems.
And to be clear: such description was in your previous version, so it's
the problem introduced now in v3...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-09-13 7:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-12 16:38 [PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks entries Fabio Estevam
2023-09-12 16:38 ` [PATCH v3 2/3] arm64: dts: Remove JPEG clock-names Fabio Estevam
2023-09-12 16:46 ` Fabio Estevam
2023-09-12 16:38 ` [PATCH v3 3/3] arm64: imx8qm-ss-img: Fix jpegenc compatible entry Fabio Estevam
2023-09-13 7:04 ` [PATCH v3 1/3] dt-bindings: imx8-jpeg: Add clocks entries Krzysztof Kozlowski
2023-09-13 7:05 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).