From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E01DEDEC6B for ; Wed, 13 Sep 2023 14:42:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241178AbjIMOm6 (ORCPT ); Wed, 13 Sep 2023 10:42:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232390AbjIMOm5 (ORCPT ); Wed, 13 Sep 2023 10:42:57 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00B4791; Wed, 13 Sep 2023 07:42:53 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 904A6C433C8; Wed, 13 Sep 2023 14:42:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694616173; bh=ghmd2vE6l3/YQAYcdHB/Auew4n3efVE8LafRtaXbVHc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YGMCHCaS7LV+IgxR8JwzA2LNP/JAobSO7VFWJqFuLotcrNli1S/nHKVzF//aJ2S6V oyTmUUNwYQcB2nInr2C8Ez39iVMQmhLWasrm56DXWToBj15FazV/Kl6X9Oqd98l7vq xYCSySPKPtfqvA4b/JjwavRqFP6IGhDc7F3DFnWpvbrbrOP/iHL2RUh7HiB9Nfi1ae OAv6grpPZpsAP5EFZJg6+L0GXuBVZ6JskfXUivQah7NoYp1WtIsK8dxArv+axEEnrs p+KoYbQrGGzwtNfTaPkj8pd6Rp9GlH1mROzy40I5zjPv5zmvE+yp4nzsVVzTdwFELZ 0zorZ83mPn+fA== Date: Wed, 13 Sep 2023 15:42:45 +0100 From: Conor Dooley To: Herve Codina Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Simon Horman , Christophe JAILLET , Thomas Petazzoni Subject: Re: [PATCH v5 08/31] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add support for QMC HDLC Message-ID: <20230913-unruly-recite-7dbbbd7e63e0@spud> References: <20230912081527.208499-1-herve.codina@bootlin.com> <20230912101018.225246-1-herve.codina@bootlin.com> <20230912-capable-stash-c7a3e33078ac@spud> <20230913092640.76934b31@bootlin.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="D/KR2KGuouPtsCp2" Content-Disposition: inline In-Reply-To: <20230913092640.76934b31@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --D/KR2KGuouPtsCp2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 13, 2023 at 09:26:40AM +0200, Herve Codina wrote: > Hi Conor, >=20 > On Tue, 12 Sep 2023 18:21:58 +0100 > Conor Dooley wrote: >=20 > > On Tue, Sep 12, 2023 at 12:10:18PM +0200, Herve Codina wrote: > > > The QMC (QUICC mutichannel controller) is a controller present in some > > > PowerQUICC SoC such as MPC885. > > > The QMC HDLC uses the QMC controller to transfer HDLC data. > > >=20 > > > Additionally, a framer can be connected to the QMC HDLC. > > > If present, this framer is the interface between the TDM bus used by = the > > > QMC HDLC and the E1/T1 line. > > > The QMC HDLC can use this framer to get information about the E1/T1 l= ine > > > and configure the E1/T1 line. > > >=20 > > > Signed-off-by: Herve Codina > > > --- > > > .../bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml | 13 +++++++++++= ++ > > > 1 file changed, 13 insertions(+) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm= 1-scc-qmc.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-= scc-qmc.yaml > > > index 82d9beb48e00..b5073531f3f1 100644 > > > --- a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-q= mc.yaml > > > +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-q= mc.yaml > > > @@ -101,6 +101,16 @@ patternProperties: > > > Channel assigned Rx time-slots within the Rx time-slots ro= uted by the > > > TSA to this cell. > > > =20 > > > + compatible: > > > + const: fsl,qmc-hdlc > > > + > > > + fsl,framer: > > > + $ref: /schemas/types.yaml#/definitions/phandle > > > + description: > > > + phandle to the framer node. The framer is in charge of an = E1/T1 line > > > + interface connected to the TDM bus. It can be used to get = the E1/T1 line > > > + status such as link up/down. =20 > >=20 > > Sounds like this fsl,framer property should depend on the compatible > > being present, no? >=20 > Well from the implementation point of view, only the QMC HDLC driver uses= this > property. >=20 > From the hardware description point of view, this property means that the= time slots > handled by this channel are connected to the framer. So I think it makes = sense for > any channel no matter the compatible (even if compatible is not present). >=20 > Should I change and constraint the fsl,framer property to the compatible = presence ? > If so, is the following correct for this contraint ? > --- 8< --- > dependencies: > - fsl,framer: [ compatible ]; > --- 8< --- The regular sort of if: compatible: contains: const: foo then: required: - fsl,framer would fit the bill, no? --D/KR2KGuouPtsCp2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZQHKZQAKCRB4tDGHoIJi 0jE/AP0awmyeu05CVKleLo13y3Fjt4HP0do7dEhQGNt4rxVmsAEAtTdqxGH2EmC6 3WhT1AVUi21kX6VzpxFlrQiNmHgB/A4= =zHjw -----END PGP SIGNATURE----- --D/KR2KGuouPtsCp2--