From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37CE128E11 for ; Thu, 14 Sep 2023 14:42:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 801DBC433C7; Thu, 14 Sep 2023 14:42:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694702525; bh=O9w4R0Iu6/XNvjfu2aj/DjJkGOobrTu4cV0g3uZvCyc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ed497R3ieIebv7g5fw/xSOgE3pjwdUxNHnBc/LRisrd3WOhjfXkVlP1xUfG6GZ1dh yhMvzh0fLaKCjCh9EIfdwFf5u+um7WgmHDVhRcKGUU8HNwl3JZqr4ynQ08IuGfWizT TK+ihlUxtec6fRDNTjfobbb5uPVC+wIxfXiOsu0rKFDCdIsGCjMC8v5JkXv0uWl9Q+ kPvHCkw3F4uvq3l8umHhUpVRUnhHc646iJA50d96tmNV8KJ3Mrgf74hC0AkTtpa1cy AXDOAs05ebD2GTWCm/eg+6nwKZXz5cn0jjAxYqNt1bcv43PD4BVh4C7CVkkXZUq4mr 7UI9/X2DP/L+Q== Date: Thu, 14 Sep 2023 15:42:01 +0100 From: Conor Dooley To: Daniel Matyas Cc: Jean Delvare , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3 2/5] dt-bindings: hwmon: Add possible new properties to max31827 bindings Message-ID: <20230914-qualify-ragweed-b06b7b7923c9@spud> References: <20230914075948.208046-1-daniel.matyas@analog.com> <20230914075948.208046-2-daniel.matyas@analog.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="71snxAjsMqH/MtRQ" Content-Disposition: inline In-Reply-To: <20230914075948.208046-2-daniel.matyas@analog.com> --71snxAjsMqH/MtRQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 14, 2023 at 10:59:45AM +0300, Daniel Matyas wrote: > These modify the corresponding bits in the configuration register. >=20 > adi,comp-int is a hardware property, because it affects the behavior > of the interrupt signal and whatever it is connected to. >=20 > adi,timeout-enable is a hardware property, because it affects i2c > bus operation. >=20 > Signed-off-by: Daniel Matyas > --- >=20 > v2 -> v3: Changed commit subject and message >=20 > v1 -> v2: Added adi,timeout-enable property to binding. Fixed > dt_binding_check errors. >=20 > .../bindings/hwmon/adi,max31827.yaml | 35 +++++++++++++++++++ > 1 file changed, 35 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml b/= Documentation/devicetree/bindings/hwmon/adi,max31827.yaml > index 2dc8b07b4d3b..6bde71bdb8dd 100644 > --- a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml > +++ b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml > @@ -32,6 +32,37 @@ properties: > Must have values in the interval (1.6V; 3.6V) in order for the dev= ice to > function correctly. > =20 > + adi,comp-int: > + description: > + If present interrupt mode is used. If not present comparator mode = is used > + (default). > + type: boolean > + > + adi,alrm-pol: Characters are not at a premium, is there a reason not to use the full words? "flt-q" in particular would be quite cryptic if I saw it in a dts. > + description: > + Sets the alarms active state. > + - 0 =3D active low > + - 1 =3D active high > + For max31827 and max31828 the default alarm polarity is low. For m= ax31829 > + it is high. This constraint can be expressed in the binding, rather than in free form text like done here. Ditto below. Thanks, Conor. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1] > + > + adi,flt-q: > + description: > + Select how many consecutive temperature faults must occur before > + overtemperature or undertemperature faults are indicated in the > + corresponding status bits. > + For max31827 default fault queue is 1. For max31828 and max31829 i= t is 4. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [1, 2, 4, 8] > + > + adi,timeout-enable: > + description: > + Enables timeout. Bus timeout resets the I2C-compatible interface w= hen SCL > + is low for more than 30ms (nominal). > + type: boolean > + > required: > - compatible > - reg > @@ -49,6 +80,10 @@ examples: > compatible =3D "adi,max31827"; > reg =3D <0x42>; > vref-supply =3D <®_vdd>; > + adi,comp-int; > + adi,alrm-pol =3D <0>; > + adi,flt-q =3D <1>; > + adi,timeout-enable; > }; > }; > ... > --=20 > 2.34.1 >=20 --71snxAjsMqH/MtRQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZQMbuQAKCRB4tDGHoIJi 0gqiAQDbZmcqv2uLoYCOMuAvkhjjcMC3XJyStjoO3fVxrPd9BQEA4h/jctruYGgi yrh/mEKmKTQtA3z6WR3RqxXxaJ2mowA= =RMiX -----END PGP SIGNATURE----- --71snxAjsMqH/MtRQ--