From: Rob Herring <robh@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Abel Vesa <abel.vesa@linaro.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: phy: qcom,snps-eusb2-repeater: Add magic tuning overrides
Date: Thu, 14 Sep 2023 09:48:07 -0500 [thread overview]
Message-ID: <20230914144807.GA1267899-robh@kernel.org> (raw)
In-Reply-To: <20230830-topic-eusb2_override-v2-1-7d8c893d93f6@linaro.org>
On Wed, Sep 13, 2023 at 11:53:23AM +0200, Konrad Dybcio wrote:
> The EUSB2 repeater requires some alterations to its init sequence,
> depending on board design.
>
> Add support for making the necessary changes to that sequence to make USB
> functional on SM8550-based Xperia 1 V.
>
> They all have lackluster description due to lack of information.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> .../bindings/phy/qcom,snps-eusb2-repeater.yaml | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> index 029569d5fcf3..24c733c10e0e 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> @@ -32,6 +32,27 @@ properties:
>
> vdd3-supply: true
>
> + qcom,tune-usb2-disc-thres:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + description: High-Speed disconnect threshold
> + minimum: 0
> + maximum: 7
> + default: 0
> +
> + qcom,tune-usb2-amplitude:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + description: High-Speed trasmit amplitude
> + minimum: 0
> + maximum: 15
> + default: 8
> +
> + qcom,tune-usb2-preem:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + description: High-Speed TX pre-emphasis tuning
> + minimum: 0
> + maximum: 7
> + default: 5
For what it is worth, the mediatek,tphy.yaml binding has the same
properties...
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2023-09-14 14:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 9:53 [PATCH v2 0/4] EUSB2 repeater init sequence override Konrad Dybcio
2023-09-13 9:53 ` [PATCH v2 1/4] dt-bindings: phy: qcom,snps-eusb2-repeater: Add magic tuning overrides Konrad Dybcio
2023-09-14 14:48 ` Rob Herring [this message]
2023-09-13 9:53 ` [PATCH v2 2/4] phy: qualcomm: phy-qcom-eusb2-repeater: Use regmap_fields Konrad Dybcio
2023-09-13 9:53 ` [PATCH v2 3/4] phy: qualcomm: phy-qcom-eusb2-repeater: Zero out untouched tuning regs Konrad Dybcio
2023-09-13 9:53 ` [PATCH v2 4/4] phy: qualcomm: phy-qcom-eusb2-repeater: Add tuning overrides Konrad Dybcio
2023-09-21 14:29 ` [PATCH v2 0/4] EUSB2 repeater init sequence override Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230914144807.GA1267899-robh@kernel.org \
--to=robh@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=marijn.suijten@somainline.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).