Re: [PATCH v4] media: dt-bindings: Add OV5642

[Rob Herring <robh@kernel.org>]

On Wed, Sep 13, 2023 at 04:28:11PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> As explained in the description text from trivial-devices.yaml:
> 
> "This is a list of trivial I2C and SPI devices that have simple device tree
> bindings, consisting only of a compatible field, an address and possibly an
> interrupt line."
> 
> A camera device does not fall into this category as it needs other
> properties such as regulators, reset and powerdown GPIOs, clocks,
> media endpoint.
> 
> Remove the OV5642 entry from trivial-devices.yaml and add its own
> ovti,ov5642.yaml.

Many of these Omnivision sensors have the same supplies and same GPIO 
connections, so why can't they share the binding? There are some 
differences I've seen that boil down to just what the driver decided to 
require or not, but that shouldn't really vary. See commit 44ade291b77c 
("media: dt-bindings: Merge OV5695 into OV5693 binding") for example.

In any case, the binding looks fine and any merging can be done after.

Reviewed-by: Rob Herring <robh@kernel.org>

> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v3:
> - Make propeties conditional on parallel verus MIPI CSI-2. (Sakari)
> - Remove clock-names as there is a single clock.
> - Pass bus-type.
> 
>  .../bindings/media/i2c/ovti,ov5642.yaml       | 141 ++++++++++++++++++
>  .../devicetree/bindings/trivial-devices.yaml  |   2 -
>  2 files changed, 141 insertions(+), 2 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5642.yaml