* [PATCH] dt-bindings: ata: pata-common: Add missing additionalProperties on child nodes
@ 2023-09-15 20:16 Rob Herring
2023-09-15 21:10 ` Conor Dooley
2023-09-19 17:19 ` Damien Le Moal
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2023-09-15 20:16 UTC (permalink / raw)
To: Damien Le Moal, Krzysztof Kozlowski, Conor Dooley, Linus Walleij
Cc: linux-ide, devicetree, linux-kernel
The PATA child node schema is missing constraints to prevent unknown
properties. As none of the users of this common binding extend the child
nodes with additional properties, adding "additionalProperties: false"
here is sufficient.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/ata/pata-common.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/ata/pata-common.yaml b/Documentation/devicetree/bindings/ata/pata-common.yaml
index 337ddf1113c4..4e867dd4d402 100644
--- a/Documentation/devicetree/bindings/ata/pata-common.yaml
+++ b/Documentation/devicetree/bindings/ata/pata-common.yaml
@@ -38,6 +38,7 @@ patternProperties:
ID number 0 and the slave drive will have ID number 1. The PATA port
nodes will be named "ide-port".
type: object
+ additionalProperties: false
properties:
reg:
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: ata: pata-common: Add missing additionalProperties on child nodes
2023-09-15 20:16 [PATCH] dt-bindings: ata: pata-common: Add missing additionalProperties on child nodes Rob Herring
@ 2023-09-15 21:10 ` Conor Dooley
2023-09-19 17:19 ` Damien Le Moal
1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2023-09-15 21:10 UTC (permalink / raw)
To: Rob Herring
Cc: Damien Le Moal, Krzysztof Kozlowski, Conor Dooley, Linus Walleij,
linux-ide, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]
On Fri, Sep 15, 2023 at 03:16:20PM -0500, Rob Herring wrote:
> The PATA child node schema is missing constraints to prevent unknown
> properties. As none of the users of this common binding extend the child
> nodes with additional properties, adding "additionalProperties: false"
> here is sufficient.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
> ---
> Documentation/devicetree/bindings/ata/pata-common.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/ata/pata-common.yaml b/Documentation/devicetree/bindings/ata/pata-common.yaml
> index 337ddf1113c4..4e867dd4d402 100644
> --- a/Documentation/devicetree/bindings/ata/pata-common.yaml
> +++ b/Documentation/devicetree/bindings/ata/pata-common.yaml
> @@ -38,6 +38,7 @@ patternProperties:
> ID number 0 and the slave drive will have ID number 1. The PATA port
> nodes will be named "ide-port".
> type: object
> + additionalProperties: false
>
> properties:
> reg:
> --
> 2.40.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: ata: pata-common: Add missing additionalProperties on child nodes
2023-09-15 20:16 [PATCH] dt-bindings: ata: pata-common: Add missing additionalProperties on child nodes Rob Herring
2023-09-15 21:10 ` Conor Dooley
@ 2023-09-19 17:19 ` Damien Le Moal
1 sibling, 0 replies; 3+ messages in thread
From: Damien Le Moal @ 2023-09-19 17:19 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Walleij
Cc: linux-ide, devicetree, linux-kernel
On 2023/09/15 13:16, Rob Herring wrote:
> The PATA child node schema is missing constraints to prevent unknown
> properties. As none of the users of this common binding extend the child
> nodes with additional properties, adding "additionalProperties: false"
> here is sufficient.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied to for-6.6-fixes. Thanks !
> ---
> Documentation/devicetree/bindings/ata/pata-common.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/ata/pata-common.yaml b/Documentation/devicetree/bindings/ata/pata-common.yaml
> index 337ddf1113c4..4e867dd4d402 100644
> --- a/Documentation/devicetree/bindings/ata/pata-common.yaml
> +++ b/Documentation/devicetree/bindings/ata/pata-common.yaml
> @@ -38,6 +38,7 @@ patternProperties:
> ID number 0 and the slave drive will have ID number 1. The PATA port
> nodes will be named "ide-port".
> type: object
> + additionalProperties: false
>
> properties:
> reg:
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-19 17:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-15 20:16 [PATCH] dt-bindings: ata: pata-common: Add missing additionalProperties on child nodes Rob Herring
2023-09-15 21:10 ` Conor Dooley
2023-09-19 17:19 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).