From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76E4A6FCE for ; Mon, 18 Sep 2023 14:36:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69AA5C32789; Mon, 18 Sep 2023 14:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695047804; bh=IfcPayrszXf2AFTeibhLXb3wqIzPd0LKfNZxtwS2mfk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nZeWQEtVhgSV6zJLG6o5IXSaR68hUpTRf84ck71DeXjPwJBEuf465kAsXO0OIraKx D+Tt3aS4URLcc4nNkBLWeX1CAiMu0KQXOJbwdfZKUQk/waKBE0pxRNBc0pqyC3pbgU 293RWwkRWfptDXMenR/SBAIzOtwJoIdfy9LL5TS4TJ2KvjuZ+HRuCXebsVkM1Rp1h9 1LVIwQ3833st29eO+gDgGSDuuq0hqadBFGMmNLphanSXOZkVa9nTy/+c9eXuXOJN4N 1SWxqmx3Deu5Qp/9fdt8xq3hJZqIjTVSzEB1H9/cWTBXzjRFfexR/nanZPPPKBQtII l4OVpDdS4hxmg== Date: Mon, 18 Sep 2023 15:36:39 +0100 From: Lee Jones To: Rob Herring Cc: linux-kernel@vger.kernel.org, Linus Walleij , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Conor Dooley Subject: Re: [PATCH] dt-bindings: mfd: armltd: Move Arm board syscon's to separate schema Message-ID: <20230918143639.GP13143@google.com> References: <20230915201520.4179115-1-robh@kernel.org> <169481377499.149218.2656119781038291714.robh@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <169481377499.149218.2656119781038291714.robh@kernel.org> On Fri, 15 Sep 2023, Rob Herring wrote: > > On Fri, 15 Sep 2023 15:15:05 -0500, Rob Herring wrote: > > The Arm Ltd board bindings are a bit unusual in that they define child > > nodes for various syscon's. The schemas are also incomplete as they lack > > constraints on having additional properties and some properties are > > missing. As the bindings for the different platforms only vary by > > compatibles, combine them into a single schema doc. > > > > Add the "arm,im-pd1-syscon" compatible which was not documented. Add > > "ranges", "#address-cells", and "#size-cells properties which were > > missing. > > > > Signed-off-by: Rob Herring > > --- > > .../bindings/arm/arm,integrator.yaml | 39 ----------- > > .../devicetree/bindings/arm/arm,realview.yaml | 37 ---------- > > .../bindings/arm/arm,versatile.yaml | 40 +++-------- > > .../mfd/arm,dev-platforms-syscon.yaml | 67 +++++++++++++++++++ > > 4 files changed, 75 insertions(+), 108 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/mfd/arm,dev-platforms-syscon.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): Errr ... I'm a little torn. Do I trust the maintainer or his bot? :) > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/register-bit-led.example.dtb: syscon@10000000: compatible: 'oneOf' conditional failed, one must be fixed: > ['arm,realview-pb1176-syscon', 'syscon'] is too short > 'arm,realview-pb1176-syscon' is not one of ['arm,integrator-ap-syscon', 'arm,integrator-cp-syscon', 'arm,integrator-sp-syscon', 'arm,im-pd1-syscon'] > 'arm,realview-pb1176-syscon' is not one of ['arm,realview-eb11mp-revb-syscon', 'arm,realview-eb11mp-revc-syscon'] > 'arm,realview-eb-syscon' was expected > from schema $id: http://devicetree.org/schemas/mfd/arm,dev-platforms-syscon.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230915201520.4179115-1-robh@kernel.org > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > -- Lee Jones [李琼斯]