Re: [PATCH v4 4/4] firmware: arm_scmi: Add qcom hvc/shmem transport support

Nikunj Kela
2023-10-02T18:45:29Z

On 10/2/2023 11:39 AM, Brian Masney wrote:
> On Mon, Oct 02, 2023 at 02:34:06PM -0400, Brian Masney wrote:
>> On Mon, Sep 11, 2023 at 12:43:59PM -0700, Nikunj Kela wrote:
>>> + func_id = readl((void __iomem *)(scmi_info->shmem) + size - 16);
>>> +#ifdef CONFIG_ARM64
>>> + cap_id = readq((void __iomem *)(scmi_info->shmem) + size - 8);
>>> +#else
>>> + /* capability-id is 32 bit wide on 32bit machines */
>>> + cap_id = readl((void __iomem *)(scmi_info->shmem) + size - 8);
>>> +#endif
>> The 32 bit case is defined as a u64 in two places above.
> Also should the 32 bit case be 'size - 4' instead of 'size - 8'? Sorry
> I just noticed that as soon as I pressed send.
>
> Brian

I already addressed this in one of your previous comments. We are
keeping last 16 bytes reserved for these two parameters regardless of
the architecture.