From: Rob Herring <robh@kernel.org>
To: Wesley Cheng <quic_wcheng@quicinc.com>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
mathias.nyman@intel.com, gregkh@linuxfoundation.org,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, agross@kernel.org, andersson@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
srinivas.kandagatla@linaro.org, bgoswami@quicinc.com,
Thinh.Nguyen@synopsys.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, alsa-devel@alsa-project.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v6 13/33] dt-bindings: usb: dwc3: Add snps,num-hc-interrupters definition
Date: Mon, 18 Sep 2023 15:19:19 -0500 [thread overview]
Message-ID: <20230918201919.GA1694628-robh@kernel.org> (raw)
In-Reply-To: <ef3731af-5b58-3dcb-9a6f-7e8755a13895@quicinc.com>
On Fri, Sep 15, 2023 at 05:43:45PM -0700, Wesley Cheng wrote:
> Hi Konrad,
>
> On 9/15/2023 5:35 PM, Konrad Dybcio wrote:
> > On 16.09.2023 02:10, Wesley Cheng wrote:
> > > Add a new definition for specifying how many XHCI secondary interrupters
> > > can be allocated. XHCI in general can potentially support up to 1024
> > > interrupters, which some uses may want to limit depending on how many
> > > users utilize the interrupters.
> > >
> > > Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
> > > ---
> > Any reason for a DWC3-specific property? Why not just
> > use the XHCI-common one from patch 14 and error out if
> > a value of more than 8 is found?
> >
I'm pretty sure I said use the common one already...
>
> Not every XHCI plat user is going to be DWC3. In case DWC3 is used, the
> DWC3 host driver is the one that populates and adds the XHCI plat device (no
> separate device node for XHCI), so that requires the DWC3 host to also
> populate properties for the XHCI device. (dwc3_host_init())
This binding references usb-xhci.yaml already, so any property from
there is allowed. Linux needs to handle that regardless of what the
driver structure/division looks like.
Rob
next prev parent reply other threads:[~2023-09-18 20:19 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 0:09 [PATCH v6 00/33] Introduce QC USB SND audio offloading support Wesley Cheng
2023-09-16 0:09 ` [PATCH v6 01/33] xhci: add support to allocate several interrupters Wesley Cheng
2023-09-16 0:09 ` [PATCH v6 02/33] xhci: add helper to stop endpoint and wait for completion Wesley Cheng
2023-09-16 0:09 ` [PATCH v6 03/33] xhci: sideband: add initial api to register a sideband entity Wesley Cheng
2023-09-16 0:09 ` [PATCH v6 04/33] usb: host: xhci-mem: Cleanup pending secondary event ring events Wesley Cheng
2023-09-16 0:09 ` [PATCH v6 05/33] usb: host: xhci-mem: Allow for interrupter clients to choose specific index Wesley Cheng
2023-09-16 0:09 ` [PATCH v6 06/33] ASoC: Add SOC USB APIs for adding an USB backend Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 07/33] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: Add USB_RX port Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 08/33] ASoC: qcom: qdsp6: Introduce USB AFE port to q6dsp Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 09/33] ASoC: qdsp6: q6afe: Increase APR timeout Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 10/33] ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6 Wesley Cheng
2023-09-16 0:34 ` Konrad Dybcio
2023-09-16 1:16 ` Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 11/33] ALSA: usb-audio: Introduce USB SND platform op callbacks Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 12/33] ALSA: usb-audio: Export USB SND APIs for modules Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 13/33] dt-bindings: usb: dwc3: Add snps,num-hc-interrupters definition Wesley Cheng
2023-09-16 0:35 ` Konrad Dybcio
2023-09-16 0:43 ` Wesley Cheng
2023-09-18 20:19 ` Rob Herring [this message]
2023-09-19 0:23 ` Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 14/33] dt-bindings: usb: xhci: Add num-hc-interrupters definition Wesley Cheng
2023-09-18 20:19 ` Rob Herring
2023-09-16 0:10 ` [PATCH v6 15/33] usb: dwc3: Add DT parameter to specify maximum number of interrupters Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 16/33] usb: host: xhci-plat: Set XHCI max interrupters if property is present Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 17/33] ALSA: usb-audio: qcom: Add USB QMI definitions Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 18/33] ALSA: usb-audio: qcom: Introduce QC USB SND offloading support Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 19/33] ALSA: usb-audio: Check for support for requested audio format Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 20/33] ASoC: usb: Add PCM format check API for USB backend Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 21/33] ASoC: qcom: qdsp6: Ensure PCM format is supported by USB audio device Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 22/33] ALSA: usb-audio: Prevent starting of audio stream if in use Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 23/33] ASoC: dt-bindings: Add Q6USB backend Wesley Cheng
2023-09-16 0:37 ` Konrad Dybcio
2023-09-16 0:46 ` Wesley Cheng
2023-09-16 2:36 ` Rob Herring
2023-09-16 0:10 ` [PATCH v6 24/33] ASoC: dt-bindings: Update example for enabling USB offload on SM8250 Wesley Cheng
2023-09-16 2:36 ` Rob Herring
2023-09-16 0:10 ` [PATCH v6 25/33] ASoC: qcom: qdsp6: q6afe: Split USB AFE dev_token param into separate API Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 26/33] ALSA: usb-audio: qcom: Populate PCM and USB chip information Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 27/33] ASoC: qcom: qdsp6: Add support to track available USB PCM devices Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 28/33] ASoC: qcom: qdsp6: Add SND kcontrol to select offload device Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 29/33] ASoC: qcom: qdsp6: Add SND kcontrol for fetching offload status Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 30/33] ASoC: qcom: qdsp6: Add headphone jack for offload connection status Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 31/33] ALSA: usb-audio: qcom: Use card and PCM index from QMI request Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 32/33] ALSA: usb-audio: Allow for rediscovery of connected USB SND devices Wesley Cheng
2023-09-16 0:10 ` [PATCH v6 33/33] ASoC: usb: Rediscover USB SND devices on USB port add Wesley Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918201919.GA1694628-robh@kernel.org \
--to=robh@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=perex@perex.cz \
--cc=quic_wcheng@quicinc.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).