From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70F9628DB2 for ; Mon, 18 Sep 2023 21:33:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B348C433C8; Mon, 18 Sep 2023 21:33:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695072826; bh=HJnD3hDCAKtTDtsEuzBCabBIEMAOgegcnbNytmQ7rTk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o/lXBeKiRldFnvNecwB87VK4iPzybzfdxFTpW7N7DEWOG0ePMwhWA1QBHQj7CZmOE rwJzCyjXxuHxmWV776xSnXJnCwS1Y0dtd49ta/JFo05fQvVVmUH9rfpcqiiHynzYD0 flE5SBBnlLaWbqmFb7RF8ps2D0Ihih5XNYo3kHtAHgWRfOaX8wu1HaIhcdh0iLlGUY KabrMyZUZcxyjJ9ucBFNbR4CiTALYZUcRIrBfnguxGFT2r2Y8y5skAJRpyLr+U9nqZ Vqe8hmZXeZDTvMroRHiK3s4IbOQCqckidhK+CPVHdLxFVrKwD6eqW0HmNH4e3LiZ6Z RVzOdVIeBJsIQ== Received: (nullmailer pid 1791762 invoked by uid 1000); Mon, 18 Sep 2023 21:33:28 -0000 Date: Mon, 18 Sep 2023 16:33:28 -0500 From: Rob Herring To: Kwanghoon Son Cc: p.zabel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jszhang@kernel.org, guoren@kernel.org, wefu@redhat.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, inki.dae@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v3 1/3] dt-bindings: reset: Document th1520 reset control Message-ID: <20230918213328.GA1771303-robh@kernel.org> References: <20230918045125.4000083-1-k.son@samsung.com> <20230918045125.4000083-2-k.son@samsung.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230918045125.4000083-2-k.son@samsung.com> On Mon, Sep 18, 2023 at 04:51:23AM +0000, Kwanghoon Son wrote: > Add documentation to describe th1520 reset device > > Signed-off-by: Kwanghoon Son > --- > .../bindings/reset/thead,th1520-reset.yaml | 44 +++++++++++++++++++ > .../dt-bindings/reset/thead,th1520-reset.h | 9 ++++ > 2 files changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml > create mode 100644 include/dt-bindings/reset/thead,th1520-reset.h > > diff --git a/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml > new file mode 100644 > index 000000000000..49ea8c6a331f > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/thead,th1520-reset.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: T-HEAD th1520 SoC Reset Controller > + > +maintainers: > + - Kwanghoon Son > + > +properties: > + compatible: > + items: > + - const: thead,th1520-reset > + - const: syscon Why do you need "syscon"? Are there other functions? If so, please describe them in top-level "description". If not, drop "syscon" and use device_node_to_regmap() instead of syscon_node_to_regmap(). Rob