Re: [PATCH v4 3/7] dt-bindings: hwmon: Add possible new properties to max31827 bindings

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3376 bytes --]

Hey,

On Tue, Sep 19, 2023 at 12:34:51PM +0300, Daniel Matyas wrote:
> These modify the corresponding bits in the configuration register.
> 
> adi,comp-int is a hardware property, because it affects the behavior
> of the interrupt signal and whatever it is connected to.
> 
> adi,timeout-enable is a hardware property, because it affects i2c
> bus operation.
> 
> Signed-off-by: Daniel Matyas <daniel.matyas@analog.com>

Thanks for the updates. This looks okay to me now.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
> 
> v3 -> v4: Changed property names (adi,flt-q = adi,fault-q; adi,alrm-pol
> = adi,alarm-pol). Expressed default values in binding.
> 
> v2 -> v3: Changed commit subject and message
> 
> v1 -> v2: Added adi,timeout-enable property to binding. Fixed
> dt_binding_check errors.
> 
>  .../bindings/hwmon/adi,max31827.yaml          | 66 +++++++++++++++++++
>  1 file changed, 66 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> index 2dc8b07b4d3b..f60e06ab7d0a 100644
> --- a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> @@ -32,6 +32,68 @@ properties:
>        Must have values in the interval (1.6V; 3.6V) in order for the device to
>        function correctly.
>  
> +  adi,comp-int:
> +    description:
> +      If present interrupt mode is used. If not present comparator mode is used
> +      (default).
> +    type: boolean
> +
> +  adi,alarm-pol:
> +    description:
> +      Sets the alarms active state.
> +            - 0 = active low
> +            - 1 = active high
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [0, 1]
> +
> +  adi,fault-q:
> +    description:
> +      Select how many consecutive temperature faults must occur before
> +      overtemperature or undertemperature faults are indicated in the
> +      corresponding status bits.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [1, 2, 4, 8]
> +
> +  adi,timeout-enable:
> +    description:
> +      Enables timeout. Bus timeout resets the I2C-compatible interface when SCL
> +      is low for more than 30ms (nominal).
> +    type: boolean
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: adi,max31829
> +
> +    then:
> +      properties:
> +        adi,alarm-pol:
> +          default: 1
> +
> +    else:
> +      properties:
> +        adi,alarm-pol:
> +          default: 0
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: adi,max31827
> +
> +    then:
> +      properties:
> +        adi,fault-q:
> +          default: 1
> +
> +    else:
> +      properties:
> +        adi,fault-q:
> +          default: 4
> +
> +
>  required:
>    - compatible
>    - reg
> @@ -49,6 +111,10 @@ examples:
>              compatible = "adi,max31827";
>              reg = <0x42>;
>              vref-supply = <&reg_vdd>;
> +            adi,comp-int;
> +            adi,alarm-pol = <0>;
> +            adi,fault-q = <1>;
> +            adi,timeout-enable;
>          };
>      };
>  ...
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]