* [PATCH] arm64: dts: ti: k3-am654-base-board: Add I2C I/O expander
@ 2023-09-19 5:03 Ravi Gunasekaran
2023-09-19 12:21 ` Andrew Davis
0 siblings, 1 reply; 3+ messages in thread
From: Ravi Gunasekaran @ 2023-09-19 5:03 UTC (permalink / raw)
To: nm, vigneshr
Cc: kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-arm-kernel, devicetree, linux-kernel, r-gunasekaran
AM654 baseboard has two TCA9554 I/O expander on the WKUP_I2C0 bus.
The expander at address 0x38 is used to detect daughter cards.
Add a node for this I/O expander.
Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
---
arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
index f5c26e9fba98..035b20386ef3 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
@@ -381,6 +381,13 @@
interrupt-controller;
#interrupt-cells = <2>;
};
+
+ pca9554_1: gpio@38 {
+ compatible = "nxp,pca9554";
+ reg = <0x38>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
};
&mcu_i2c0 {
base-commit: dfa449a58323de195773cf928d99db4130702bf7
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am654-base-board: Add I2C I/O expander
2023-09-19 5:03 [PATCH] arm64: dts: ti: k3-am654-base-board: Add I2C I/O expander Ravi Gunasekaran
@ 2023-09-19 12:21 ` Andrew Davis
2023-09-20 4:17 ` Ravi Gunasekaran
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Davis @ 2023-09-19 12:21 UTC (permalink / raw)
To: Ravi Gunasekaran, nm, vigneshr
Cc: kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-arm-kernel, devicetree, linux-kernel
On 9/19/23 12:03 AM, Ravi Gunasekaran wrote:
> AM654 baseboard has two TCA9554 I/O expander on the WKUP_I2C0 bus.
> The expander at address 0x38 is used to detect daughter cards.
> Add a node for this I/O expander.
>
> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index f5c26e9fba98..035b20386ef3 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -381,6 +381,13 @@
> interrupt-controller;
> #interrupt-cells = <2>;
> };
> +
> + pca9554_1: gpio@38 {
As this is at a lower address than the other expander(39), why
not put it before that one to keep these in order?
Also, do you need the label(pca9554_1:) for anything, if not
drop it for now.
Andrew
> + compatible = "nxp,pca9554";
> + reg = <0x38>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> };
>
> &mcu_i2c0 {
>
> base-commit: dfa449a58323de195773cf928d99db4130702bf7
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am654-base-board: Add I2C I/O expander
2023-09-19 12:21 ` Andrew Davis
@ 2023-09-20 4:17 ` Ravi Gunasekaran
0 siblings, 0 replies; 3+ messages in thread
From: Ravi Gunasekaran @ 2023-09-20 4:17 UTC (permalink / raw)
To: Andrew Davis, nm, vigneshr
Cc: kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-arm-kernel, devicetree, linux-kernel
On 9/19/23 5:51 PM, Andrew Davis wrote:
> On 9/19/23 12:03 AM, Ravi Gunasekaran wrote:
>> AM654 baseboard has two TCA9554 I/O expander on the WKUP_I2C0 bus.
>> The expander at address 0x38 is used to detect daughter cards.
>> Add a node for this I/O expander.
>>
>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> index f5c26e9fba98..035b20386ef3 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
>> @@ -381,6 +381,13 @@
>> interrupt-controller;
>> #interrupt-cells = <2>;
>> };
>> +
>> + pca9554_1: gpio@38 {
>
> As this is at a lower address than the other expander(39), why
> not put it before that one to keep these in order?
Sure. I will reorder the placement of nodes.
>
> Also, do you need the label(pca9554_1:) for anything, if not
> drop it for now.
The label is not needed at the moment. I will drop the label.
Thanks for reviewing the patch. I will make the changes and post v2.
>
> Andrew
>
>> + compatible = "nxp,pca9554";
>> + reg = <0x38>;
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + };
>> };
>> &mcu_i2c0 {
>>
>> base-commit: dfa449a58323de195773cf928d99db4130702bf7
--
Regards,
Ravi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-20 4:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-19 5:03 [PATCH] arm64: dts: ti: k3-am654-base-board: Add I2C I/O expander Ravi Gunasekaran
2023-09-19 12:21 ` Andrew Davis
2023-09-20 4:17 ` Ravi Gunasekaran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).