From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5751210FA for ; Tue, 19 Sep 2023 07:51:44 +0000 (UTC) Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8C4E118 for ; Tue, 19 Sep 2023 00:51:41 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-50309daf971so3875859e87.3 for ; Tue, 19 Sep 2023 00:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1695109900; x=1695714700; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jJJ+ExGDq2qJY2oh7GX6hGXNvvX2A2vHJTOyygLjZbc=; b=M3F1MfW96O3rq3x6pfz6sCwZx7Vl2xhdMt5/5NSbtpg99rHi0yjmGK7SuaIWQqigth YxbOt+/RAEfwYKbcOwF6X+12+FesDYARCKB+NmCov47lvdgJnPHi9guRl+Izfmqy4cKe kdBNjUMFEF73d7y5IpxW5nYUGvmsCUNAyrwg9y3sEhQTUlYfNoc1eEJlKKxzp8gQyfjp qdm9lJwd3qCJeDUtnLD088Vo82ScrAHEnKNc9zx+skGU72AABXCOoQEZQQqNZEhJu19Q 7qAiOO2GXdhWuqb3PaVWe0b1Qdr8XAuGx+K7IAcIBWCipPF1FVyJfphOSFv3EMK9vPbO B7rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695109900; x=1695714700; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jJJ+ExGDq2qJY2oh7GX6hGXNvvX2A2vHJTOyygLjZbc=; b=WXzc7MZoYIe8rwSZm+j2i8/pf+BTMTL0HwNkYwuxrHLXnWcMFY/JHCchR95YdPkYL8 0DOA5RHkETc/5mDwhncb+PQpgl7nzg3pKECpIF6cjBv7Px9chDdf529Ga6furZZ5PVxt zGrQrs3eB0EUBM6dw5yrbfWqWdUNZJ46LYqeMK04kywCdB1UGcrpv1WxtpY8h6xpD3+2 JDKB+GxEIyJKMerzlCrc6hmL9rKWwDn66m3EbWs4a8cRONIgjdhccXQrUpv5VX/idOof WHMVxjTfT1TFzQ98Ox1enO6lvdmFFIaCPOCXIh9h4n/P2ym3PpKfRg5c43u7n3X1Trvy BNzA== X-Gm-Message-State: AOJu0YwIAskM44XNWrwR1B9ZVLa7nar0u3rYnO1gNPFqYaDIYxYK1VXp CIZ1vTbzzCJTE6OIJ7Iljo3zyQ== X-Google-Smtp-Source: AGHT+IGlC4djVRlztv+UBXuAX08zNkXqe9RsFK4tYVhjdRu422bJuqs+VAB3LAmUEnlTXVQgcDLZ3A== X-Received: by 2002:ac2:4d8b:0:b0:502:ab7b:e477 with SMTP id g11-20020ac24d8b000000b00502ab7be477mr9978897lfe.53.1695109899530; Tue, 19 Sep 2023 00:51:39 -0700 (PDT) Received: from blmsp ([2001:4091:a246:8222:dbda:9cd9:39cc:f174]) by smtp.gmail.com with ESMTPSA id e20-20020a056402149400b0052e1783ab25sm7061842edv.70.2023.09.19.00.51.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 00:51:38 -0700 (PDT) Date: Tue, 19 Sep 2023 09:51:35 +0200 From: Markus Schneider-Pargmann To: Sean Anderson Cc: Wolfgang Grandegger , Marc Kleine-Budde , Rob Herring , Krzysztof Kozlowski , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Conor Dooley , Chandrasekar Ramakrishnan , Michal Kubiak , Vivek Yadav , linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Simon Horman Subject: Re: [PATCH v3 5/6] can: tcan4x5x: Add support for tcan4552/4553 Message-ID: <20230919075135.7xim2yjwt5jna4sy@blmsp> References: <20230721135009.1120562-1-msp@baylibre.com> <20230721135009.1120562-6-msp@baylibre.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Hi Sean, On Fri, Sep 15, 2023 at 11:36:49AM -0400, Sean Anderson wrote: > On 7/21/23 09:50, Markus Schneider-Pargmann wrote: > > +static const struct tcan4x5x_version_info tcan4x5x_versions[] = { > > + [TCAN4552] = { > > + .name = "4552", > > + .id2_register = 0x32353534, > > + }, > > + [TCAN4553] = { > > + .name = "4553", > > + .id2_register = 0x32353534, > > Should this be 0x33353534? Thank you for noticing! Yes. Probably slipped through in the last refactoring. I will send a fix. Best, Markus