* [PATCH v2 2/2] arm64: dts: imx8qxp: add adma_pwm in adma
2023-04-24 8:21 [PATCH v2 1/2] dt-bindings: pwm: imx: add i.MX8QXP compatible Alexander Stein
@ 2023-04-24 8:21 ` Alexander Stein
2023-05-31 7:55 ` Alexander Stein
2023-06-04 9:50 ` Shawn Guo
2023-04-24 10:10 ` [PATCH v2 1/2] dt-bindings: pwm: imx: add i.MX8QXP compatible Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Alexander Stein @ 2023-04-24 8:21 UTC (permalink / raw)
To: Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Fabio Estevam,
Philipp Zabel
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
linux-pwm, devicetree, linux-arm-kernel
Add PWM device and the corresponding clock gating device in adma subsystem.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
* New in v2
.../arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 25 +++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
index 2dce8f2ee3ea..7d5f96c99020 100644
--- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
@@ -124,6 +124,19 @@ lpuart3: serial@5a090000 {
status = "disabled";
};
+ adma_pwm: pwm@5a190000 {
+ compatible = "fsl,imx8qxp-pwm", "fsl,imx27-pwm";
+ reg = <0x5a190000 0x1000>;
+ interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&adma_pwm_lpcg 1>,
+ <&adma_pwm_lpcg 0>;
+ clock-names = "ipg", "per";
+ assigned-clocks = <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>;
+ assigned-clock-rates = <24000000>;
+ #pwm-cells = <2>;
+ power-domains = <&pd IMX_SC_R_LCD_0_PWM_0>;
+ };
+
spi0_lpcg: clock-controller@5a400000 {
compatible = "fsl,imx8qxp-lpcg";
reg = <0x5a400000 0x10000>;
@@ -220,6 +233,18 @@ uart3_lpcg: clock-controller@5a490000 {
power-domains = <&pd IMX_SC_R_UART_3>;
};
+ adma_pwm_lpcg: clock-controller@5a590000 {
+ compatible = "fsl,imx8qxp-lpcg";
+ reg = <0x5a590000 0x10000>;
+ #clock-cells = <1>;
+ clocks = <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>,
+ <&dma_ipg_clk>;
+ clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>;
+ clock-output-names = "adma_pwm_lpcg_clk",
+ "adma_pwm_lpcg_ipg_clk";
+ power-domains = <&pd IMX_SC_R_LCD_0_PWM_0>;
+ };
+
i2c0: i2c@5a800000 {
reg = <0x5a800000 0x4000>;
interrupts = <GIC_SPI 220 IRQ_TYPE_LEVEL_HIGH>;
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 2/2] arm64: dts: imx8qxp: add adma_pwm in adma
2023-04-24 8:21 ` [PATCH v2 2/2] arm64: dts: imx8qxp: add adma_pwm in adma Alexander Stein
@ 2023-05-31 7:55 ` Alexander Stein
2023-06-04 9:50 ` Shawn Guo
1 sibling, 0 replies; 9+ messages in thread
From: Alexander Stein @ 2023-05-31 7:55 UTC (permalink / raw)
To: Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Fabio Estevam,
Philipp Zabel
Cc: Pengutronix Kernel Team, NXP Linux Team, linux-pwm, devicetree,
linux-arm-kernel
Hi,
Am Montag, 24. April 2023, 10:21:08 CEST schrieb Alexander Stein:
> Add PWM device and the corresponding clock gating device in adma subsystem.
Gentle ping.
Best regards,
Alexander
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> * New in v2
>
> .../arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi index
> 2dce8f2ee3ea..7d5f96c99020 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> @@ -124,6 +124,19 @@ lpuart3: serial@5a090000 {
> status = "disabled";
> };
>
> + adma_pwm: pwm@5a190000 {
> + compatible = "fsl,imx8qxp-pwm", "fsl,imx27-pwm";
> + reg = <0x5a190000 0x1000>;
> + interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&adma_pwm_lpcg 1>,
> + <&adma_pwm_lpcg 0>;
> + clock-names = "ipg", "per";
> + assigned-clocks = <&clk IMX_SC_R_LCD_0_PWM_0
IMX_SC_PM_CLK_PER>;
> + assigned-clock-rates = <24000000>;
> + #pwm-cells = <2>;
> + power-domains = <&pd IMX_SC_R_LCD_0_PWM_0>;
> + };
> +
> spi0_lpcg: clock-controller@5a400000 {
> compatible = "fsl,imx8qxp-lpcg";
> reg = <0x5a400000 0x10000>;
> @@ -220,6 +233,18 @@ uart3_lpcg: clock-controller@5a490000 {
> power-domains = <&pd IMX_SC_R_UART_3>;
> };
>
> + adma_pwm_lpcg: clock-controller@5a590000 {
> + compatible = "fsl,imx8qxp-lpcg";
> + reg = <0x5a590000 0x10000>;
> + #clock-cells = <1>;
> + clocks = <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>,
> + <&dma_ipg_clk>;
> + clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>;
> + clock-output-names = "adma_pwm_lpcg_clk",
> + "adma_pwm_lpcg_ipg_clk";
> + power-domains = <&pd IMX_SC_R_LCD_0_PWM_0>;
> + };
> +
> i2c0: i2c@5a800000 {
> reg = <0x5a800000 0x4000>;
> interrupts = <GIC_SPI 220 IRQ_TYPE_LEVEL_HIGH>;
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 2/2] arm64: dts: imx8qxp: add adma_pwm in adma
2023-04-24 8:21 ` [PATCH v2 2/2] arm64: dts: imx8qxp: add adma_pwm in adma Alexander Stein
2023-05-31 7:55 ` Alexander Stein
@ 2023-06-04 9:50 ` Shawn Guo
2023-08-17 8:03 ` Alexander Stein
1 sibling, 1 reply; 9+ messages in thread
From: Shawn Guo @ 2023-06-04 9:50 UTC (permalink / raw)
To: Alexander Stein
Cc: Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Sascha Hauer, Fabio Estevam, Philipp Zabel,
Pengutronix Kernel Team, NXP Linux Team, linux-pwm, devicetree,
linux-arm-kernel
On Mon, Apr 24, 2023 at 10:21:08AM +0200, Alexander Stein wrote:
> Add PWM device and the corresponding clock gating device in adma subsystem.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Looks good to me. I will pick it up after dt-bindings one gets
accepted/picked first.
Shawn
> ---
> * New in v2
>
> .../arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> index 2dce8f2ee3ea..7d5f96c99020 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> @@ -124,6 +124,19 @@ lpuart3: serial@5a090000 {
> status = "disabled";
> };
>
> + adma_pwm: pwm@5a190000 {
> + compatible = "fsl,imx8qxp-pwm", "fsl,imx27-pwm";
> + reg = <0x5a190000 0x1000>;
> + interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&adma_pwm_lpcg 1>,
> + <&adma_pwm_lpcg 0>;
> + clock-names = "ipg", "per";
> + assigned-clocks = <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>;
> + assigned-clock-rates = <24000000>;
> + #pwm-cells = <2>;
> + power-domains = <&pd IMX_SC_R_LCD_0_PWM_0>;
> + };
> +
> spi0_lpcg: clock-controller@5a400000 {
> compatible = "fsl,imx8qxp-lpcg";
> reg = <0x5a400000 0x10000>;
> @@ -220,6 +233,18 @@ uart3_lpcg: clock-controller@5a490000 {
> power-domains = <&pd IMX_SC_R_UART_3>;
> };
>
> + adma_pwm_lpcg: clock-controller@5a590000 {
> + compatible = "fsl,imx8qxp-lpcg";
> + reg = <0x5a590000 0x10000>;
> + #clock-cells = <1>;
> + clocks = <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>,
> + <&dma_ipg_clk>;
> + clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>;
> + clock-output-names = "adma_pwm_lpcg_clk",
> + "adma_pwm_lpcg_ipg_clk";
> + power-domains = <&pd IMX_SC_R_LCD_0_PWM_0>;
> + };
> +
> i2c0: i2c@5a800000 {
> reg = <0x5a800000 0x4000>;
> interrupts = <GIC_SPI 220 IRQ_TYPE_LEVEL_HIGH>;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 2/2] arm64: dts: imx8qxp: add adma_pwm in adma
2023-06-04 9:50 ` Shawn Guo
@ 2023-08-17 8:03 ` Alexander Stein
2023-09-19 12:17 ` Shawn Guo
0 siblings, 1 reply; 9+ messages in thread
From: Alexander Stein @ 2023-08-17 8:03 UTC (permalink / raw)
To: Shawn Guo
Cc: Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Sascha Hauer, Fabio Estevam, Philipp Zabel,
Pengutronix Kernel Team, NXP Linux Team, linux-pwm, devicetree,
linux-arm-kernel
Hi Shawn,
Am Sonntag, 4. Juni 2023, 11:50:38 CEST schrieb Shawn Guo:
> On Mon, Apr 24, 2023 at 10:21:08AM +0200, Alexander Stein wrote:
> > Add PWM device and the corresponding clock gating device in adma
> > subsystem.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>
> Looks good to me. I will pick it up after dt-bindings one gets
> accepted/picked first.
Did this get missed accidentally? Patch 1 was picked by Thierry already.
Best regards,
Alexander
> Shawn
>
> > ---
> > * New in v2
> >
> > .../arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 25 +++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi index
> > 2dce8f2ee3ea..7d5f96c99020 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> > @@ -124,6 +124,19 @@ lpuart3: serial@5a090000 {
> >
> > status = "disabled";
> >
> > };
> >
> > + adma_pwm: pwm@5a190000 {
> > + compatible = "fsl,imx8qxp-pwm", "fsl,imx27-pwm";
> > + reg = <0x5a190000 0x1000>;
> > + interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&adma_pwm_lpcg 1>,
> > + <&adma_pwm_lpcg 0>;
> > + clock-names = "ipg", "per";
> > + assigned-clocks = <&clk IMX_SC_R_LCD_0_PWM_0
IMX_SC_PM_CLK_PER>;
> > + assigned-clock-rates = <24000000>;
> > + #pwm-cells = <2>;
> > + power-domains = <&pd IMX_SC_R_LCD_0_PWM_0>;
> > + };
> > +
> >
> > spi0_lpcg: clock-controller@5a400000 {
> >
> > compatible = "fsl,imx8qxp-lpcg";
> > reg = <0x5a400000 0x10000>;
> >
> > @@ -220,6 +233,18 @@ uart3_lpcg: clock-controller@5a490000 {
> >
> > power-domains = <&pd IMX_SC_R_UART_3>;
> >
> > };
> >
> > + adma_pwm_lpcg: clock-controller@5a590000 {
> > + compatible = "fsl,imx8qxp-lpcg";
> > + reg = <0x5a590000 0x10000>;
> > + #clock-cells = <1>;
> > + clocks = <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>,
> > + <&dma_ipg_clk>;
> > + clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>;
> > + clock-output-names = "adma_pwm_lpcg_clk",
> > + "adma_pwm_lpcg_ipg_clk";
> > + power-domains = <&pd IMX_SC_R_LCD_0_PWM_0>;
> > + };
> > +
> >
> > i2c0: i2c@5a800000 {
> >
> > reg = <0x5a800000 0x4000>;
> > interrupts = <GIC_SPI 220 IRQ_TYPE_LEVEL_HIGH>;
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 2/2] arm64: dts: imx8qxp: add adma_pwm in adma
2023-08-17 8:03 ` Alexander Stein
@ 2023-09-19 12:17 ` Shawn Guo
0 siblings, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2023-09-19 12:17 UTC (permalink / raw)
To: Alexander Stein
Cc: Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Sascha Hauer, Fabio Estevam, Philipp Zabel,
Pengutronix Kernel Team, NXP Linux Team, linux-pwm, devicetree,
linux-arm-kernel
On Thu, Aug 17, 2023 at 10:03:20AM +0200, Alexander Stein wrote:
> Hi Shawn,
>
> Am Sonntag, 4. Juni 2023, 11:50:38 CEST schrieb Shawn Guo:
> > On Mon, Apr 24, 2023 at 10:21:08AM +0200, Alexander Stein wrote:
> > > Add PWM device and the corresponding clock gating device in adma
> > > subsystem.
> > >
> > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> >
> > Looks good to me. I will pick it up after dt-bindings one gets
> > accepted/picked first.
>
> Did this get missed accidentally? Patch 1 was picked by Thierry already.
Sorry, indeed!
Applied, thanks!
Shawn
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: pwm: imx: add i.MX8QXP compatible
2023-04-24 8:21 [PATCH v2 1/2] dt-bindings: pwm: imx: add i.MX8QXP compatible Alexander Stein
2023-04-24 8:21 ` [PATCH v2 2/2] arm64: dts: imx8qxp: add adma_pwm in adma Alexander Stein
@ 2023-04-24 10:10 ` Krzysztof Kozlowski
2023-05-31 7:59 ` Uwe Kleine-König
2023-06-23 14:51 ` (subset) " Thierry Reding
3 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-24 10:10 UTC (permalink / raw)
To: Alexander Stein, Thierry Reding, Uwe Kleine-König,
Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Fabio Estevam, Philipp Zabel
Cc: Pengutronix Kernel Team, NXP Linux Team, linux-pwm, devicetree,
linux-arm-kernel
On 24/04/2023 10:21, Alexander Stein wrote:
> i.MX8QXP compatible is missing in the list, add it.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in v2:
> * Add power-domains property
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: pwm: imx: add i.MX8QXP compatible
2023-04-24 8:21 [PATCH v2 1/2] dt-bindings: pwm: imx: add i.MX8QXP compatible Alexander Stein
2023-04-24 8:21 ` [PATCH v2 2/2] arm64: dts: imx8qxp: add adma_pwm in adma Alexander Stein
2023-04-24 10:10 ` [PATCH v2 1/2] dt-bindings: pwm: imx: add i.MX8QXP compatible Krzysztof Kozlowski
@ 2023-05-31 7:59 ` Uwe Kleine-König
2023-06-23 14:51 ` (subset) " Thierry Reding
3 siblings, 0 replies; 9+ messages in thread
From: Uwe Kleine-König @ 2023-05-31 7:59 UTC (permalink / raw)
Cc: Thierry Reding, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Fabio Estevam, Philipp Zabel, linux-pwm, devicetree,
NXP Linux Team, Pengutronix Kernel Team, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 430 bytes --]
On Mon, Apr 24, 2023 at 10:21:07AM +0200, Alexander Stein wrote:
> i.MX8QXP compatible is missing in the list, add it.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: (subset) [PATCH v2 1/2] dt-bindings: pwm: imx: add i.MX8QXP compatible
2023-04-24 8:21 [PATCH v2 1/2] dt-bindings: pwm: imx: add i.MX8QXP compatible Alexander Stein
` (2 preceding siblings ...)
2023-05-31 7:59 ` Uwe Kleine-König
@ 2023-06-23 14:51 ` Thierry Reding
3 siblings, 0 replies; 9+ messages in thread
From: Thierry Reding @ 2023-06-23 14:51 UTC (permalink / raw)
To: Uwe Kleine-König, Rob Herring, Krzysztof Kozlowski,
Shawn Guo, Sascha Hauer, Fabio Estevam, Philipp Zabel,
Alexander Stein
Cc: Pengutronix Kernel Team, NXP Linux Team, linux-pwm, devicetree,
linux-arm-kernel
On Mon, 24 Apr 2023 10:21:07 +0200, Alexander Stein wrote:
> i.MX8QXP compatible is missing in the list, add it.
>
>
Applied, thanks!
[1/2] dt-bindings: pwm: imx: add i.MX8QXP compatible
commit: c799ad062a75858e10a7626e20233e6e94dbf554
Best regards,
--
Thierry Reding <thierry.reding@gmail.com>
^ permalink raw reply [flat|nested] 9+ messages in thread