From: Andre Przywara <andre.przywara@arm.com>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Peter Rosin <peda@axentia.se>,
Sudeep Holla <sudeep.holla@arm.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Paul Barker <paul.barker@sancloud.com>,
Michal Simek <michal.simek@amd.com>,
Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] arm: dts: replace Bananapi with Banana Pi
Date: Tue, 19 Sep 2023 13:13:02 +0100 [thread overview]
Message-ID: <20230919131302.26c30a31@donnerap.manchester.arm.com> (raw)
In-Reply-To: <20230918074122.73265-1-arinc.unal@arinc9.com>
On Mon, 18 Sep 2023 10:41:22 +0300
Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
Hi,
> The brand name is Banana Pi. Replace any mention of Bananapi with Banana
> Pi.
So in general this looks fine, and the comment change is surely a
no-brainer. But I was wondering if changing the model name is something
that should be done, as there might be someone relying on that?
And if we go there: "git grep" finds a number of boards using "Bananapi",
and some others with "BananaPi", so I guess those should be changed then
as well?
Cheers,
Andre.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
> arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi | 2 +-
> arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi b/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi
> index 235994a4a2eb..ef532494fc9d 100644
> --- a/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi
> +++ b/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi
> @@ -7,7 +7,7 @@
>
> / {
> /*
> - * Bananapi M2+ v1.2 uses a GPIO line to change the effective
> + * Banana Pi BPI-M2+ v1.2 uses a GPIO line to change the effective
> * resistance on the CPU regulator's feedback pin.
> */
> reg_vdd_cpux: vdd-cpux {
> diff --git a/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts
> index a37f3fa223c7..7f0948074945 100644
> --- a/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts
> +++ b/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts
> @@ -10,7 +10,7 @@
> #include "mt6323.dtsi"
>
> / {
> - model = "Bananapi BPI-R2";
> + model = "Banana Pi BPI-R2";
> compatible = "bananapi,bpi-r2", "mediatek,mt7623";
>
> aliases {
prev parent reply other threads:[~2023-09-19 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 7:41 [PATCH] arm: dts: replace Bananapi with Banana Pi Arınç ÜNAL
2023-09-19 12:13 ` Andre Przywara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230919131302.26c30a31@donnerap.manchester.arm.com \
--to=andre.przywara@arm.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=claudiu.beznea@microchip.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jernej.skrabec@gmail.com \
--cc=jesper.nilsson@axis.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@amd.com \
--cc=paul.barker@sancloud.com \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=sudeep.holla@arm.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).