* [PATCH] arm: dts: replace Bananapi with Banana Pi
@ 2023-09-18 7:41 Arınç ÜNAL
2023-09-19 12:13 ` Andre Przywara
0 siblings, 1 reply; 2+ messages in thread
From: Arınç ÜNAL @ 2023-09-18 7:41 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Matthias Brugger, Andre Przywara,
Claudiu Beznea, Peter Rosin, Sudeep Holla, Jesper Nilsson,
Arınç ÜNAL
Cc: AngeloGioacchino Del Regno, Paul Barker, Michal Simek,
Heiko Stuebner, Rob Herring, devicetree, linux-arm-kernel,
linux-sunxi, linux-kernel, linux-mediatek
The brand name is Banana Pi. Replace any mention of Bananapi with Banana
Pi.
Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi | 2 +-
arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi b/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi
index 235994a4a2eb..ef532494fc9d 100644
--- a/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi
+++ b/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi
@@ -7,7 +7,7 @@
/ {
/*
- * Bananapi M2+ v1.2 uses a GPIO line to change the effective
+ * Banana Pi BPI-M2+ v1.2 uses a GPIO line to change the effective
* resistance on the CPU regulator's feedback pin.
*/
reg_vdd_cpux: vdd-cpux {
diff --git a/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts
index a37f3fa223c7..7f0948074945 100644
--- a/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts
+++ b/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts
@@ -10,7 +10,7 @@
#include "mt6323.dtsi"
/ {
- model = "Bananapi BPI-R2";
+ model = "Banana Pi BPI-R2";
compatible = "bananapi,bpi-r2", "mediatek,mt7623";
aliases {
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] arm: dts: replace Bananapi with Banana Pi
2023-09-18 7:41 [PATCH] arm: dts: replace Bananapi with Banana Pi Arınç ÜNAL
@ 2023-09-19 12:13 ` Andre Przywara
0 siblings, 0 replies; 2+ messages in thread
From: Andre Przywara @ 2023-09-19 12:13 UTC (permalink / raw)
To: Arınç ÜNAL
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Matthias Brugger, Claudiu Beznea,
Peter Rosin, Sudeep Holla, Jesper Nilsson,
AngeloGioacchino Del Regno, Paul Barker, Michal Simek,
Heiko Stuebner, Rob Herring, devicetree, linux-arm-kernel,
linux-sunxi, linux-kernel, linux-mediatek
On Mon, 18 Sep 2023 10:41:22 +0300
Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
Hi,
> The brand name is Banana Pi. Replace any mention of Bananapi with Banana
> Pi.
So in general this looks fine, and the comment change is surely a
no-brainer. But I was wondering if changing the model name is something
that should be done, as there might be someone relying on that?
And if we go there: "git grep" finds a number of boards using "Bananapi",
and some others with "BananaPi", so I guess those should be changed then
as well?
Cheers,
Andre.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
> arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi | 2 +-
> arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi b/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi
> index 235994a4a2eb..ef532494fc9d 100644
> --- a/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi
> +++ b/arch/arm/boot/dts/allwinner/sunxi-bananapi-m2-plus-v1.2.dtsi
> @@ -7,7 +7,7 @@
>
> / {
> /*
> - * Bananapi M2+ v1.2 uses a GPIO line to change the effective
> + * Banana Pi BPI-M2+ v1.2 uses a GPIO line to change the effective
> * resistance on the CPU regulator's feedback pin.
> */
> reg_vdd_cpux: vdd-cpux {
> diff --git a/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts
> index a37f3fa223c7..7f0948074945 100644
> --- a/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts
> +++ b/arch/arm/boot/dts/mediatek/mt7623n-bananapi-bpi-r2.dts
> @@ -10,7 +10,7 @@
> #include "mt6323.dtsi"
>
> / {
> - model = "Bananapi BPI-R2";
> + model = "Banana Pi BPI-R2";
> compatible = "bananapi,bpi-r2", "mediatek,mt7623";
>
> aliases {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-19 12:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-18 7:41 [PATCH] arm: dts: replace Bananapi with Banana Pi Arınç ÜNAL
2023-09-19 12:13 ` Andre Przywara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).