From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A67F9374F1 for ; Tue, 19 Sep 2023 13:57:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 828CEC433C7; Tue, 19 Sep 2023 13:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695131853; bh=JzZ5xVm/GZHS4DZtfSUGhjc20ZbGt4Lo8VFDz2HUIxk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aSywzAKy5EmPzI8+fCU6TCCtlQGLZbOb4hBye0ZOJsH8VQLW3Ef9YMSqIWDOe/Hwo L/KYOEBybNvB6GM2wXfXdFDGn18YM6IKJP3P0WPTEMpNiP62ikXkXJd85jNVuPv6y1 fQHS/WrOX2gXFj8GtxFBuyeMi/HLiUXOh0794bAdRC+tD0w9R1WhUJls5s81tZhwse on+DrlqqHHOEurhINMP28BbrgOC8qPtsgbNO9VljdGhaVa/s2YRpHh+RDakb23nmVd 0xoZiRaX/zCvq0rPEgPYUxheI7qgkehCxoPqaBajGdsxidvG/pgfSVQ12tgHkkG2rZ WPrNEGwetv7DA== Date: Tue, 19 Sep 2023 14:57:27 +0100 From: Lee Jones To: Chen-Yu Tsai Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Mark Brown , Zhiyong Tao , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Krzysztof Kozlowski Subject: Re: [PATCH v3 01/12] dt-bindings: mfd: mt6397: Split out compatible for MediaTek MT6366 PMIC Message-ID: <20230919135727.GS13143@google.com> References: <20230919104357.3971512-1-wenst@chromium.org> <20230919104357.3971512-2-wenst@chromium.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230919104357.3971512-2-wenst@chromium.org> Mark, Please notify me when you apply the other patches in this set and I'll come back and merge this one. On Tue, 19 Sep 2023, Chen-Yu Tsai wrote: > The MT6366 PMIC is mostly, but not fully, compatible with MT6358. It has > a different set of regulators. Specifically, it lacks the camera related > VCAM* LDOs and VLDO28, but has additional VM18, VMDDR, and VSRAM_CORE LDOs. > > The PMICs contain a chip ID register that can be used to detect which > exact model is preset, so it is possible to share a common base > compatible string. > > Add a separate compatible for the MT6366 PMIC, with a fallback to the > MT6358 PMIC. > > Fixes: 49be16305587 ("dt-bindings: mfd: Add compatible for the MediaTek MT6366 PMIC") > Signed-off-by: Chen-Yu Tsai > Acked-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/mfd/mt6397.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt > index 294693a8906c..10540aa7afa1 100644 > --- a/Documentation/devicetree/bindings/mfd/mt6397.txt > +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt > @@ -22,8 +22,9 @@ compatible: > "mediatek,mt6323" for PMIC MT6323 > "mediatek,mt6331" for PMIC MT6331 and MT6332 > "mediatek,mt6357" for PMIC MT6357 > - "mediatek,mt6358" for PMIC MT6358 and MT6366 > + "mediatek,mt6358" for PMIC MT6358 > "mediatek,mt6359" for PMIC MT6359 > + "mediatek,mt6366", "mediatek,mt6358" for PMIC MT6366 > "mediatek,mt6397" for PMIC MT6397 > > Optional subnodes: > @@ -40,6 +41,7 @@ Optional subnodes: > - compatible: "mediatek,mt6323-regulator" > see ../regulator/mt6323-regulator.txt > - compatible: "mediatek,mt6358-regulator" > + - compatible: "mediatek,mt6366-regulator", "mediatek-mt6358-regulator" > see ../regulator/mt6358-regulator.txt > - compatible: "mediatek,mt6397-regulator" > see ../regulator/mt6397-regulator.txt > -- > 2.42.0.459.ge4e396fd5e-goog > -- Lee Jones [李琼斯]