From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 604F311714 for ; Wed, 20 Sep 2023 08:52:11 +0000 (UTC) Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5301AF; Wed, 20 Sep 2023 01:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1695199930; x=1726735930; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=e0y+zzC1lKT4sTShU69YLMFMHB7gGsBqYxoxrKdJeyc=; b=Funq50FY2wq/TcmRabUc1BRvtp9CMfXFSYeGX8Nz7ERNvZCx3WVE/zGK N0aeEHbpAltxyL0zRiClDXtwxtAeMw5abNXcr+HU/1L10aGgFbhMXgy9I 3tr4DhZ1jUBdWsNFl2Thq84jrBgy1LacrPSSnL5LfWp8pFfKvzEzOsdwP 1EUkb++usfid/tZfwTI7K5APqdbM8/4bFnP9BiGZj9QSnA159PdjTWnyB l7vWVShGHv9YnIJKUbOqxK3DCSbLvxaZaxHMCVG6ReZVKSQsBb0n+Rhza BMi2gAziM0YqM1gh26Nh+3KKt3z8UDgxyZ1JkfTwRE+L7X6xW1RcDqjx9 w==; X-CSE-ConnectionGUID: 9BLpBBcZRkmEPkTUW5H17w== X-CSE-MsgGUID: O0olU429SFGVPipcG7Riew== X-ThreatScanner-Verdict: Negative X-IronPort-AV: E=Sophos;i="6.02,161,1688454000"; d="asc'?scan'208";a="5617288" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 Sep 2023 01:52:09 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.87.72) by chn-vm-ex02.mchp-main.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 20 Sep 2023 01:51:13 -0700 Received: from wendy (10.10.85.11) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 20 Sep 2023 01:51:10 -0700 Date: Wed, 20 Sep 2023 09:50:53 +0100 From: Conor Dooley To: Chen Wang CC: , , , , , , , , , , , , , , Inochi Amaoto , Chen Wang Subject: Re: [PATCH v2 06/11] dt-bindings: timer: Add Sophgo sg2042 clint Message-ID: <20230920-recount-chili-f80d5dc125e8@wendy> References: <55865e1ce40d2017f047d3a9e1a9ee30043b271f.1695189879.git.wangchen20@iscas.ac.cn> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fICEAUDlyhHZKV1g" Content-Disposition: inline In-Reply-To: <55865e1ce40d2017f047d3a9e1a9ee30043b271f.1695189879.git.wangchen20@iscas.ac.cn> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net --fICEAUDlyhHZKV1g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 20, 2023 at 02:39:39PM +0800, Chen Wang wrote: > From: Inochi Amaoto >=20 > Add two new compatible string formatted like `C9xx-clint-xxx` to identify > the timer and ipi device separately, and do not allow c900-clint as the > fallback to avoid conflict. >=20 > Signed-off-by: Inochi Amaoto > Signed-off-by: Chen Wang Have you ignored Krzysztof's comments on this? I don't see a response or a reaction to his comments about the compatibles on the last version. Additionally, where is the user for these? I don't see any drivers that actually make use of these. Why do you need to have 2 compatibles (and therefore 2 devices) for the clint? I thought the clint was a single device, of which the mtimer and mswi bits were just "features"? Having split register ranges isn't a reason to have two compatibles, so I must be missing something here... Thanks, Conor. > --- > Documentation/devicetree/bindings/timer/sifive,clint.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/= Documentation/devicetree/bindings/timer/sifive,clint.yaml > index a0185e15a42f..ae69696c5c75 100644 > --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml > +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > @@ -39,6 +39,14 @@ properties: > - allwinner,sun20i-d1-clint > - thead,th1520-clint > - const: thead,c900-clint > + - items: > + - enum: > + - sophgo,sg2042-clint-mtimer > + - const: thead,c900-clint-mtimer > + - items: > + - enum: > + - sophgo,sg2042-clint-mswi > + - const: thead,c900-clint-mswi > - items: > - const: sifive,clint0 > - const: riscv,clint0 > --=20 > 2.25.1 >=20 --fICEAUDlyhHZKV1g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZQqybQAKCRB4tDGHoIJi 0nwMAPsHcRyrWcK5/HTKz0z1+wSi6SzgoFsbknGrh6a5jYYlHgD+JU7YFyCCprIB /hGbNjowzWOK2ytKYAuzXOWtxM5cLww= =0tNZ -----END PGP SIGNATURE----- --fICEAUDlyhHZKV1g--