From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Rob Herring <robh@kernel.org>
Cc: <broonie@kernel.org>, <lgirdwood@gmail.com>,
<krzysztof.kozlowski+dt@linaro.org>,
<alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
<patches@opensource.cirrus.com>
Subject: Re: [PATCH 1/5] dt-bindings: ASoC: cirrus,cs42l43: Update a couple of default values
Date: Wed, 20 Sep 2023 08:36:47 +0000 [thread overview]
Message-ID: <20230920083647.GD103419@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20230919192302.GA51154-robh@kernel.org>
On Tue, Sep 19, 2023 at 02:23:02PM -0500, Rob Herring wrote:
> On Tue, Sep 19, 2023 at 11:31:12AM +0100, Charles Keepax wrote:
> > The bias sense is being enabled by default in the driver, and the
> > default detect time is being dropped slightly. Update the binding
> > document to match.
>
> That's not really a compatible change. If I wrote my DT expecting bias
> sense was disabled by default then the OS changes behavior, my
> platform behavior would change. Maybe that doesn't matter here? IDK.
> It's on you if this breaks anyone, so:
>
> Acked-by: Rob Herring <robh@kernel.org>
>
Yeah I appreciate that, but this should be fine, the part is very
very new. The only systems using the part are still in development.
Thanks,
Charles
next prev parent reply other threads:[~2023-09-20 8:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 10:31 [PATCH 0/5] Minor default jack pop performance updates Charles Keepax
2023-09-19 10:31 ` [PATCH 1/5] dt-bindings: ASoC: cirrus,cs42l43: Update a couple of default values Charles Keepax
2023-09-19 19:23 ` Rob Herring
2023-09-20 8:36 ` Charles Keepax [this message]
2023-09-19 10:31 ` [PATCH 2/5] ASoC: cs42l43: Lower default type detect time Charles Keepax
2023-09-19 10:31 ` [PATCH 3/5] ASoC: cs42l43: Enable bias sense by default Charles Keepax
2023-09-19 10:31 ` [PATCH 4/5] ASoC: cs42l43: Move headset bias sense enable earlier in process Charles Keepax
2023-09-19 10:31 ` [PATCH 5/5] ASoC: cs42l43: Extend timeout on bias sense timeout Charles Keepax
2023-09-21 16:30 ` [PATCH 0/5] Minor default jack pop performance updates Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230920083647.GD103419@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).