From: Conor Dooley <conor@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: serial: mxs: Fix compatible list
Date: Thu, 21 Sep 2023 10:14:49 +0100 [thread overview]
Message-ID: <20230921-75ba68806e21c96531ea2d70@fedora> (raw)
In-Reply-To: <20230921005258.184705-1-festevam@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1979 bytes --]
Yo,
On Wed, Sep 20, 2023 at 09:52:58PM -0300, Fabio Estevam wrote:
> imx28.dtsi uses the following description:
>
> compatible = "fsl,imx28-auart", "fsl,imx23-auart";
>
> Make it valid so that the following schema warning could be avoided:
Dumb question maybe, but it is not mentioned here - they are actually
compatible devices, right? I see that they have some different match
data in the driver (relating to some DMA erratum on the 23 seemingly),
so it's not immediately obvious to me.
Thanks,
Conor.
>
> imx28-apx4devkit.dtb: serial@8006a000: compatible: ['fsl,imx28-auart', 'fsl,imx23-auart'] is too long
> from schema $id: http://devicetree.org/schemas/serial/fsl-mxs-auart.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> .../devicetree/bindings/serial/fsl-mxs-auart.yaml | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/fsl-mxs-auart.yaml b/Documentation/devicetree/bindings/serial/fsl-mxs-auart.yaml
> index 6a400a5e6fc7..da032effffe6 100644
> --- a/Documentation/devicetree/bindings/serial/fsl-mxs-auart.yaml
> +++ b/Documentation/devicetree/bindings/serial/fsl-mxs-auart.yaml
> @@ -14,10 +14,13 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - fsl,imx23-auart
> - - fsl,imx28-auart
> - - alphascale,asm9260-auart
> + oneOf:
> + - const: fsl,imx23-auart
> + - const: alphascale,asm9260-auart
> + - items:
> + - enum:
> + - fsl,imx28-auart
> + - const: fsl,imx23-auart
>
> reg:
> maxItems: 1
> @@ -82,7 +85,7 @@ examples:
> };
>
> auart0: serial@8006a000 {
> - compatible = "fsl,imx28-auart";
> + compatible = "fsl,imx28-auart", "fsl,imx23-auart";
> reg = <0x8006a000 0x2000>;
> interrupts = <112>;
> dmas = <&dma_apbx 8>, <&dma_apbx 9>;
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-09-21 9:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 0:52 [PATCH] dt-bindings: serial: mxs: Fix compatible list Fabio Estevam
2023-09-21 9:14 ` Conor Dooley [this message]
2023-09-21 12:53 ` Fabio Estevam
2023-09-21 13:26 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230921-75ba68806e21c96531ea2d70@fedora \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).