Re: [PATCH v2 03/11] dt-bindings: riscv: add sophgo sg2042 bindings

Guo Ren
2023-09-20T07:43:52Z

On Wed, Sep 20, 2023 at 2:38 PM Chen Wang <unicornxw@gmail.com> wrote:
>
> Add DT binding documentation for the Sophgo SG2042 Soc [1] and the
> Milk-V Pioneer board [2].
>
> [1]: https://en.sophgo.com/product/introduce/sg2042.html
> [2]: https://milkv.io/pioneer
>
> Acked-by: Chao Wei <chao.wei@sophgo.com>
> Acked-by: Xiaoguang Xing <xiaoguang.xing@sophgo.com>
> Signed-off-by: Chen Wang <wangchen20@iscas.ac.cn>
> ---
> .../devicetree/bindings/riscv/sophgo.yaml | 28 +++++++++++++++++++
> MAINTAINERS | 7 +++++
> 2 files changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/riscv/sophgo.yaml
>
> diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> new file mode 100644
> index 000000000000..82468ae915db
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> @@ -0,0 +1,28 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/riscv/sophgo.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sophgo SoC-based boards
> +
> +maintainers:
> + - Chao Wei <chao.wei@sophgo.com>
> + - Xiaoguang Xing <xiaoguang.xing@sophgo.com>
> +
> +description:
> + Sophgo SoC-based boards
> +
> +properties:
> + $nodename:
> + const: '/'
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - milkv,pioneer
> + - const: sophgo,sg2042
> +
> +additionalProperties: true
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 90f13281d297..b74d505003e2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20063,6 +20063,13 @@ F: drivers/char/sonypi.c
> F: drivers/platform/x86/sony-laptop.c
> F: include/linux/sony-laptop.h
>
> +SOPHGO DEVICETREES
> +M: Xiaoguang Xing <xiaoguang.xing@sophgo.com>
> +M: Chao Wei <chao.wei@sophgo.com>
> +S: Maintained
> +F: Documentation/devicetree/bindings/riscv/sophgo.yaml
> +F: arch/riscv/boot/dts/sophgo/
> +
> SOUND
> M: Jaroslav Kysela <perex@perex.cz>
> M: Takashi Iwai <tiwai@suse.com>
> --
> 2.25.1
>
LGTM

Reviewed-by: Guo Ren <guoren@kernel.org>

--
Best Regards
Guo Ren