Re: [PATCH v2 08/11] serial: 8250_dw: Add Sophgo SG2042 support

Chen Wang
2023-09-20T08:06:18Z

Ren, thanks for your review.

sg2042 and jh7100 use the same uart driver and we here just want to reuse the logic from jh7100.
We don't touch jh7100 stuff, we just rename "dw8250_starfive_jh7100_data" to "dw8250_skip_set_rate_data" and make it a common data for both sg2042 and jh7100.

在 2023/9/20 15:53, Guo Ren 写道:
> On Wed, Sep 20, 2023 at 2:40 PM Chen Wang <unicornxw@gmail.com> wrote:
>> From: Emil Renner Berthing <emil.renner.berthing@canonical.com>
>>
>> Add quirk to skip setting the input clock rate for the uarts on the
>> Sophgo SG2042 SoC similar to the StarFive JH7100.
>>
>> Signed-off-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
>> Signed-off-by: Chen Wang <wangchen20@iscas.ac.cn>
>> ---
>> drivers/tty/serial/8250/8250_dw.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
>> index f4cafca1a7da..6c344877a07f 100644
>> --- a/drivers/tty/serial/8250/8250_dw.c
>> +++ b/drivers/tty/serial/8250/8250_dw.c
>> @@ -770,7 +770,7 @@ static const struct dw8250_platform_data dw8250_renesas_rzn1_data = {
>> .quirks = DW_UART_QUIRK_IS_DMA_FC,
>> };
>>
>> -static const struct dw8250_platform_data dw8250_starfive_jh7100_data = {
>> +static const struct dw8250_platform_data dw8250_skip_set_rate_data = {
>> .usr_reg = DW_UART_USR,
>> .quirks = DW_UART_QUIRK_SKIP_SET_RATE,
>> };
>> @@ -780,7 +780,8 @@ static const struct of_device_id dw8250_of_match[] = {
>> { .compatible = "cavium,octeon-3860-uart", .data = &dw8250_octeon_3860_data },
>> { .compatible = "marvell,armada-38x-uart", .data = &dw8250_armada_38x_data },
>> { .compatible = "renesas,rzn1-uart", .data = &dw8250_renesas_rzn1_data },
>> - { .compatible = "starfive,jh7100-uart", .data = &dw8250_starfive_jh7100_data },
>> + { .compatible = "sophgo,sg2042-uart", .data = &dw8250_skip_set_rate_data },
>> + { .compatible = "starfive,jh7100-uart", .data = &dw8250_skip_set_rate_data },
> Why shall we touch the jh7100 stuff in this patch?
>
>> { /* Sentinel */ }
>> };
>> MODULE_DEVICE_TABLE(of, dw8250_of_match);
>> --
>> 2.25.1
>>
>