devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: apq8016-sbc: Add missing ADV7533 regulators
@ 2023-09-22 10:49 Stephan Gerhold
  2023-09-23 19:16 ` Dmitry Baryshkov
  2023-09-28  0:34 ` Bjorn Andersson
  0 siblings, 2 replies; 3+ messages in thread
From: Stephan Gerhold @ 2023-09-22 10:49 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Andy Gross, Konrad Dybcio, Krzysztof Kozlowski, linux-arm-msm,
	devicetree, linux-kernel, Stephan Gerhold

Add the missing regulator supplies to the ADV7533 HDMI bridge to fix
the following dtbs_check warnings. They are all also supplied by
pm8916_l6 so there is no functional difference.

apq8016-sbc.dtb: bridge@39: 'dvdd-supply' is a required property
apq8016-sbc.dtb: bridge@39: 'pvdd-supply' is a required property
apq8016-sbc.dtb: bridge@39: 'a2vdd-supply' is a required property
        from schema display/bridge/adi,adv7533.yaml

Fixes: 28546b095511 ("arm64: dts: apq8016-sbc: Add HDMI display support")
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
 arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
index 3c51f891029e..9ffad7d1f2b6 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
@@ -172,6 +172,9 @@ adv_bridge: bridge@39 {
 		pd-gpios = <&tlmm 32 GPIO_ACTIVE_HIGH>;
 
 		avdd-supply = <&pm8916_l6>;
+		a2vdd-supply = <&pm8916_l6>;
+		dvdd-supply = <&pm8916_l6>;
+		pvdd-supply = <&pm8916_l6>;
 		v1p2-supply = <&pm8916_l6>;
 		v3p3-supply = <&pm8916_l17>;
 

---
base-commit: a35461d47fe3e555602912b905f1bae7045256eb
change-id: 20230922-db410c-adv7533-regulators-89a607130f1d

Best regards,
-- 
Stephan Gerhold <stephan@gerhold.net>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: apq8016-sbc: Add missing ADV7533 regulators
  2023-09-22 10:49 [PATCH] arm64: dts: qcom: apq8016-sbc: Add missing ADV7533 regulators Stephan Gerhold
@ 2023-09-23 19:16 ` Dmitry Baryshkov
  2023-09-28  0:34 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2023-09-23 19:16 UTC (permalink / raw)
  To: Stephan Gerhold
  Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Krzysztof Kozlowski,
	linux-arm-msm, devicetree, linux-kernel

On Fri, 22 Sept 2023 at 13:50, Stephan Gerhold <stephan@gerhold.net> wrote:
>
> Add the missing regulator supplies to the ADV7533 HDMI bridge to fix
> the following dtbs_check warnings. They are all also supplied by
> pm8916_l6 so there is no functional difference.
>
> apq8016-sbc.dtb: bridge@39: 'dvdd-supply' is a required property
> apq8016-sbc.dtb: bridge@39: 'pvdd-supply' is a required property
> apq8016-sbc.dtb: bridge@39: 'a2vdd-supply' is a required property
>         from schema display/bridge/adi,adv7533.yaml
>
> Fixes: 28546b095511 ("arm64: dts: apq8016-sbc: Add HDMI display support")
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
>  arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>



-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: apq8016-sbc: Add missing ADV7533 regulators
  2023-09-22 10:49 [PATCH] arm64: dts: qcom: apq8016-sbc: Add missing ADV7533 regulators Stephan Gerhold
  2023-09-23 19:16 ` Dmitry Baryshkov
@ 2023-09-28  0:34 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-09-28  0:34 UTC (permalink / raw)
  To: Stephan Gerhold
  Cc: Andy Gross, Konrad Dybcio, Krzysztof Kozlowski, linux-arm-msm,
	devicetree, linux-kernel


On Fri, 22 Sep 2023 12:49:55 +0200, Stephan Gerhold wrote:
> Add the missing regulator supplies to the ADV7533 HDMI bridge to fix
> the following dtbs_check warnings. They are all also supplied by
> pm8916_l6 so there is no functional difference.
> 
> apq8016-sbc.dtb: bridge@39: 'dvdd-supply' is a required property
> apq8016-sbc.dtb: bridge@39: 'pvdd-supply' is a required property
> apq8016-sbc.dtb: bridge@39: 'a2vdd-supply' is a required property
>         from schema display/bridge/adi,adv7533.yaml
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: apq8016-sbc: Add missing ADV7533 regulators
      commit: 33e9032a1875bb1aee3c68a4540f5a577ff44130

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-09-28  0:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-22 10:49 [PATCH] arm64: dts: qcom: apq8016-sbc: Add missing ADV7533 regulators Stephan Gerhold
2023-09-23 19:16 ` Dmitry Baryshkov
2023-09-28  0:34 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).