From: Conor Dooley <conor@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
robh+dt@kernel.org, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH 2/3] dt-bindings: pwm: mxs: Document the clocks property
Date: Fri, 22 Sep 2023 12:31:54 +0100 [thread overview]
Message-ID: <20230922-likewise-twiddling-31da746e1920@spud> (raw)
In-Reply-To: <20230921184348.290261-2-festevam@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]
On Thu, Sep 21, 2023 at 03:43:47PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The 'clocks' property is mandatory for the PWM to operate.
>
> Document it.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Documentation/devicetree/bindings/pwm/mxs-pwm.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/mxs-pwm.yaml b/Documentation/devicetree/bindings/pwm/mxs-pwm.yaml
> index 655f008081d5..8f50e23ca8c9 100644
> --- a/Documentation/devicetree/bindings/pwm/mxs-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/mxs-pwm.yaml
> @@ -25,6 +25,9 @@ properties:
> reg:
> maxItems: 1
>
> + clocks:
> + maxItems: 1
> +
> "#pwm-cells":
> const: 3
>
> @@ -35,6 +38,7 @@ properties:
> required:
> - compatible
> - reg
> + - clocks
> - fsl,pwm-number
>
> additionalProperties: false
> @@ -44,6 +48,7 @@ examples:
> pwm@80064000 {
> compatible = "fsl,imx23-pwm";
> reg = <0x80064000 0x2000>;
> + clocks = <&clks 30>;
> #pwm-cells = <3>;
> fsl,pwm-number = <8>;
> };
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-09-22 11:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 18:43 [PATCH 1/3] dt-bindings: pwm: mxs: Document fsl,imx28-pwm Fabio Estevam
2023-09-21 18:43 ` [PATCH 2/3] dt-bindings: pwm: mxs: Document the clocks property Fabio Estevam
2023-09-21 20:07 ` Uwe Kleine-König
2023-09-22 11:31 ` Conor Dooley [this message]
2023-09-21 18:43 ` [PATCH 3/3] dt-bindings: pwm: mxs: Allow passing #pwm-cells = <2> Fabio Estevam
2023-09-21 19:59 ` Uwe Kleine-König
2023-09-22 21:17 ` Rob Herring
2023-09-21 19:59 ` [PATCH 1/3] dt-bindings: pwm: mxs: Document fsl,imx28-pwm Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230922-likewise-twiddling-31da746e1920@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).