From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E6141E521 for ; Fri, 22 Sep 2023 09:57:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E69C9C433C7; Fri, 22 Sep 2023 09:57:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695376662; bh=Lfg64vDBMqqMuekyEShYM/GguXqls4PxLGqLNLeMVQU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t/RhEJc/+n34ONrY1ylE/pq0kRonnc5VfiydY7HWO0N7NLeIPD9XgdaKB7qtHPncW w/KRdPGIAAuNEyrQQMZ+W1b8CwWq2Mm7oCk155jEUQgJnIw/dAIQQufz6XX0z5FUJm j4IduZfdMbcSk22cStuwAjqbG2JFRFXzjrwPghF2COD60L6et/QMuPOaGxM22iGIoy AO/NWv/iTykwQE3Xkn+ckgNaOBkbi+Yw3D5g82qapaTx9VY7iWO0PmAh0zSmHvESv5 j3HepWM0yPGlL3F674r9723GkHHfevPS/eC8ej8KuR5Vq6+Kjm5z6MNNRlHcj+5TnT d13G5qryQ6mRA== Date: Fri, 22 Sep 2023 10:57:36 +0100 From: Conor Dooley To: Drew Fustini Cc: Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jisheng Zhang , Adrian Hunter , Guo Ren , Fu Wei , Paul Walmsley , Palmer Dabbelt , Albert Ou , Robert Nelson , Jason Kridner , Xi Ruoyao , Han Gao , Icenowy Zheng , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 1/6] dt-bindings: mmc: sdhci-of-dwcmhsc: Add T-Head TH1520 support Message-ID: <20230922-parish-ice-a22e93dc3027@spud> References: <20230921-th1520-mmc-v1-0-49f76c274fb3@baylibre.com> <20230921-th1520-mmc-v1-1-49f76c274fb3@baylibre.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eawcWMQ/3FYJXdeS" Content-Disposition: inline In-Reply-To: <20230921-th1520-mmc-v1-1-49f76c274fb3@baylibre.com> --eawcWMQ/3FYJXdeS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey Drew, On Thu, Sep 21, 2023 at 06:49:48PM -0700, Drew Fustini wrote: > Add compatible value for the T-Head TH1520 dwcmshc controller and add > thead,phy-pull-up property. >=20 > Signed-off-by: Drew Fustini > --- > Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yam= l b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > index a43eb837f8da..46b768d46712 100644 > --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > @@ -19,6 +19,7 @@ properties: > - rockchip,rk3568-dwcmshc > - rockchip,rk3588-dwcmshc > - snps,dwcmshc-sdhci > + - thead,th1520-dwcmshc > =20 > reg: > maxItems: 1 > @@ -60,6 +61,9 @@ properties: > description: Specify the number of delay for tx sampling. > $ref: /schemas/types.yaml#/definitions/uint8 > =20 > + thead,phy-pull-up: > + description: Enable weak pull-up on PHY pads > + type: boolean Why is the weak pull-up required? How would the dts author know if they need to use this property? Thanks, Conor. > =20 > required: > - compatible >=20 > --=20 > 2.34.1 >=20 --eawcWMQ/3FYJXdeS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZQ1lEAAKCRB4tDGHoIJi 0ur5AP9J83si/VNah9uXWQh6yWcqwodTBG01tc11Lr8CYSXRhAEAs3heA19N2euY iKJcToy85ytl2YnADrdTAOVK+RzGMgE= =kKS5 -----END PGP SIGNATURE----- --eawcWMQ/3FYJXdeS--