From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65F091E535 for ; Fri, 22 Sep 2023 09:54:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D052EC433C7; Fri, 22 Sep 2023 09:53:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695376439; bh=H7z4fKWwfHt/OpMTNjdv7ohJQ6EH5tvjq3FwutW6QMc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gwmkFt42xVu1vcM98TDP9FbDvl1kM2xWCZtVpv8PgKCHlYlfZvDAfEFAnvM6pqywJ taIA+rHIPPFAh+65Cd1ltQO3dfhPt2udIQ/1/+Am+a/Lm/YtlJSpFT7Bsbzq9mBynk UPhT31gBweZjJ6tl/MpTObhk5UtLjATiZjK+dntWZUXRo3MKKF+hQlCiMZaLKDnYIl VC2yNCiPuID9kvu9lzxfmnC3x8m5azN2oCgqcbeGqEoFQhAVu6WNZZuNvWHrgB/grZ nzLJs0kIKhhGZxUUpeE687ReEp8wbTlBYqbNuJTC2M+gVLGsjGGTOe4IK65LJBXxxc M8SRasOXpBmWw== Date: Fri, 22 Sep 2023 10:53:55 +0100 From: Conor Dooley To: Delphine_CC_Chiu/WYHQ/Wiwynn Cc: Rob Herring , "patrick@stwcx.xyz" , Jean Delvare , Guenter Roeck , Krzysztof Kozlowski , Conor Dooley , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 2/2] dt-bindings: hwmon: add MAX31790 Message-ID: <20230922-washday-primer-af8dcf1cde7d@spud> References: <20230915062926.2460502-1-Delphine_CC_Chiu@wiwynn.com> <20230915062926.2460502-3-Delphine_CC_Chiu@wiwynn.com> <20230915-quench-left-8fbc1ca3b1da@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jqR+Wa25B9RWlpjh" Content-Disposition: inline In-Reply-To: --jqR+Wa25B9RWlpjh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 22, 2023 at 02:33:06AM +0000, Delphine_CC_Chiu/WYHQ/Wiwynn wrote: > > > On Fri, Sep 15, 2023 at 02:29:24PM +0800, Delphine CC Chiu wrote: > > > > + pwm-as-tach: > > > > > > I don't see any other users of this in-tree, so you'd need a vendor > > > prefix. That said, I'm once bitten, twice shy about fan related > > > properties in hwmon, so I would definitely like Rob to comment on this > > > whole binding. > > > > Please see this[1] and comment on it to ensure it meets your needs. > > Otherwise, omit any fan related properties for now. > > > This property could only be used in max31790 driver. Would it be ok if we add > vendor prefix like "maxim, pwm-as-tach"? I think the answer to this is a pretty straightforward no. The goal is to create a set of common fan properties that works for multiple usecases, not create one specifically for each user... > > > +examples: > > > + - | > > > + i2c { > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + pwm@20 { > > > + compatible = "maxim,max31790"; > > > + reg = <0x20>; > > > + pwm-as-tach = <2 5>; > > > > This would be <2>, <5>; no? > > > I refer to the other binding documents in hwmon and most of them were using > the format like <2 5> as an array. Which also makes this moot, since it'll be going away. > > > diff --git a/MAINTAINERS b/MAINTAINERS index > > > c8fdd0d03907..97e13b6bf51d 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -1371,6 +1371,12 @@ F: > > Documentation/devicetree/bindings/hwmon/adi,max31760.yaml > > > F: Documentation/hwmon/max31760.rst > > > F: drivers/hwmon/max31760.c > > > > > > +ANALOG DEVICES INC MAX31790 DRIVER > > > +M: Delphine CC Chiu > > > +S: Odd Fixes > > > > This is a pretty odd status for something you're newly adding. > > How come it's not going to be maintained? > > > We are not the authors of this driver but we want to add a feature to > config PWM as TACH that was descripted in the datasheet of MAX31790. > Should we set the status to maintained? It's really up to you. I just found it curious & wanted to ask why it was that way. Thanks, Conor. --jqR+Wa25B9RWlpjh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZQ1kMwAKCRB4tDGHoIJi 0lLAAP42Q1Ey8FEtKiZFR8Xg0bWpfzwccwUMfTkgweDQg61O0QEAnpiWqComROc7 bJZJPVn+gHyudSG/DhsxG0NLd8S+Wwk= =eIDN -----END PGP SIGNATURE----- --jqR+Wa25B9RWlpjh--