devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] Add rpm-master-stats nodes for MSM8226 and MSM8974
@ 2023-09-22  0:35 Matti Lehtimäki
  2023-09-22  0:35 ` [PATCH 1/2] ARM: qcom: msm8226: Add rpm-master-stats node Matti Lehtimäki
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Matti Lehtimäki @ 2023-09-22  0:35 UTC (permalink / raw)
  To: linux-arm-msm
  Cc: ~postmarketos/upstreaming, phone-devel, Matti Lehtimäki,
	devicetree, linux-kernel

Add rpm-master-stats nodes and the required RPM MSG RAM slices
for MSM8226 and MSM8974.

Matti Lehtimäki (2):
  ARM: qcom: msm8226: Add rpm-master-stats node
  ARM: qcom: msm8974: Add rpm-master-stats node

 arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 32 ++++++++++++++++++++++++
 arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 32 ++++++++++++++++++++++++
 2 files changed, 64 insertions(+)

-- 
2.39.2


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] ARM: qcom: msm8226: Add rpm-master-stats node
  2023-09-22  0:35 [PATCH 0/2] Add rpm-master-stats nodes for MSM8226 and MSM8974 Matti Lehtimäki
@ 2023-09-22  0:35 ` Matti Lehtimäki
  2023-09-22 16:35   ` Luca Weiss
  2023-09-22  0:35 ` [PATCH 2/2] ARM: qcom: msm8974: " Matti Lehtimäki
  2023-09-28  0:34 ` [PATCH 0/2] Add rpm-master-stats nodes for MSM8226 and MSM8974 Bjorn Andersson
  2 siblings, 1 reply; 6+ messages in thread
From: Matti Lehtimäki @ 2023-09-22  0:35 UTC (permalink / raw)
  To: linux-arm-msm
  Cc: ~postmarketos/upstreaming, phone-devel, Matti Lehtimäki,
	Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, devicetree, linux-kernel

Add rpm-master-stats node for MSM8226 and the required RPM MSG RAM
slices for memory access.

Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
---
 arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 32 ++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
index 44f3f0127fd7..98cc5ea637e1 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
@@ -56,6 +56,18 @@ pmu {
 	rpm: remoteproc {
 		compatible = "qcom,msm8226-rpm-proc", "qcom,rpm-proc";
 
+		master-stats {
+			compatible = "qcom,rpm-master-stats";
+			qcom,rpm-msg-ram = <&apss_master_stats>,
+					   <&mpss_master_stats>,
+					   <&lpss_master_stats>,
+					   <&pronto_master_stats>;
+			qcom,master-names = "APSS",
+					    "MPSS",
+					    "LPSS",
+					    "PRONTO";
+		};
+
 		smd-edge {
 			interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
 			qcom,ipc = <&apcs 8 0>;
@@ -742,6 +754,26 @@ sram@fc190000 {
 		rpm_msg_ram: sram@fc428000 {
 			compatible = "qcom,rpm-msg-ram";
 			reg = <0xfc428000 0x4000>;
+
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges = <0 0xfc428000 0x4000>;
+
+			apss_master_stats: sram@150 {
+				reg = <0x150 0x14>;
+			};
+
+			mpss_master_stats: sram@b50 {
+				reg = <0xb50 0x14>;
+			};
+
+			lpss_master_stats: sram@1550 {
+				reg = <0x1550 0x14>;
+			};
+
+			pronto_master_stats: sram@1f50 {
+				reg = <0x1f50 0x14>;
+			};
 		};
 
 		tcsr_mutex: hwlock@fd484000 {
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ARM: qcom: msm8974: Add rpm-master-stats node
  2023-09-22  0:35 [PATCH 0/2] Add rpm-master-stats nodes for MSM8226 and MSM8974 Matti Lehtimäki
  2023-09-22  0:35 ` [PATCH 1/2] ARM: qcom: msm8226: Add rpm-master-stats node Matti Lehtimäki
@ 2023-09-22  0:35 ` Matti Lehtimäki
  2023-09-22 16:43   ` Luca Weiss
  2023-09-28  0:34 ` [PATCH 0/2] Add rpm-master-stats nodes for MSM8226 and MSM8974 Bjorn Andersson
  2 siblings, 1 reply; 6+ messages in thread
From: Matti Lehtimäki @ 2023-09-22  0:35 UTC (permalink / raw)
  To: linux-arm-msm
  Cc: ~postmarketos/upstreaming, phone-devel, Matti Lehtimäki,
	Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, devicetree, linux-kernel

Add rpm-master-stats node for MSM8974 and the required RPM MSG RAM
slices for memory access.

Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
---
 arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 32 ++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
index 706fef53767e..0bc2e66d15b1 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
@@ -116,6 +116,18 @@ pmu {
 	rpm: remoteproc {
 		compatible = "qcom,msm8974-rpm-proc", "qcom,rpm-proc";
 
+		master-stats {
+			compatible = "qcom,rpm-master-stats";
+			qcom,rpm-msg-ram = <&apss_master_stats>,
+					   <&mpss_master_stats>,
+					   <&lpss_master_stats>,
+					   <&pronto_master_stats>;
+			qcom,master-names = "APSS",
+					    "MPSS",
+					    "LPSS",
+					    "PRONTO";
+		};
+
 		smd-edge {
 			interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
 			qcom,ipc = <&apcs 8 0>;
@@ -1067,6 +1079,26 @@ gcc: clock-controller@fc400000 {
 		rpm_msg_ram: sram@fc428000 {
 			compatible = "qcom,rpm-msg-ram";
 			reg = <0xfc428000 0x4000>;
+
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges = <0 0xfc428000 0x4000>;
+
+			apss_master_stats: sram@150 {
+				reg = <0x150 0x14>;
+			};
+
+			mpss_master_stats: sram@b50 {
+				reg = <0xb50 0x14>;
+			};
+
+			lpss_master_stats: sram@1550 {
+				reg = <0x1550 0x14>;
+			};
+
+			pronto_master_stats: sram@1f50 {
+				reg = <0x1f50 0x14>;
+			};
 		};
 
 		bimc: interconnect@fc380000 {
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: qcom: msm8226: Add rpm-master-stats node
  2023-09-22  0:35 ` [PATCH 1/2] ARM: qcom: msm8226: Add rpm-master-stats node Matti Lehtimäki
@ 2023-09-22 16:35   ` Luca Weiss
  0 siblings, 0 replies; 6+ messages in thread
From: Luca Weiss @ 2023-09-22 16:35 UTC (permalink / raw)
  To: linux-arm-msm, ~postmarketos/upstreaming
  Cc: ~postmarketos/upstreaming, phone-devel, Matti Lehtimäki,
	Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, devicetree, linux-kernel,
	Matti Lehtimäki

On Freitag, 22. September 2023 02:35:32 CEST Matti Lehtimäki wrote:
> Add rpm-master-stats node for MSM8226 and the required RPM MSG RAM
> slices for memory access.
> 
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>

Makes sense from what I can see in msm-3.10 msm8226-v2-pm.dtsi and the driver 
code.

Reviewed-by: Luca Weiss <luca@z3ntu.xyz>

> ---
>  arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 32 ++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
> b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi index 44f3f0127fd7..98cc5ea637e1
> 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
> @@ -56,6 +56,18 @@ pmu {
>  	rpm: remoteproc {
>  		compatible = "qcom,msm8226-rpm-proc", "qcom,rpm-proc";
> 
> +		master-stats {
> +			compatible = "qcom,rpm-master-stats";
> +			qcom,rpm-msg-ram = <&apss_master_stats>,
> +					   <&mpss_master_stats>,
> +					   <&lpss_master_stats>,
> +					   <&pronto_master_stats>;
> +			qcom,master-names = "APSS",
> +					    "MPSS",
> +					    "LPSS",
> +					    "PRONTO";
> +		};
> +
>  		smd-edge {
>  			interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
>  			qcom,ipc = <&apcs 8 0>;
> @@ -742,6 +754,26 @@ sram@fc190000 {
>  		rpm_msg_ram: sram@fc428000 {
>  			compatible = "qcom,rpm-msg-ram";
>  			reg = <0xfc428000 0x4000>;
> +
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges = <0 0xfc428000 0x4000>;
> +
> +			apss_master_stats: sram@150 {
> +				reg = <0x150 0x14>;
> +			};
> +
> +			mpss_master_stats: sram@b50 {
> +				reg = <0xb50 0x14>;
> +			};
> +
> +			lpss_master_stats: sram@1550 {
> +				reg = <0x1550 0x14>;
> +			};
> +
> +			pronto_master_stats: sram@1f50 {
> +				reg = <0x1f50 0x14>;
> +			};
>  		};
> 
>  		tcsr_mutex: hwlock@fd484000 {





^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] ARM: qcom: msm8974: Add rpm-master-stats node
  2023-09-22  0:35 ` [PATCH 2/2] ARM: qcom: msm8974: " Matti Lehtimäki
@ 2023-09-22 16:43   ` Luca Weiss
  0 siblings, 0 replies; 6+ messages in thread
From: Luca Weiss @ 2023-09-22 16:43 UTC (permalink / raw)
  To: linux-arm-msm, ~postmarketos/upstreaming
  Cc: ~postmarketos/upstreaming, phone-devel, Matti Lehtimäki,
	Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, devicetree, linux-kernel,
	Matti Lehtimäki

On Freitag, 22. September 2023 02:35:33 CEST Matti Lehtimäki wrote:
> Add rpm-master-stats node for MSM8974 and the required RPM MSG RAM
> slices for memory access.
> 
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>

Like in the msm8226 patch, also here this appears to match msm8974-v2-pm.dtsi 
/ msm8974pro-pm.dtsi from msm-3.4 kernel.

Reviewed-by: Luca Weiss <luca@z3ntu.xyz>

> ---
>  arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 32 ++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
> b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi index 706fef53767e..0bc2e66d15b1
> 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
> @@ -116,6 +116,18 @@ pmu {
>  	rpm: remoteproc {
>  		compatible = "qcom,msm8974-rpm-proc", "qcom,rpm-proc";
> 
> +		master-stats {
> +			compatible = "qcom,rpm-master-stats";
> +			qcom,rpm-msg-ram = <&apss_master_stats>,
> +					   <&mpss_master_stats>,
> +					   <&lpss_master_stats>,
> +					   <&pronto_master_stats>;
> +			qcom,master-names = "APSS",
> +					    "MPSS",
> +					    "LPSS",
> +					    "PRONTO";
> +		};
> +
>  		smd-edge {
>  			interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
>  			qcom,ipc = <&apcs 8 0>;
> @@ -1067,6 +1079,26 @@ gcc: clock-controller@fc400000 {
>  		rpm_msg_ram: sram@fc428000 {
>  			compatible = "qcom,rpm-msg-ram";
>  			reg = <0xfc428000 0x4000>;
> +
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges = <0 0xfc428000 0x4000>;
> +
> +			apss_master_stats: sram@150 {
> +				reg = <0x150 0x14>;
> +			};
> +
> +			mpss_master_stats: sram@b50 {
> +				reg = <0xb50 0x14>;
> +			};
> +
> +			lpss_master_stats: sram@1550 {
> +				reg = <0x1550 0x14>;
> +			};
> +
> +			pronto_master_stats: sram@1f50 {
> +				reg = <0x1f50 0x14>;
> +			};
>  		};
> 
>  		bimc: interconnect@fc380000 {





^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] Add rpm-master-stats nodes for MSM8226 and MSM8974
  2023-09-22  0:35 [PATCH 0/2] Add rpm-master-stats nodes for MSM8226 and MSM8974 Matti Lehtimäki
  2023-09-22  0:35 ` [PATCH 1/2] ARM: qcom: msm8226: Add rpm-master-stats node Matti Lehtimäki
  2023-09-22  0:35 ` [PATCH 2/2] ARM: qcom: msm8974: " Matti Lehtimäki
@ 2023-09-28  0:34 ` Bjorn Andersson
  2 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2023-09-28  0:34 UTC (permalink / raw)
  To: linux-arm-msm, Matti Lehtimäki
  Cc: ~postmarketos/upstreaming, phone-devel, devicetree, linux-kernel


On Fri, 22 Sep 2023 03:35:31 +0300, Matti Lehtimäki wrote:
> Add rpm-master-stats nodes and the required RPM MSG RAM slices
> for MSM8226 and MSM8974.
> 
> Matti Lehtimäki (2):
>   ARM: qcom: msm8226: Add rpm-master-stats node
>   ARM: qcom: msm8974: Add rpm-master-stats node
> 
> [...]

Applied, thanks!

[1/2] ARM: qcom: msm8226: Add rpm-master-stats node
      commit: bd837be0ff3879209df6fb85cf9e22fd1ba7f79b
[2/2] ARM: qcom: msm8974: Add rpm-master-stats node
      commit: 02c58ac774a03ffefd3708f9c17ea4d911e0ade7

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-09-28  0:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-22  0:35 [PATCH 0/2] Add rpm-master-stats nodes for MSM8226 and MSM8974 Matti Lehtimäki
2023-09-22  0:35 ` [PATCH 1/2] ARM: qcom: msm8226: Add rpm-master-stats node Matti Lehtimäki
2023-09-22 16:35   ` Luca Weiss
2023-09-22  0:35 ` [PATCH 2/2] ARM: qcom: msm8974: " Matti Lehtimäki
2023-09-22 16:43   ` Luca Weiss
2023-09-28  0:34 ` [PATCH 0/2] Add rpm-master-stats nodes for MSM8226 and MSM8974 Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).